From 8c218ff4dd5f970233c43845c19299fc74256389 Mon Sep 17 00:00:00 2001 From: Ignat Beresnev Date: Fri, 29 Apr 2022 15:03:08 +0300 Subject: Enable warnings as errors and fix all warnings (#2451) * Enable warnings as errors and fix all warnings * Enable skip-metadata-version-check compiler setting --- .../utils/assertHtmlEqualsIgnoringWhitespace.kt | 2 +- .../base/src/main/kotlin/parsers/MarkdownParser.kt | 4 +- .../factories/DocTagsFromIElementFactory.kt | 1 + .../src/main/kotlin/renderers/html/HtmlRenderer.kt | 22 ++-- .../main/kotlin/signatures/JvmSignatureUtils.kt | 27 ++-- .../kotlin/signatures/KotlinSignatureProvider.kt | 65 ++++++---- .../main/kotlin/templating/jsonMapperForPlugins.kt | 1 + .../documentables/ActualTypealiasAdder.kt | 6 +- .../documentables/DefaultDocumentableMerger.kt | 6 +- .../DocumentableVisibilityFilterTransformer.kt | 12 +- ...nheritedEntriesDocumentableFilterTransformer.kt | 12 +- .../pages/comments/DocTagToContentConverter.kt | 23 ++-- .../DefaultDescriptorToDocumentableTranslator.kt | 81 ++++++------ plugins/base/src/test/kotlin/basic/DRITest.kt | 11 +- .../kotlin/content/ContentInDescriptionTest.kt | 2 +- .../kotlin/content/params/ContentForParamsTest.kt | 2 +- .../ContentForClassWithParamsAndPropertiesTest.kt | 12 +- .../content/receiver/ContentForReceiverTest.kt | 6 +- .../src/test/kotlin/expect/AbstractExpectTest.kt | 2 +- .../test/kotlin/expectActuals/ExpectActualsTest.kt | 18 +-- .../test/kotlin/filter/JavaVisibilityFilterTest.kt | 14 ++- .../src/test/kotlin/filter/VisibilityFilterTest.kt | 10 ++ .../kotlin/linkableContent/LinkableContentTest.kt | 28 ++--- plugins/base/src/test/kotlin/markdown/KDocTest.kt | 2 +- plugins/base/src/test/kotlin/markdown/LinkTest.kt | 2 +- plugins/base/src/test/kotlin/model/CommentTest.kt | 82 ------------ .../test/kotlin/pageMerger/PageNodeMergerTest.kt | 8 +- .../kotlin/renderers/html/FormattingUtilsTest.kt | 2 +- .../test/kotlin/resourceLinks/ResourceLinksTest.kt | 6 +- .../kotlin/signatures/AbstractRenderingTest.kt | 4 +- .../MergeImplicitExpectActualDeclarationsTest.kt | 6 +- ...efaultDescriptorToDocumentableTranslatorTest.kt | 52 ++++---- .../DefaultPsiToDocumentableTranslatorTest.kt | 1 + .../translators/JavadocInheritedDocTagsTest.kt | 1 + .../dokka/gfm/renderer/CommonmarkRenderer.kt | 19 +-- .../jetbrains/dokka/javadoc/JavadocPageCreator.kt | 11 +- .../dokka/javadoc/pages/htmlPreprocessors.kt | 7 +- .../dokka/javadoc/renderer/KorteJavadocRenderer.kt | 4 +- .../javadoc/JavadocClasslikeTemplateMapTest.kt | 2 + .../dokka/javadoc/JavadocDeprecatedTest.kt | 3 + .../jetbrains/dokka/javadoc/JavadocIndexTest.kt | 3 + .../dokka/javadoc/JavadocPackageTemplateMapTest.kt | 2 + .../kotlin/signatures/JavaSignatureProvider.kt | 18 +-- .../transformers/JvmNameDocumentableTransformer.kt | 9 +- .../AddToNavigationCommandResolutionTest.kt | 137 +++++++++++++++++++++ .../templates/AddToSearchCommandResolutionTest.kt | 83 +++++++++++++ .../templates/SubstitutionCommandResolutionTest.kt | 111 +++++++++++++++++ .../templates/TemplatingDokkaTestGenerator.kt | 69 +++++++++++ .../dokka/templates/TestTemplatingGeneration.kt | 30 +++++ .../dokka/templates/TestTemplatingPlugin.kt | 16 +++ .../AddToNavigationCommandResolutionTest.kt | 137 --------------------- .../templates/AddToSearchCommandResolutionTest.kt | 83 ------------- .../templates/SubstitutionCommandResolutionTest.kt | 111 ----------------- .../templates/TemplatingDokkaTestGenerator.kt | 69 ----------- .../kotlin/templates/TestTemplatingGeneration.kt | 30 ----- .../test/kotlin/templates/TestTemplatingPlugin.kt | 16 --- .../DefaultPreviousDocumentationCopyPostAction.kt | 54 ++++++++ .../versioning/ReplaceVersionCommandConsumer.kt | 50 ++++++++ .../dokka/versioning/ReplaceVersionsCommand.kt | 25 ++++ .../dokka/versioning/VersioningConfiguration.kt | 34 +++++ .../jetbrains/dokka/versioning/VersioningPlugin.kt | 52 ++++++++ .../dokka/versioning/VersioningStorage.kt | 65 ++++++++++ .../dokka/versioning/VersionsNavigationCreator.kt | 86 +++++++++++++ .../jetbrains/dokka/versioning/VersionsOrdering.kt | 23 ++++ .../dokka/versioning/htmlPreprocessors.kt | 38 ++++++ .../DefaultPreviousDocumentationCopyPostAction.kt | 54 -------- .../versioning/ReplaceVersionCommandConsumer.kt | 50 -------- .../kotlin/versioning/ReplaceVersionsCommand.kt | 25 ---- .../kotlin/versioning/VersioningConfiguration.kt | 34 ----- .../src/main/kotlin/versioning/VersioningPlugin.kt | 52 -------- .../main/kotlin/versioning/VersioningStorage.kt | 65 ---------- .../kotlin/versioning/VersionsNavigationCreator.kt | 86 ------------- .../src/main/kotlin/versioning/VersionsOrdering.kt | 23 ---- .../main/kotlin/versioning/htmlPreprocessors.kt | 38 ------ 74 files changed, 1174 insertions(+), 1183 deletions(-) create mode 100644 plugins/templating/src/test/kotlin/org/jetbrains/dokka/templates/AddToNavigationCommandResolutionTest.kt create mode 100644 plugins/templating/src/test/kotlin/org/jetbrains/dokka/templates/AddToSearchCommandResolutionTest.kt create mode 100644 plugins/templating/src/test/kotlin/org/jetbrains/dokka/templates/SubstitutionCommandResolutionTest.kt create mode 100644 plugins/templating/src/test/kotlin/org/jetbrains/dokka/templates/TemplatingDokkaTestGenerator.kt create mode 100644 plugins/templating/src/test/kotlin/org/jetbrains/dokka/templates/TestTemplatingGeneration.kt create mode 100644 plugins/templating/src/test/kotlin/org/jetbrains/dokka/templates/TestTemplatingPlugin.kt delete mode 100644 plugins/templating/src/test/kotlin/templates/AddToNavigationCommandResolutionTest.kt delete mode 100644 plugins/templating/src/test/kotlin/templates/AddToSearchCommandResolutionTest.kt delete mode 100644 plugins/templating/src/test/kotlin/templates/SubstitutionCommandResolutionTest.kt delete mode 100644 plugins/templating/src/test/kotlin/templates/TemplatingDokkaTestGenerator.kt delete mode 100644 plugins/templating/src/test/kotlin/templates/TestTemplatingGeneration.kt delete mode 100644 plugins/templating/src/test/kotlin/templates/TestTemplatingPlugin.kt create mode 100644 plugins/versioning/src/main/kotlin/org/jetbrains/dokka/versioning/DefaultPreviousDocumentationCopyPostAction.kt create mode 100644 plugins/versioning/src/main/kotlin/org/jetbrains/dokka/versioning/ReplaceVersionCommandConsumer.kt create mode 100644 plugins/versioning/src/main/kotlin/org/jetbrains/dokka/versioning/ReplaceVersionsCommand.kt create mode 100644 plugins/versioning/src/main/kotlin/org/jetbrains/dokka/versioning/VersioningConfiguration.kt create mode 100644 plugins/versioning/src/main/kotlin/org/jetbrains/dokka/versioning/VersioningPlugin.kt create mode 100644 plugins/versioning/src/main/kotlin/org/jetbrains/dokka/versioning/VersioningStorage.kt create mode 100644 plugins/versioning/src/main/kotlin/org/jetbrains/dokka/versioning/VersionsNavigationCreator.kt create mode 100644 plugins/versioning/src/main/kotlin/org/jetbrains/dokka/versioning/VersionsOrdering.kt create mode 100644 plugins/versioning/src/main/kotlin/org/jetbrains/dokka/versioning/htmlPreprocessors.kt delete mode 100644 plugins/versioning/src/main/kotlin/versioning/DefaultPreviousDocumentationCopyPostAction.kt delete mode 100644 plugins/versioning/src/main/kotlin/versioning/ReplaceVersionCommandConsumer.kt delete mode 100644 plugins/versioning/src/main/kotlin/versioning/ReplaceVersionsCommand.kt delete mode 100644 plugins/versioning/src/main/kotlin/versioning/VersioningConfiguration.kt delete mode 100644 plugins/versioning/src/main/kotlin/versioning/VersioningPlugin.kt delete mode 100644 plugins/versioning/src/main/kotlin/versioning/VersioningStorage.kt delete mode 100644 plugins/versioning/src/main/kotlin/versioning/VersionsNavigationCreator.kt delete mode 100644 plugins/versioning/src/main/kotlin/versioning/VersionsOrdering.kt delete mode 100644 plugins/versioning/src/main/kotlin/versioning/htmlPreprocessors.kt (limited to 'plugins') diff --git a/plugins/base/base-test-utils/src/main/kotlin/utils/assertHtmlEqualsIgnoringWhitespace.kt b/plugins/base/base-test-utils/src/main/kotlin/utils/assertHtmlEqualsIgnoringWhitespace.kt index 95dcae4e..eeeea265 100644 --- a/plugins/base/base-test-utils/src/main/kotlin/utils/assertHtmlEqualsIgnoringWhitespace.kt +++ b/plugins/base/base-test-utils/src/main/kotlin/utils/assertHtmlEqualsIgnoringWhitespace.kt @@ -1,8 +1,8 @@ package utils -import junit.framework.Assert.assertEquals import org.jsoup.Jsoup import org.jsoup.nodes.Document +import kotlin.test.assertEquals /** * Parses it using JSOUP, trims whitespace at the end of the line and asserts if they are equal diff --git a/plugins/base/src/main/kotlin/parsers/MarkdownParser.kt b/plugins/base/src/main/kotlin/parsers/MarkdownParser.kt index 75617e0c..d3006f33 100644 --- a/plugins/base/src/main/kotlin/parsers/MarkdownParser.kt +++ b/plugins/base/src/main/kotlin/parsers/MarkdownParser.kt @@ -74,7 +74,7 @@ open class MarkdownParser( ).flatMap { it.children } ) - private fun horizontalRulesHandler(node: ASTNode) = + private fun horizontalRulesHandler() = DocTagsFromIElementFactory.getInstance(MarkdownTokenTypes.HORIZONTAL_RULE) private fun emphasisHandler(node: ASTNode) = @@ -353,7 +353,7 @@ open class MarkdownParser( MarkdownElementTypes.ATX_5, MarkdownElementTypes.ATX_6, -> headersHandler(node) - MarkdownTokenTypes.HORIZONTAL_RULE -> horizontalRulesHandler(node) + MarkdownTokenTypes.HORIZONTAL_RULE -> horizontalRulesHandler() MarkdownElementTypes.STRONG -> strongHandler(node) MarkdownElementTypes.EMPH -> emphasisHandler(node) MarkdownElementTypes.FULL_REFERENCE_LINK, diff --git a/plugins/base/src/main/kotlin/parsers/factories/DocTagsFromIElementFactory.kt b/plugins/base/src/main/kotlin/parsers/factories/DocTagsFromIElementFactory.kt index a3cbcc2e..ea87dce8 100644 --- a/plugins/base/src/main/kotlin/parsers/factories/DocTagsFromIElementFactory.kt +++ b/plugins/base/src/main/kotlin/parsers/factories/DocTagsFromIElementFactory.kt @@ -54,6 +54,7 @@ object DocTagsFromIElementFactory { MarkdownTokenTypes.HTML_BLOCK_CONTENT -> Text(body.orEmpty(), params = params + contentTypeParam("html")) else -> CustomDocTag(children, params, type.name) }.let { + @Suppress("UNCHECKED_CAST") when (it) { is List<*> -> it as List else -> listOf(it as DocTag) diff --git a/plugins/base/src/main/kotlin/renderers/html/HtmlRenderer.kt b/plugins/base/src/main/kotlin/renderers/html/HtmlRenderer.kt index 05559469..7ce41866 100644 --- a/plugins/base/src/main/kotlin/renderers/html/HtmlRenderer.kt +++ b/plugins/base/src/main/kotlin/renderers/html/HtmlRenderer.kt @@ -367,8 +367,6 @@ open class HtmlRenderer( pageContext: ContentPage ) = // TODO: extension point there if (node.isImage()) { - //TODO: add imgAttrs parsing - val imgAttrs = node.extra.allOfType().joinAttr() img(src = node.address, alt = node.altText) } else { println("Unrecognized resource type: $node") @@ -377,17 +375,16 @@ open class HtmlRenderer( private fun FlowContent.buildRow( node: ContentGroup, pageContext: ContentPage, - sourceSetRestriction: Set?, - style: Set