1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
|
package translators
import org.jetbrains.dokka.DokkaConfiguration
import org.jetbrains.dokka.base.DokkaBase
import org.jetbrains.dokka.base.testApi.testRunner.BaseAbstractTest
import org.jetbrains.dokka.links.DRI
import org.jetbrains.dokka.model.*
import org.jetbrains.dokka.model.doc.Text
import org.jetbrains.dokka.plugability.DokkaPlugin
import org.junit.jupiter.api.Assertions
import org.junit.jupiter.api.Assertions.*
import org.junit.jupiter.api.Test
import utils.assertNotNull
class DefaultPsiToDocumentableTranslatorTest : BaseAbstractTest() {
@Suppress("DEPRECATION") // for includeNonPublic
val configuration = dokkaConfiguration {
sourceSets {
sourceSet {
sourceRoots = listOf("src/main/java")
includeNonPublic = true
}
}
}
@Test
fun `method overriding two documented classes picks closest class documentation`() {
testInline(
"""
|/src/main/java/sample/BaseClass1.java
|package sample;
|public class BaseClass1 {
| /** B1 */
| void x() { }
|}
|
|/src/main/java/sample/BaseClass2.java
|package sample;
|public class BaseClass2 extends BaseClass1 {
| /** B2 */
| void x() { }
|}
|
|/src/main/java/sample/X.java
|package sample;
|public class X extends BaseClass2 {
| void x() { }
|}
""".trimIndent(),
configuration
) {
documentablesMergingStage = { module ->
val documentationOfFunctionX = module.documentationOf("X", "x")
assertTrue(
"B2" in documentationOfFunctionX,
"Expected nearest super method documentation to be parsed as documentation. " +
"Documentation: $documentationOfFunctionX"
)
}
}
}
@Test
fun `method overriding class and interface picks class documentation`() {
testInline(
"""
|/src/main/java/sample/BaseClass1.java
|package sample;
|public class BaseClass1 {
| /** B1 */
| void x() { }
|}
|
|/src/main/java/sample/Interface1.java
|package sample;
|public interface Interface1 {
| /** I1 */
| void x() {}
|}
|
|/src/main/java/sample/X.java
|package sample;
|public class X extends BaseClass1 implements Interface1 {
| void x() { }
|}
""".trimMargin(),
configuration
) {
documentablesMergingStage = { module ->
val documentationOfFunctionX = module.documentationOf("X", "x")
assertTrue(
"B1" in documentationOfFunctionX,
"Expected documentation of superclass being prioritized over interface " +
"Documentation: $documentationOfFunctionX"
)
}
}
}
@Test
fun `method overriding two classes picks closest documented class documentation`() {
testInline(
"""
|/src/main/java/sample/BaseClass1.java
|package sample;
|public class BaseClass1 {
| /** B1 */
| void x() { }
|}
|
|/src/main/java/sample/BaseClass2.java
|package sample;
|public class BaseClass2 extends BaseClass1 {
| void x() {}
|}
|
|/src/main/java/sample/X.java
|package sample;
|public class X extends BaseClass2 {
| void x() { }
|}
""".trimMargin(),
configuration
) {
documentablesMergingStage = { module ->
val documentationOfFunctionX = module.documentationOf("X", "x")
assertTrue(
"B1" in documentationOfFunctionX,
"Expected Documentation \"B1\", found: \"$documentationOfFunctionX\""
)
}
}
}
@Test
fun `java package-info package description`() {
testInline(
"""
|/src/main/java/sample/BaseClass1.java
|package sample;
|public class BaseClass1 {
| /** B1 */
| void x() { }
|}
|
|/src/main/java/sample/BaseClass2.java
|package sample;
|public class BaseClass2 extends BaseClass1 {
| void x() {}
|}
|
|/src/main/java/sample/X.java
|package sample;
|public class X extends BaseClass2 {
| void x() { }
|}
|
|/src/main/java/sample/package-info.java
|/**
| * Here comes description from package-info
| */
|package sample;
""".trimMargin(),
configuration
) {
documentablesMergingStage = { module ->
val documentationOfPackage = module.packages.single().documentation.values.single().children.single()
.firstMemberOfType<Text>().body
assertEquals(
"Here comes description from package-info", documentationOfPackage
)
}
}
}
@Test
fun `java package-info package annotations`() {
testInline(
"""
|/src/main/java/sample/PackageAnnotation.java
|package sample;
|@java.lang.annotation.Target(java.lang.annotation.ElementType.PACKAGE)
|public @interface PackageAnnotation {
|}
|
|/src/main/java/sample/package-info.java
|@PackageAnnotation
|package sample;
""".trimMargin(),
configuration
) {
documentablesMergingStage = { module ->
assertEquals(
Annotations.Annotation(DRI("sample", "PackageAnnotation"), emptyMap()),
module.packages.single().extra[Annotations]?.directAnnotations?.values?.single()?.single()
)
}
}
}
@Test
fun `should resolve static imports used as annotation param values as literal values`() {
testInline(
"""
|/src/main/java/test/JavaClassUsingAnnotation.java
|package test;
|
|import static test.JavaConstants.STRING;
|import static test.JavaConstants.INTEGER;
|import static test.JavaConstants.LONG;
|import static test.JavaConstants.BOOLEAN;
|import static test.JavaConstants.DOUBLE;
|import static test.JavaConstants.FLOAT;
|
|@JavaAnnotation(
| stringValue = STRING, intValue = INTEGER, longValue = LONG,
| booleanValue = BOOLEAN, doubleValue = DOUBLE, floatValue = FLOAT
|)
|public class JavaClassUsingAnnotation {
|}
|
|/src/main/java/test/JavaAnnotation.java
|package test;
|@Documented
|public @interface JavaAnnotation {
| String stringValue();
| int intValue();
| long longValue();
| boolean booleanValue();
| double doubleValue();
| float floatValue();
|}
|
|/src/main/java/test/JavaConstants.java
|package test;
|public class JavaConstants {
| public static final String STRING = "STRING_CONSTANT_VALUE";
| public static final int INTEGER = 5;
| public static final long LONG = 6L;
| public static final boolean BOOLEAN = true;
| public static final double DOUBLE = 7.0d;
| public static final float FLOAT = 8.0f;
|}
""".trimIndent(),
configuration
) {
documentablesMergingStage = { module ->
val testedClass = module.packages.single().classlikes.single { it.name == "JavaClassUsingAnnotation" }
val annotation = (testedClass as DClass).extra[Annotations]?.directAnnotations?.values?.single()?.single()
checkNotNull(annotation)
assertEquals("JavaAnnotation", annotation.dri.classNames)
assertEquals(StringValue("STRING_CONSTANT_VALUE"), annotation.params["stringValue"])
assertEquals(IntValue(5), annotation.params["intValue"])
assertEquals(LongValue(6), annotation.params["longValue"])
assertEquals(BooleanValue(true), annotation.params["booleanValue"])
assertEquals(DoubleValue(7.0), annotation.params["doubleValue"])
assertEquals(FloatValue(8.0f), annotation.params["floatValue"])
}
}
}
class OnlyPsiPlugin : DokkaPlugin() {
private val dokkaBase by lazy { plugin<DokkaBase>() }
@Suppress("unused")
val psiOverrideDescriptorTranslator by extending {
(dokkaBase.psiToDocumentableTranslator
override dokkaBase.descriptorToDocumentableTranslator)
}
}
// for Kotlin classes from DefaultPsiToDocumentableTranslator
@Test
fun `should resolve ultralight class`() {
val configurationWithNoJVM = dokkaConfiguration {
sourceSets {
sourceSet {
sourceRoots = listOf("src/main/java")
}
}
}
testInline(
"""
|/src/main/java/example/Test.kt
|package example
|
|open class KotlinSubClass {
| fun kotlinSubclassFunction(bar: String): String {
| return "KotlinSubClass"
| }
|}
|
|/src/main/java/example/JavaLeafClass.java
|package example;
|
|public class JavaLeafClass extends KotlinSubClass {
| public String javaLeafClassFunction(String baz) {
| return "JavaLeafClass";
| }
|}
""".trimMargin(),
configurationWithNoJVM,
pluginOverrides = listOf(OnlyPsiPlugin()) // suppress a descriptor translator because of psi and descriptor translators work in parallel
) {
documentablesMergingStage = { module ->
val kotlinSubclassFunction =
module.packages.single().classlikes.find { it.name == "JavaLeafClass" }?.functions?.find { it.name == "kotlinSubclassFunction" }
.assertNotNull("kotlinSubclassFunction ")
assertEquals(
"String",
(kotlinSubclassFunction.type as? TypeConstructor)?.dri?.classNames
)
assertEquals(
"String",
(kotlinSubclassFunction.parameters.firstOrNull()?.type as? TypeConstructor)?.dri?.classNames
)
}
}
}
@Test
fun `should preserve regular functions that look like accessors, but are not accessors`() {
testInline(
"""
|/src/main/java/test/A.java
|package test;
|public class A {
| public int a = 1;
| public void setA() { } // no arg
| public String getA() { return "s"; } // wrong return type
|}
""".trimIndent(),
configuration
) {
documentablesMergingStage = { module ->
val testClass = module.packages.single().classlikes.single { it.name == "A" }
val setterLookalike = testClass.functions.firstOrNull { it.name == "setA" }
assertNotNull(setterLookalike) {
"Expected regular function not found, wrongly categorized as setter?"
}
val getterLookalike = testClass.functions.firstOrNull { it.name == "getA" }
assertNotNull(getterLookalike) {
"Expected regular function not found, wrongly categorized as getter?"
}
}
}
}
@Test
fun `should not associate accessors with field because field is public api`() {
val configuration = dokkaConfiguration {
sourceSets {
sourceSet {
sourceRoots = listOf("src/")
documentedVisibilities = setOf(
DokkaConfiguration.Visibility.PUBLIC,
DokkaConfiguration.Visibility.PROTECTED
)
}
}
}
testInline(
"""
|/src/test/A.java
|package test;
|public class A {
| protected int a = 1;
| public int getA() { return a; }
| public void setA(int a) { this.a = a; }
|}
""".trimIndent(),
configuration
) {
documentablesMergingStage = { module ->
val testedClass = module.packages.single().classlikes.single { it.name == "A" }
val property = testedClass.properties.single { it.name == "a" }
assertEquals(JavaVisibility.Protected, property.visibility.values.single())
assertNull(property.getter)
assertNull(property.setter)
assertEquals(2, testedClass.functions.size)
assertEquals("getA", testedClass.functions[0].name)
assertEquals("setA", testedClass.functions[1].name)
}
}
}
@Test
fun `should add IsVar extra for field with getter and setter`() {
testInline(
"""
|/src/main/java/test/A.java
|package test;
|public class A {
| private int a = 1;
| public int getA() { return a; }
| public void setA(int a) { this.a = a; }
|}
""".trimIndent(),
configuration
) {
documentablesMergingStage = { module ->
val testedClass = module.packages.single().classlikes.single { it.name == "A" }
val property = testedClass.properties.single { it.name == "a" }
assertNotNull(property.extra[IsVar])
}
}
}
@Test
fun `should not add IsVar extra if field does not have a setter`() {
testInline(
"""
|/src/main/java/test/A.java
|package test;
|public class A {
| private int a = 1;
| public int getA() { return a; }
|}
""".trimIndent(),
configuration
) {
documentablesMergingStage = { module ->
val testedClass = module.packages.single().classlikes.single { it.name == "A" }
val property = testedClass.properties.single { it.name == "a" }
assertNull(property.extra[IsVar])
}
}
}
@Test
fun `should add IsVar for non-final java field without any accessors`() {
testInline(
"""
|/src/main/java/test/A.java
|package test;
|public class A {
| private int a = 1;
|}
""".trimIndent(),
configuration
) {
documentablesMergingStage = { module ->
val testedClass = module.packages.single().classlikes.single { it.name == "A" }
val property = testedClass.properties.single { it.name == "a" }
assertNotNull(property.extra[IsVar])
}
}
}
@Test
fun `should not add IsVar for final java field`() {
testInline(
"""
|/src/main/java/test/A.java
|package test;
|public class A {
| public final int a = 2;
|}
""".trimIndent(),
configuration
) {
documentablesMergingStage = { module ->
val testedClass = module.packages.single().classlikes.single { it.name == "A" }
val publicFinal = testedClass.properties.single { it.name == "a" }
assertNull(publicFinal.extra[IsVar])
}
}
}
}
|