aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorRobert Jaros <rjaros@finn.pl>2019-03-14 15:22:23 +0100
committerRobert Jaros <rjaros@finn.pl>2019-03-14 15:22:23 +0100
commitcb27ed25b9e5a448a3de95be41733e90d75d5933 (patch)
tree5b365218e83cb88be961ddf7af1a8d0b362aaa05
parent56f45a8043c24491da9990e10d1cdc9cc22d4eca (diff)
downloadkvision-cb27ed25b9e5a448a3de95be41733e90d75d5933.tar.gz
kvision-cb27ed25b9e5a448a3de95be41733e90d75d5933.tar.bz2
kvision-cb27ed25b9e5a448a3de95be41733e90d75d5933.zip
Refactor DataContainer component to the separate module.
-rw-r--r--build.gradle2
-rw-r--r--kvision-modules/kvision-datacontainer/build.gradle15
-rw-r--r--kvision-modules/kvision-datacontainer/package.json.d/project.info3
-rw-r--r--kvision-modules/kvision-datacontainer/src/main/kotlin/pl/treksoft/kvision/data/DataComponent.kt (renamed from src/main/kotlin/pl/treksoft/kvision/data/DataComponent.kt)0
-rw-r--r--kvision-modules/kvision-datacontainer/src/main/kotlin/pl/treksoft/kvision/data/DataContainer.kt (renamed from src/main/kotlin/pl/treksoft/kvision/data/DataContainer.kt)0
-rw-r--r--kvision-modules/kvision-datacontainer/src/main/kotlin/pl/treksoft/kvision/data/DataUpdatable.kt (renamed from src/main/kotlin/pl/treksoft/kvision/data/DataUpdatable.kt)0
-rw-r--r--kvision-modules/kvision-datacontainer/src/test/kotlin/test/pl/treksoft/kvision/TestUtil.kt99
-rw-r--r--kvision-modules/kvision-datacontainer/src/test/kotlin/test/pl/treksoft/kvision/data/DataContainerSpec.kt (renamed from src/test/kotlin/test/pl/treksoft/kvision/data/DataContainerSpec.kt)0
-rw-r--r--settings.gradle1
-rw-r--r--src/main/kotlin/pl/treksoft/kvision/core/Widget.kt2
10 files changed, 120 insertions, 2 deletions
diff --git a/build.gradle b/build.gradle
index ce6e62e1..2a73cf23 100644
--- a/build.gradle
+++ b/build.gradle
@@ -117,7 +117,6 @@ dependencies {
compile "com.github.snabbdom:snabbdom-kotlin:$snabbdomKotlinVersion"
compile "pl.treksoft:navigo-kotlin:$navigoKotlinVersion"
compile "pl.treksoft:jquery-kotlin:$jqueryKotlinVersion"
- compile "pl.treksoft:kotlin-observable-js:$kotlinObservableVersion"
}
if (!project.gradle.startParameter.taskNames.contains("dokka")) {
@@ -168,6 +167,7 @@ dokka {
'kvision-modules/kvision-handlebars/src/main/kotlin',
'kvision-modules/kvision-i18n/src/main/kotlin',
'kvision-modules/kvision-chart/src/main/kotlin',
+ 'kvision-modules/kvision-datacontainer/src/main/kotlin',
'kvision-modules/kvision-remote/src/main/kotlin',
'kvision-modules/kvision-select-remote/src/main/kotlin',
'kvision-modules/kvision-common/src/main/kotlin',
diff --git a/kvision-modules/kvision-datacontainer/build.gradle b/kvision-modules/kvision-datacontainer/build.gradle
new file mode 100644
index 00000000..7ad09e67
--- /dev/null
+++ b/kvision-modules/kvision-datacontainer/build.gradle
@@ -0,0 +1,15 @@
+apply from: "../shared.gradle"
+
+dependencies {
+ compile "pl.treksoft:kotlin-observable-js:$kotlinObservableVersion"
+}
+
+kotlinFrontend {
+
+ npm {
+ devDependency("karma", "3.1.4")
+ devDependency("karma-chrome-launcher", "2.2.0")
+ devDependency("qunit", "2.8.0")
+ }
+
+}
diff --git a/kvision-modules/kvision-datacontainer/package.json.d/project.info b/kvision-modules/kvision-datacontainer/package.json.d/project.info
new file mode 100644
index 00000000..86ea568f
--- /dev/null
+++ b/kvision-modules/kvision-datacontainer/package.json.d/project.info
@@ -0,0 +1,3 @@
+{
+ "description": "KVision DataContainer module"
+}
diff --git a/src/main/kotlin/pl/treksoft/kvision/data/DataComponent.kt b/kvision-modules/kvision-datacontainer/src/main/kotlin/pl/treksoft/kvision/data/DataComponent.kt
index 4e5b92d5..4e5b92d5 100644
--- a/src/main/kotlin/pl/treksoft/kvision/data/DataComponent.kt
+++ b/kvision-modules/kvision-datacontainer/src/main/kotlin/pl/treksoft/kvision/data/DataComponent.kt
diff --git a/src/main/kotlin/pl/treksoft/kvision/data/DataContainer.kt b/kvision-modules/kvision-datacontainer/src/main/kotlin/pl/treksoft/kvision/data/DataContainer.kt
index 69851b29..69851b29 100644
--- a/src/main/kotlin/pl/treksoft/kvision/data/DataContainer.kt
+++ b/kvision-modules/kvision-datacontainer/src/main/kotlin/pl/treksoft/kvision/data/DataContainer.kt
diff --git a/src/main/kotlin/pl/treksoft/kvision/data/DataUpdatable.kt b/kvision-modules/kvision-datacontainer/src/main/kotlin/pl/treksoft/kvision/data/DataUpdatable.kt
index 7c54e864..7c54e864 100644
--- a/src/main/kotlin/pl/treksoft/kvision/data/DataUpdatable.kt
+++ b/kvision-modules/kvision-datacontainer/src/main/kotlin/pl/treksoft/kvision/data/DataUpdatable.kt
diff --git a/kvision-modules/kvision-datacontainer/src/test/kotlin/test/pl/treksoft/kvision/TestUtil.kt b/kvision-modules/kvision-datacontainer/src/test/kotlin/test/pl/treksoft/kvision/TestUtil.kt
new file mode 100644
index 00000000..9d86766c
--- /dev/null
+++ b/kvision-modules/kvision-datacontainer/src/test/kotlin/test/pl/treksoft/kvision/TestUtil.kt
@@ -0,0 +1,99 @@
+/*
+ * Copyright (c) 2017-present Robert Jaros
+ *
+ * Permission is hereby granted, free of charge, to any person obtaining a copy
+ * of this software and associated documentation files (the "Software"), to deal
+ * in the Software without restriction, including without limitation the rights
+ * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+ * copies of the Software, and to permit persons to whom the Software is
+ * furnished to do so, subject to the following conditions:
+ *
+ * The above copyright notice and this permission notice shall be included in all
+ * copies or substantial portions of the Software.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+ * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+ * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+ * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+ * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+ * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
+ * SOFTWARE.
+ */
+package test.pl.treksoft.kvision
+
+import org.w3c.dom.Element
+import pl.treksoft.jquery.jQuery
+import pl.treksoft.kvision.core.Widget
+import pl.treksoft.kvision.panel.Root
+import kotlin.browser.document
+import kotlin.test.assertEquals
+import kotlin.test.assertTrue
+
+interface TestSpec {
+ fun beforeTest()
+
+ fun afterTest()
+
+ fun run(code: () -> Unit) {
+ beforeTest()
+ code()
+ afterTest()
+ }
+}
+
+interface SimpleSpec : TestSpec {
+
+ override fun beforeTest() {
+ }
+
+ override fun afterTest() {
+ }
+
+}
+
+interface DomSpec : TestSpec {
+
+ override fun beforeTest() {
+ val fixture = "<div style=\"display: none\" id=\"pretest\">" +
+ "<div id=\"test\"></div></div>"
+ document.body?.insertAdjacentHTML("afterbegin", fixture)
+ }
+
+ override fun afterTest() {
+ val div = document.getElementById("pretest")
+ div?.let { jQuery(it).remove() }
+ jQuery(".modal-backdrop").remove()
+ }
+
+ fun assertEqualsHtml(expected: String?, actual: String?, message: String?) {
+ if (expected != null && actual != null) {
+ val exp = jQuery(expected)
+ val act = jQuery(actual)
+ val result = exp[0]?.isEqualNode(act[0])
+ if (result == true) {
+ assertTrue(result == true, message)
+ } else {
+ assertEquals(expected, actual, message)
+ }
+ } else {
+ assertEquals(expected, actual, message)
+ }
+ }
+}
+
+interface WSpec : DomSpec {
+
+ fun runW(code: (widget: Widget, element: Element?) -> Unit) {
+ run {
+ val root = Root("test", true)
+ val widget = Widget()
+ widget.id = "test_id"
+ root.add(widget)
+ val element = document.getElementById("test_id")
+ code(widget, element)
+ }
+ }
+
+}
+
+external fun require(name: String): dynamic
diff --git a/src/test/kotlin/test/pl/treksoft/kvision/data/DataContainerSpec.kt b/kvision-modules/kvision-datacontainer/src/test/kotlin/test/pl/treksoft/kvision/data/DataContainerSpec.kt
index 931294d5..931294d5 100644
--- a/src/test/kotlin/test/pl/treksoft/kvision/data/DataContainerSpec.kt
+++ b/kvision-modules/kvision-datacontainer/src/test/kotlin/test/pl/treksoft/kvision/data/DataContainerSpec.kt
diff --git a/settings.gradle b/settings.gradle
index f87752ef..d73b03a9 100644
--- a/settings.gradle
+++ b/settings.gradle
@@ -12,6 +12,7 @@ include 'kvision-modules:kvision-base',
'kvision-modules:kvision-handlebars',
'kvision-modules:kvision-i18n',
'kvision-modules:kvision-chart',
+ 'kvision-modules:kvision-datacontainer',
'kvision-modules:kvision-remote',
'kvision-modules:kvision-select-remote',
'kvision-modules:kvision-server-jooby',
diff --git a/src/main/kotlin/pl/treksoft/kvision/core/Widget.kt b/src/main/kotlin/pl/treksoft/kvision/core/Widget.kt
index 82a3db48..9a1e556d 100644
--- a/src/main/kotlin/pl/treksoft/kvision/core/Widget.kt
+++ b/src/main/kotlin/pl/treksoft/kvision/core/Widget.kt
@@ -97,7 +97,7 @@ open class Widget(classes: Set<String> = setOf()) : StyledComponent() {
protected var lastLanguage: String? = null
- internal fun <T> singleRender(block: () -> T): T {
+ protected fun <T> singleRender(block: () -> T): T {
getRoot()?.renderDisabled = true
val t = block()
getRoot()?.renderDisabled = false