From bff6c721074bda50e2d5a23d8aa96bf1f939f62a Mon Sep 17 00:00:00 2001 From: Robert Jaros Date: Thu, 27 Feb 2020 09:22:19 +0100 Subject: Fix tests --- src/main/kotlin/pl/treksoft/kvision/core/Widget.kt | 14 ++++++++------ .../kotlin/test/pl/treksoft/kvision/core/WidgetSpec.kt | 17 +++++++++++++++-- 2 files changed, 23 insertions(+), 8 deletions(-) diff --git a/src/main/kotlin/pl/treksoft/kvision/core/Widget.kt b/src/main/kotlin/pl/treksoft/kvision/core/Widget.kt index abff5e37..4dcb62e3 100644 --- a/src/main/kotlin/pl/treksoft/kvision/core/Widget.kt +++ b/src/main/kotlin/pl/treksoft/kvision/core/Widget.kt @@ -358,12 +358,14 @@ open class Widget(classes: Set = setOf()) : StyledComponent(), Component val handlers = on(eventTarget ?: this) (handlers::apply)(blockAsWidget) for (key: String in js("Object").keys(handlers)) { - val handler = handlers.asDynamic()[key] - val map = listenersMap[key] - if (map != null) { - map[handlerCounter] = handler - } else { - listenersMap[key] = mutableMapOf(handlerCounter to handler) + if (key != "self") { + val handler = handlers.asDynamic()[key] + val map = listenersMap[key] + if (map != null) { + map[handlerCounter] = handler + } else { + listenersMap[key] = mutableMapOf(handlerCounter to handler) + } } } refresh() diff --git a/src/test/kotlin/test/pl/treksoft/kvision/core/WidgetSpec.kt b/src/test/kotlin/test/pl/treksoft/kvision/core/WidgetSpec.kt index 42a07ba8..159df178 100644 --- a/src/test/kotlin/test/pl/treksoft/kvision/core/WidgetSpec.kt +++ b/src/test/kotlin/test/pl/treksoft/kvision/core/WidgetSpec.kt @@ -96,16 +96,29 @@ class WidgetSpec : WSpec { fun setEventListener() { runW { widget, _ -> widget.setEventListener { click = { } } - assertTrue("Element should have an event listener") { widget.listenersMap.size == 1 } + assertTrue("Element should have one event listener") { widget.listenersMap["click"]?.size == 1 } + widget.setEventListener { click = { } } + assertTrue("Element should have two event listeners") { widget.listenersMap["click"]?.size == 2 } } } @Test fun removeEventListener() { runW { widget, _ -> + val id = widget.setEventListener { click = { } } + widget.setEventListener { click = { } } + widget.removeEventListener(id) + assertTrue("One of event listeners is removed") { widget.listenersMap["click"]?.size == 1 } + } + } + + @Test + fun removeEventListeners() { + runW { widget, _ -> + widget.setEventListener { click = { } } widget.setEventListener { click = { } } widget.removeEventListeners() - assertTrue("Element should not have any event listener") { widget.listenersMap.size == 0 } + assertTrue("Element should not have any event listeners") { widget.listenersMap.isEmpty() } } } -- cgit