diff options
| author | Roel Spilker <r.spilker@gmail.com> | 2014-02-20 21:03:13 +0100 |
|---|---|---|
| committer | Roel Spilker <r.spilker@gmail.com> | 2014-02-20 21:03:13 +0100 |
| commit | c72e2a273233719750af0f41e842f705292888ac (patch) | |
| tree | 82a06c796980172dc1b98fee0e018990cf543948 /doc | |
| parent | dccbcd8f5c25f6de88137003d97c4815007c35bc (diff) | |
| download | lombok-c72e2a273233719750af0f41e842f705292888ac.tar.gz lombok-c72e2a273233719750af0f41e842f705292888ac.tar.bz2 lombok-c72e2a273233719750af0f41e842f705292888ac.zip | |
[suspect:eclipse] Fix for issue 633: refactor script 'extract local variable' did not work inside for example SneakyThrows-protected methods.
This fix is reverting the change in e835daa9.
During conversion of the internal.ast to the dom AST, a flag is introduced
named 'ORIGINAL'. Commit e835daa9 always explicitly cleared it for
all lombok-generated nodes, in an attempt to try and do the appropriate thing,
treating the ORIGINAL flag as a simile for 'generated code'.
Unfortunately, for eclipse code analysis, all our generated code should be
treated as if it's "really" there, and in general this doesn't work because
eclipse's concept of 'generated' applies to explicit super() calls and the like,
not the kind of stuff lombok introduces.
Diffstat (limited to 'doc')
| -rw-r--r-- | doc/changelog.markdown | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/doc/changelog.markdown b/doc/changelog.markdown index 55a95ba5..e5b46428 100644 --- a/doc/changelog.markdown +++ b/doc/changelog.markdown @@ -2,6 +2,7 @@ Lombok Changelog ---------------- ### v1.12.5 "Edgy Guinea Pig" +* BUGFIX: Eclipse refactoring _Extract Local Variable_ didn't work inside `@SneakyThrows` annotated methods [Issue #633](https://code.google.com/p/projectlombok/issues/detail?id=633). * FEATURE: The various `@Log` annotations now support the `topic` parameter, which sets the logger's name. The default remains the fully qualified type name of the class itself. [Issue #632](https://code.google.com/p/projectlombok/issues/detail?id=632). * BUGFIX: {Netbeans} @SneakyThrows would lead to unused import and break refactorings [Issue #471](https://code.google.com/p/projectlombok/issues/detail?id=471). * BUGFIX: Eclipse Organize Imports would generate error: AST must not be null [Issue #631](https://code.google.com/p/projectlombok/issues/detail?id=631). |