aboutsummaryrefslogtreecommitdiff
path: root/src/lombok/eclipse/handlers/HandleData.java
diff options
context:
space:
mode:
authorReinier Zwitserloot <reinier@tipit.to>2009-08-27 23:16:47 +0200
committerReinier Zwitserloot <reinier@tipit.to>2009-08-27 23:16:47 +0200
commit4e152f2f1485f904feb45ae614236d4aa4b6edc9 (patch)
treeaa7de35a215a5d7077e27e0ef4c1699e9c56779b /src/lombok/eclipse/handlers/HandleData.java
parent0221e460b2e648b142284c6c462d5798f33a3ff7 (diff)
parentfe0da3f53f1e88b704e21463cc5fea3d998e394a (diff)
downloadlombok-4e152f2f1485f904feb45ae614236d4aa4b6edc9.tar.gz
lombok-4e152f2f1485f904feb45ae614236d4aa4b6edc9.tar.bz2
lombok-4e152f2f1485f904feb45ae614236d4aa4b6edc9.zip
Merge branch 'nonnull'
Conflicts: src/lombok/eclipse/handlers/HandleData.java src/lombok/eclipse/handlers/HandleEqualsAndHashCode.java src/lombok/eclipse/handlers/HandleSetter.java src/lombok/javac/handlers/HandleData.java src/lombok/javac/handlers/HandleEqualsAndHashCode.java src/lombok/javac/handlers/HandleSetter.java
Diffstat (limited to 'src/lombok/eclipse/handlers/HandleData.java')
-rw-r--r--src/lombok/eclipse/handlers/HandleData.java21
1 files changed, 18 insertions, 3 deletions
diff --git a/src/lombok/eclipse/handlers/HandleData.java b/src/lombok/eclipse/handlers/HandleData.java
index b598313b..f072ea64 100644
--- a/src/lombok/eclipse/handlers/HandleData.java
+++ b/src/lombok/eclipse/handlers/HandleData.java
@@ -89,7 +89,8 @@ public class HandleData implements EclipseAnnotationHandler<Data> {
//Skip static fields.
if ( (fieldDecl.modifiers & ClassFileConstants.AccStatic) != 0 ) continue;
boolean isFinal = (fieldDecl.modifiers & ClassFileConstants.AccFinal) != 0;
- if ( isFinal && fieldDecl.initialization == null ) nodesForConstructor.add(child);
+ boolean isNonNull = findAnnotations(fieldDecl, NON_NULL_PATTERN).length != 0;
+ if ( (isFinal || isNonNull) && fieldDecl.initialization == null ) nodesForConstructor.add(child);
new HandleGetter().generateGetterForField(child, annotationNode.get());
if ( !isFinal ) new HandleSetter().generateSetterForField(child, annotationNode.get());
}
@@ -139,18 +140,27 @@ public class HandleData implements EclipseAnnotationHandler<Data> {
List<Argument> args = new ArrayList<Argument>();
List<Statement> assigns = new ArrayList<Statement>();
+ List<Statement> nullChecks = new ArrayList<Statement>();
for ( Node fieldNode : fields ) {
FieldDeclaration field = (FieldDeclaration) fieldNode.get();
FieldReference thisX = new FieldReference(("this." + new String(field.name)).toCharArray(), p);
thisX.receiver = new ThisReference((int)(p >> 32), (int)p);
thisX.token = field.name;
+
assigns.add(new Assignment(thisX, new SingleNameReference(field.name, p), (int)p));
long fieldPos = (((long)field.sourceStart) << 32) | field.sourceEnd;
- args.add(new Argument(field.name, fieldPos, copyType(field.type), Modifier.FINAL));
+ Argument argument = new Argument(field.name, fieldPos, copyType(field.type), Modifier.FINAL);
+ Annotation[] nonNulls = findAnnotations(field, NON_NULL_PATTERN);
+ Annotation[] nullables = findAnnotations(field, NULLABLE_PATTERN);
+ if (nonNulls.length != 0) nullChecks.add(generateNullCheck(field));
+ Annotation[] copiedAnnotations = copyAnnotations(nonNulls, nullables);
+ if (copiedAnnotations.length != 0) argument.annotations = copiedAnnotations;
+ args.add(argument);
}
- constructor.statements = assigns.isEmpty() ? null : assigns.toArray(new Statement[assigns.size()]);
+ nullChecks.addAll(assigns);
+ constructor.statements = nullChecks.isEmpty() ? null : nullChecks.toArray(new Statement[nullChecks.size()]);
constructor.arguments = args.isEmpty() ? null : args.toArray(new Argument[args.size()]);
return constructor;
}
@@ -188,6 +198,11 @@ public class HandleData implements EclipseAnnotationHandler<Data> {
FieldDeclaration field = (FieldDeclaration) fieldNode.get();
long fieldPos = (((long)field.sourceStart) << 32) | field.sourceEnd;
assigns.add(new SingleNameReference(field.name, fieldPos));
+
+ Argument argument = new Argument(field.name, fieldPos, copyType(field.type), 0);
+ Annotation[] copiedAnnotations = copyAnnotations(
+ findAnnotations(field, NON_NULL_PATTERN), findAnnotations(field, NULLABLE_PATTERN));
+ if (copiedAnnotations.length != 0) argument.annotations = copiedAnnotations;
args.add(new Argument(field.name, fieldPos, copyType(field.type), Modifier.FINAL));
}