diff options
Diffstat (limited to 'src/core')
-rw-r--r-- | src/core/lombok/eclipse/TransformEclipseAST.java | 3 | ||||
-rw-r--r-- | src/core/lombok/eclipse/handlers/HandleLog.java | 2 | ||||
-rw-r--r-- | src/core/lombok/eclipse/handlers/HandleSynchronized.java | 2 | ||||
-rw-r--r-- | src/core/lombok/javac/JavacResolution.java | 60 | ||||
-rw-r--r-- | src/core/lombok/javac/apt/LombokProcessor.java | 4 |
5 files changed, 59 insertions, 12 deletions
diff --git a/src/core/lombok/eclipse/TransformEclipseAST.java b/src/core/lombok/eclipse/TransformEclipseAST.java index 201d4695..87b163c0 100644 --- a/src/core/lombok/eclipse/TransformEclipseAST.java +++ b/src/core/lombok/eclipse/TransformEclipseAST.java @@ -54,9 +54,6 @@ import org.eclipse.jdt.internal.compiler.parser.Parser; * (re)parse it. You should set Bit24 on any MethodDeclaration object you inject into the AST: * * {@code methodDeclaration.bits |= ASTNode.Bit24; //0x800000} - * - * @author rzwitserloot - * @author rspilker */ public class TransformEclipseAST { private final EclipseAST ast; diff --git a/src/core/lombok/eclipse/handlers/HandleLog.java b/src/core/lombok/eclipse/handlers/HandleLog.java index df3989a4..525f534a 100644 --- a/src/core/lombok/eclipse/handlers/HandleLog.java +++ b/src/core/lombok/eclipse/handlers/HandleLog.java @@ -104,7 +104,7 @@ public class HandleLog { ClassLiteralAccess loggingType = selfType(owner, source); FieldDeclaration fieldDeclaration = createField(framework, source, loggingType, logFieldName.getName(), useStatic, loggerTopic); fieldDeclaration.traverse(new SetGeneratedByVisitor(source), typeDecl.staticInitializerScope); - // TODO temporary workaround for issue 290. https://github.com/rzwitserloot/lombok/issues/290 + // TODO temporary workaround for issue 290. https://github.com/projectlombok/lombok/issues/290 // injectFieldSuppressWarnings(owner, fieldDeclaration); injectField(owner, fieldDeclaration); owner.rebuild(); diff --git a/src/core/lombok/eclipse/handlers/HandleSynchronized.java b/src/core/lombok/eclipse/handlers/HandleSynchronized.java index 18d1e7b7..dbe363d9 100644 --- a/src/core/lombok/eclipse/handlers/HandleSynchronized.java +++ b/src/core/lombok/eclipse/handlers/HandleSynchronized.java @@ -122,7 +122,7 @@ public class HandleSynchronized extends EclipseAnnotationHandler<Synchronized> { fieldDecl.type = new QualifiedTypeReference(TypeConstants.JAVA_LANG_OBJECT, new long[] { 0, 0, 0 }); setGeneratedBy(fieldDecl.type, source); fieldDecl.initialization = arrayAlloc; - // TODO temporary workaround for issue 290. https://github.com/rzwitserloot/lombok/issues/290 + // TODO temporary workaround for issue 290. https://github.com/projectlombok/lombok/issues/290 // injectFieldSuppressWarnings(annotationNode.up().up(), fieldDecl); injectField(annotationNode.up().up(), fieldDecl); } diff --git a/src/core/lombok/javac/JavacResolution.java b/src/core/lombok/javac/JavacResolution.java index e96079e0..f1109f4e 100644 --- a/src/core/lombok/javac/JavacResolution.java +++ b/src/core/lombok/javac/JavacResolution.java @@ -1,5 +1,5 @@ /* - * Copyright (C) 2011-2020 The Project Lombok Authors. + * Copyright (C) 2011-2021 The Project Lombok Authors. * * Permission is hereby granted, free of charge, to any person obtaining a copy * of this software and associated documentation files (the "Software"), to deal @@ -29,6 +29,7 @@ import java.lang.reflect.Method; import java.util.ArrayDeque; import java.util.Collection; import java.util.Iterator; +import java.util.LinkedHashMap; import java.util.Map; import java.util.NoSuchElementException; @@ -45,6 +46,7 @@ import com.sun.tools.javac.code.Type.ClassType; import com.sun.tools.javac.code.Type.TypeVar; import com.sun.tools.javac.code.Type.WildcardType; import com.sun.tools.javac.code.Types; +import com.sun.tools.javac.comp.ArgumentAttr; import com.sun.tools.javac.comp.Attr; import com.sun.tools.javac.comp.AttrContext; import com.sun.tools.javac.comp.Enter; @@ -68,6 +70,7 @@ import lombok.core.debug.AssertionLogger; import lombok.permit.Permit; public class JavacResolution { + private final Context context; private final Attr attr; private final CompilerMessageSuppressor messageSuppressor; @@ -82,6 +85,7 @@ public class JavacResolution { } public JavacResolution(Context context) { + this.context = context; attr = Attr.instance(context); messageSuppressor = new CompilerMessageSuppressor(context); } @@ -245,10 +249,19 @@ public class JavacResolution { } catch (Throwable ignore) { // This addresses issue #1553 which involves JDK9; if it doesn't exist, we probably don't need to set it. } - if (tree instanceof JCBlock) attr.attribStat(tree, env); - else if (tree instanceof JCMethodDecl) attr.attribStat(((JCMethodDecl) tree).body, env); - else if (tree instanceof JCVariableDecl) attr.attribStat(tree, env); - else throw new IllegalStateException("Called with something that isn't a block, method decl, or variable decl"); + + Map<?,?> cache = null; + try { + cache = ArgumentAttrReflect.enableTempCache(context); + + if (tree instanceof JCBlock) attr.attribStat(tree, env); + else if (tree instanceof JCMethodDecl) attr.attribStat(((JCMethodDecl) tree).body, env); + else if (tree instanceof JCVariableDecl) attr.attribStat(tree, env); + else throw new IllegalStateException("Called with something that isn't a block, method decl, or variable decl"); + } finally { + ArgumentAttrReflect.restoreCache(cache, context); + } + } public static class TypeNotConvertibleException extends Exception { @@ -283,6 +296,43 @@ public class JavacResolution { } } + /** + * ArgumentAttr was added in Java 9 and caches some method arguments. Lombok should cleanup its changes after resolution. + */ + private static class ArgumentAttrReflect { + private static Field ARGUMENT_TYPE_CACHE; + + static { + if (Javac.getJavaCompilerVersion() >= 9) { + try { + ARGUMENT_TYPE_CACHE = Permit.getField(ArgumentAttr.class, "argumentTypeCache"); + } catch (Exception ignore) {} + } + } + + public static Map<?, ?> enableTempCache(Context context) { + if (ARGUMENT_TYPE_CACHE == null) return null; + + ArgumentAttr argumentAttr = ArgumentAttr.instance(context); + try { + Map<?, ?> cache = (Map<?, ?>) Permit.get(ARGUMENT_TYPE_CACHE, argumentAttr); + Permit.set(ARGUMENT_TYPE_CACHE, argumentAttr, new LinkedHashMap<Object, Object>(cache)); + return cache; + } catch (Exception ignore) { } + + return null; + } + + public static void restoreCache(Map<?, ?> cache, Context context) { + if (ARGUMENT_TYPE_CACHE == null) return; + + ArgumentAttr argumentAttr = ArgumentAttr.instance(context); + try { + Permit.set(ARGUMENT_TYPE_CACHE, argumentAttr, cache); + } catch (Exception ignore) { } + } + } + public static Type ifTypeIsIterableToComponent(Type type, JavacAST ast) { if (type == null) return null; Types types = Types.instance(ast.getContext()); diff --git a/src/core/lombok/javac/apt/LombokProcessor.java b/src/core/lombok/javac/apt/LombokProcessor.java index 6552f15b..ed713b1d 100644 --- a/src/core/lombok/javac/apt/LombokProcessor.java +++ b/src/core/lombok/javac/apt/LombokProcessor.java @@ -410,8 +410,8 @@ public class LombokProcessor extends AbstractProcessor { try { path = trees.getPath(element); } catch (NullPointerException ignore) { - // Happens if a package-info.java dowsn't conatin a package declaration. - // https://github.com/rzwitserloot/lombok/issues/2184 + // Happens if a package-info.java doesn't contain a package declaration. + // https://github.com/projectlombok/lombok/issues/2184 // We can safely ignore those, since they do not need any processing } } |