aboutsummaryrefslogtreecommitdiff
path: root/src/lombok/javac/handlers
AgeCommit message (Collapse)Author
2009-09-03Addressed issue #32: The @EqualsAndHashCode and @ToString annotations now ↵Reinier Zwitserloot
support explicitly listing the fields to use, via the new 'of' parameter. We've also added any fields that start with $ to the default excludes list. Lombok itself can generate these fields ($lock of @Synchronized, for example), and in general they probably should count as effectively not part of the class.
2009-08-28null checks are no longer generated if you put @NonNull on primitives.Reinier Zwitserloot
2009-08-27Merge branch 'nonnull'Reinier Zwitserloot
Conflicts: src/lombok/eclipse/handlers/HandleData.java src/lombok/eclipse/handlers/HandleEqualsAndHashCode.java src/lombok/eclipse/handlers/HandleSetter.java src/lombok/javac/handlers/HandleData.java src/lombok/javac/handlers/HandleEqualsAndHashCode.java src/lombok/javac/handlers/HandleSetter.java
2009-08-27Now @Nullable is also copied over.Reinier Zwitserloot
2009-08-27Made all parameters of all generated methods 'final'.Reinier Zwitserloot
2009-08-01The warning for not enabling callSuper cannot be avoided, but there are ↵Reinier Zwitserloot
legal reasons for using it, so, changed it: explicitly setting 'callSuper=false' removes the warning. You only get the warning if callSuper is false because that's the default. Fixes issue #13
2009-08-01The constructors will now also add non-final fields if they have a NonNull ↵Roel Spilker
annotation The constructor will test for null-values The constructor and static constructor will copy the NonNull annotations from the fields
2009-08-01Moved the check to see if a variable is null to the PKG utility classesRoel Spilker
2009-08-01@Setter will copy all NotNull and NonNull (case-insensitive) annotations to ↵Roel Spilker
the parameter @Getter will copy them to the getter method Added @NonNull to lombok to support null-checks in the setter
2009-07-31Added support for @NonNull in the @Setter annotationRoel Spilker
2009-07-28Changed the way toString is generated to reduce the number of superfluous ↵Reinier Zwitserloot
'plus' nodes (e.g. concatenating the infix ", " and a field name literal such as "width=" into ", width=". Also removed the [] brackets from the supercall, as, if you're chaining to another lombok-generated toString, those are superfluous - lombok's toString includes parentheses already.
2009-07-27Split off generation of equals() and hashCode() methods form @Data into a ↵Reinier Zwitserloot
new annotation, @EqualsAndHashCode. Addresses issue #8
2009-07-27[TRIVIAL]Reinier Zwitserloot
2009-07-27[TRIVIAL]Reinier Zwitserloot
2009-07-27Added support for @ToString annotation. The code for generating toStrings ↵Reinier Zwitserloot
has now moved from HandleData to the new HandleToString.
2009-07-26Addresses issue #5:Reinier Zwitserloot
hitting 'find callers' on a @Data annotation should find callers of the (static) constructor. Right now it'll find callers to the *static* constructor ONLY. Letting it find callers of the public constructor if there is no static constructor just doesn't work.
2009-07-26[TRIVIAL]Reinier Zwitserloot
2009-07-26Addresses issue #4:Reinier Zwitserloot
If boolean fields already start with a typical getter prefix (is, has, or get), lombok's @Getter will no longer generate its own prefix as well, so a field named 'hasFoo' will result in a getter named 'hasFoo()', not 'isHasFoo()'. Also, if any likely getter name already exists for a boolean, a getter will not be generated. Thus, if your field is called 'hasFoo', and you already have a method named 'isFoo', then @Getter will not generate anything (and warn, unless the getter is being generated due to @Data). This last mechanism works by taking the field name *AND* any other likely base names (defined by the field name being named as prefix+baseName, with prefix being is/has/get), and then prefixing all the likely fieldnames with is/has/get, and checking if any method with that name exists. Of course, this means weird things are going to happen if you have 2 fields named 'isFoo' and 'hasFoo', but then, you'd be a real idiot if you did that.
2009-07-18No constructor entry should be made for assigned final fieldsRoel Spilker
2009-07-18Refactored the name of the cleanup method arg to 'value'.Reinier Zwitserloot
2009-07-12More fixes to avoid erroneous "getter/setter is already there, not ↵Reinier Zwitserloot
generating it" warnings when the getter/setter already there was in fact generated by lombok, and fixed a bug in eclipse where a boolean array's getter method would be called isFoo() instead of getFoo().
2009-07-11'fixed' data up a bit by including only the final fields for the constructor.Reinier Zwitserloot
Also fixed a bug in javac's toString() generation for the @Data constructor. It did not include the transient fields.
2009-07-11The setter/getter handlers now mark themselves as not wanted to be called ↵Reinier Zwitserloot
upon anymore when reporting errors. They were logging 4 or more identical warnings per problem before this change.
2009-07-06Last massive documentation dump. All basic javadoc is now done, though ↵Reinier Zwitserloot
especially the docs on the lombok annotations in the lombok package need far more massaging. Also added a feature to HandleSynchronized to not auto-generate the locker fields if a specific name is provided (because, imagine you typoed those. You'd never find it!)
2009-07-03Fine-tuning eclipse's error reporting found some minor issues and even 1 bug ↵Reinier Zwitserloot
that would show up rarely or not at all.
2009-07-01Added @SneakyThrows support for javac. W00t.Reinier Zwitserloot
2009-07-01Added ability to @Synchronized to explicitly name the lock object.Reinier Zwitserloot
Spruced up @Cleanup's position settings and also forced initialization, because the error appears in a screwed up place if you don't, and we can't seem to move it.
2009-07-01Added @Synchronized support to javac. Seems to work well.Reinier Zwitserloot
2009-07-01Added a bonus feature to @Cleanup: Assigning a @Cleanup marked variable to ↵Reinier Zwitserloot
anything else generates a warning.
2009-07-01Added HandleCleanup support for javac, and fixed a bug in AST.java which ↵Reinier Zwitserloot
caused nested @Cleanup annotations to simply be ignored (rebuild was broken). HandleCleanup seems to work swimmingly now on both targets. yay!
2009-06-27[IMPROVEMENT]Reinier Zwitserloot
Eclipse will now also hold off on running @PrintAST handlers until the very end. Simple generators such as @Getter didn't need this, because PrintAST's handler will hold off until eclipse does a full parse, but when changing the innards of methods, you would likely not see what you did. Fixed that. Also, PrintAST has an option to, instead of diving into the ASTNodes of bodies (methods, initializers, etc), to just render the java code, to see if the AST creation/rewriting you've been doing looks like the java code you intended.
2009-06-25Added support for generating toString to javac's HandleData. Now javac's ↵Reinier Zwitserloot
HandleData is COMPLETE! w00t!
2009-06-25Added generating hashCode() to javac's HandleData.Reinier Zwitserloot
2009-06-25javac's HandleData now makes equals methods.Reinier Zwitserloot
2009-06-24javac's HandleData now generates the constructor only if it doesn't already ↵Reinier Zwitserloot
exist, and the staticConstructor is now also completed. Left: toString, hashCode, equals.
2009-06-24Work on HandleData, as well as generalizing features in the the PKG class ↵Reinier Zwitserloot
and updating HandleGetter/Setter to call into it.
2009-06-21Due to a java bug, constants in enums don't work, so instead the default ↵Reinier Zwitserloot
access level for @Getter and @Setter have now just been hardcoded in GetterHandler and SetterHandler. Added ability to look up the Node object for any given AST object on Node itself, as you don't usually have the AST object. Added toString() method generating to @Data, and this required some fancy footwork in finding if we've already generated methods, and editing a generated method to fill in binding and type resolutions. HandleGetter and HandleSetter have been updated to use these features. Exceptions caused by lombok handlers show up in the eclipse error log, but now, if they are related to a CompilationUnit, also as a problem (error) on the CUD - those error log entries are easy to miss! Our ASTs can now be appended to. When you generate a new AST node, you should add it to the AST, obviously. Getter/Setter have been updated to use this.
2009-06-19Added initial support for the @Data annotation. Currently produces getters ↵Reinier Zwitserloot
and setters only, not yet a constructor, toString, hashCode, or equals. HandleGetter and HandleSetter have been updated to handle static (theoretic; you can't put annotations on static fields normally). You can now make AnnotationValue objects using just an annotationNode and a target type, as well as check if a given annotationNode is likely to represent a target annotation type. This is in Javac and Eclipse classes. HandleGetter and HandleSetter can now be asked to make a getter/setter, and will grab access level off of a Getter/Setter annotation, if present.
2009-06-18Created a fully working HandleSetter for eclipse, and refactored ↵Reinier Zwitserloot
HandleGetter a little mostly to stuff common code into PKG.
2009-06-18Expanded the AST printers to support a target PrintStream, and expanded the ↵Reinier Zwitserloot
@PrintAST annotation to let you supply an optional filename. Useful particularly for IDEs, which don't usually have a viewable console. Also renamed the printers to just 'Printer', as they are already inner classes of a specifically named type (JavacASTVisitor & co).
2009-06-17AnnotationHandlers can now return a boolean to set if they actually handled ↵Reinier Zwitserloot
the annotation or not (previously, the presumption was they always handled the annotation). This is very useful for PrintAST on eclipse, because before this change, you'd never see method contents (as the initial dietParse would come first). Now Eclipse PrintASTHandler will skip any non-full runs, and only print non-diet. It then returns true only if it printed.
2009-06-17Added 'does setX/getX already exist' check to javac's HandleGetter/Setter. ↵Reinier Zwitserloot
If they exist (with any returntype/paramlist), no getter/setter is generated, and instead a warning is added on the annotation.
2009-06-17Added the SetterHandler for javac. Also added a way to get the SymbolTable ↵Reinier Zwitserloot
on a JavacAST.Node, because you need it to e.g. access constant types like 'void'.
2009-06-17A useful annotation that prints the AST of any annotated element via the ↵Reinier Zwitserloot
XASTPrinters in each ASTVisitor interface.
2009-06-17Just renamed some parameters to more sensical names.Reinier Zwitserloot
2009-06-17Renamed the Handler implementations.Reinier Zwitserloot
2009-06-17Massive refactors. This list isn't complete, but should give you an idea:Reinier Zwitserloot
A) many things in lombok.eclipse moved to lombok.core to enable reuse with lombok.javac. B) lombok.javac works now similarly to eclipse's model: We first make big ASTs that are bidirectionally traversable, then we walk through that for annotations. C) Instead of getting an annotation instance, you now get an object that is more flexible and can e.g. give you class values in an enum as a string instead of a Class object, which may fail if that class isn't on the classpath of lombok. D) sources to the internal sun classes for javac added to /contrib.
2009-06-16Removed debug prints.Reinier Zwitserloot
2009-06-16Implemented a lot of stuff for javac, but we ran into 2 major issues still ↵Reinier Zwitserloot
to be implemented: 1. The visit mode of a lombok handler (does not trigger off of annotations, instead sees every field, method, type, and statement), needs to be coded, 2. triggering off of annotations via APT's annotation handling system skips method-local classes. We'll need to recode this via an AST visitor like we need for issue #1 Other than that, triggering off of annotations works swimmingly!