Age | Commit message (Collapse) | Author |
|
via the LombokAST object. Instead its tracked more directly in an attempt
to avoid having to write all handlers as idempotent, and just in case
issue #164 is a race condition (the handled-or-not is a synchronized CAS check).
This does break API for other plugins, but the fix is trivial: Just make your
'handle' method return void. That 'we won't call you again' business in the decks
never quite worked right anyway.
Also, you might want to call Javac.(recursive)setHandledBy when you generate nodes, now.
|
|
HandleDelegate was called multiple times for the same field resulting in an error saying the delegate method was already defined.
Also added a test for @Delegate that uncovered this issue.
|
|
it won't actually work right; method-level generics would break.
The new way is to use -javaagent:lombok.jar=ECJ in addition to -cp lombok.jar
|
|
the actual package.
See discussion at https://groups.google.com/d/topic/project-lombok/64zuUlLnVMc/discussion
|
|
against situations in which lombok can't possibly work, since there is not enough of eclipse on the classpath. Major example of this is when we are called through jsps in the eclipse help.
Also added an extra check before the patchval is performed by checking if previous patch calls failed in TransformEclipseAST.
This fixes Issue #207.
|
|
|
|
NoSuchClassErrors.
|
|
eclipse-like executable patterns. Probably fixes issue #196
|
|
|
|
platforms
|
|
|
|
works.
|
|
Solves issue 210.
|
|
preclude them from being generated, which means you get duplicate method errors.
excludes=Types has been added to counteract this. Once we figure out how to
resolve method sigs out of order we can go back to the original plan.
|
|
|
|
NoSuchMethodError: CastExpression.<init>
This commit fixes this (now lombok works both <3.7 and 3.7).
fixes issue #206
|
|
a user runs into issue #164, we can get a more useful stracktrace from them.
|
|
|
|
At this revision, you can easily and reliably reproduce issue #164 by
creating a loop (A delegates B and B delegates A).
|
|
Lombok.preventNullAnalysis but go with Collections.singletonList(expr).get(0)
instead; while this does create a pointless object, it doesn't cause a clash
when eclipse has lombok 0.10 installed but the project uses 0.9, which doesn't
have preventNullAnalysis. Eventually, once 0.9 is long forgotten, this can be reverted.
|
|
|
|
IllegalStateException. Fixed.
|
|
JavacProcessingEnvironment would occur when using the m2eclipse plugin, for example when removing an entry from the build path.
The actual change is small but this took quite some searching. m2eclipse uses plexus, and plexus uses a custom classloader, which means lombok can't find the JavacProcessingEnvironment loaded by that classloader.
We fix it here by adding lombok to that custom classloader. Perhaps more die-hard m2eclipse users find a problem with this approach, but assuming these plexus compile runs are stand-alone, this should work great.
fixed by Roel and Reinier.
|
|
|
|
|
|
'isFoo', 'hasFoo', or 'getFoo' would trigger specialized handling for @Getter/@Setter. However, this special handling broke the bean spec, and has been simplified: Only fields named 'isFoo', and only if that field's type is 'boolean', results in both 'isFoo' and 'foo' being considered as possible property names for this property, with 'foo' preferred, so that @Getter boolean isFoo will generate setFoo and isFoo methods, not setIsFoo and isIsFoo.
Fixes issue #148
|
|
|
|
|
|
|
|
constructor to be private (as all enum constructors have to be).
Fixes issue #186
|
|
|
|
com/sun/tools/javac/util to com/sun/tools/javac/file
|
|
would fail with a 'duplicate context value' error.
Fixes issue #178
Thanks to Neildo for using the 0.10.0 beta and spotting the problem - the tests don't run 1 delombok with multiple files. Maybe we should change that.
|
|
the methods generated by them.
|
|
printed by EclipseASTVisitor.Printer
|
|
Supported: DummyRound0' error. This fixes it.
Fixes issue #176
|
|
would cause 1 error log entry to show up. No other effects other than that, but thats ugly and so thats been fixed.
|
|
EclipseAST object.
Fixes issue #171
|
|
will still attempt to call this nonexistent getAbc instead of getABC. Fixed.
Fixes issue #173.
|
|
Object as parameter (creating new equals methods by giving them non-object parameterized is a _really_ bad idea, but if someone did do that, obviously lombok shouldn't call those!)
Fixes #165.
|
|
enums. Docs have been updated.
Behaviour of @XArgsConstructor when its placement makes no sense (i.e. when annotating an interface with them) is no longer 'throw weird errors', but has been brought in line with the others: A nice error message is generated.
Fixes issue #175
|
|
nature of the method is preserved).
|
|
|
|
for javac. Of course, this is NOT done in delombok mode.
|
|
lombok.val without breaking 'fix imports'. Eesh. Using "lombok.val" only half-works; auto-complete on the variable doesn't work, but it compiles fine and no errors are reported.
|
|
use the parameter names if the delegated element is a source (vs. class) dependency.
|
|
classes
|
|
source, then the name is copied over. Compared to javac, this means eclipse's @Delegate does NOT use debug symbols, which we'll have to fix later (We checked out how to do it, and it seems virtually impossible).
|
|
|
|
methods.
|