aboutsummaryrefslogtreecommitdiff
path: root/src
AgeCommit message (Collapse)Author
2009-07-02[DOC]Reinier Zwitserloot
2009-07-01Added @SneakyThrows support for javac. W00t.Reinier Zwitserloot
2009-07-01[TRIVIAL]Reinier Zwitserloot
2009-07-01Support for @SneakyThrows in eclipse.Reinier Zwitserloot
2009-07-01Added ability to @Synchronized to explicitly name the lock object.Reinier Zwitserloot
Spruced up @Cleanup's position settings and also forced initialization, because the error appears in a screwed up place if you don't, and we can't seem to move it.
2009-07-01Added @Synchronized support to javac. Seems to work well.Reinier Zwitserloot
2009-07-01Added a bonus feature to @Cleanup: Assigning a @Cleanup marked variable to ↵Reinier Zwitserloot
anything else generates a warning.
2009-07-01@Synchronization support for eclipse! Seems to work fine, just need to write ↵Reinier Zwitserloot
the same thing for javac.
2009-07-01Pretty big fix for reparse() - now uses rebuild(), which also received a ↵Reinier Zwitserloot
pretty big fix in making the loop detection algorithm far more robust. Still not sure what was the problem, but the robustificationization helped.
2009-07-01Added HandleCleanup support for javac, and fixed a bug in AST.java which ↵Reinier Zwitserloot
caused nested @Cleanup annotations to simply be ignored (rebuild was broken). HandleCleanup seems to work swimmingly now on both targets. yay!
2009-06-30After a great many iterations, Cleanup has now been reduced in functionality ↵Reinier Zwitserloot
(exceptions from the cleanup call WILL mask exceptions from the body - this isn't intended, but it's just not possible to fix this without java 7 features or requiring a rewrite of the class file data. Tried tactics, and why they won't work: - Replace every 'return', 'break', and 'continue' statement (for the latter 2, only if they break/continue out of the try block) with a block that first sets a uniquely named flag before doing the operation. Then, check that flag in the finally block to see if the cleanup call should be guarded by a try/catchThrowable. This doesn't work, because its not possible to instrument the 4th way out of a try block without throwing an exception: Just letting it run its course. Tossing a "#flag = true;" at the end may cause a compile time error if the code is not reachable, but figuring that out requires resolution and quite a bit of analysis. - Put catch blocks in for all relevant exceptions (RuntimeException, Error, all exceptions declared as thrown by the method, and all types of exceptions of the catch blocks of encapsulating try blocks. This doesn't work, partly because it'll fail for sneakily thrown exceptions, but mostly because you can't just catch an exception listed in the 'throws' clause of the method body; catching an exception that no statement in the try block can throw is a compile time error, but it is perfectly allright to declare these as 'thrown'. - Put in a blanket catch Throwable to set the flag. Two problems with this: First, sneaky throw can't be done. Thread.stop invokes a security manager and triggers a warning, Calling a sneakyThrow method creates a runtime dependency on lombok, constructing a sneakyThrow in-class creates visible methods or at least visible class files, and creating a new class via Class.loadClass would be very slow without caching - which gets you the same issues. Secondly, this would mean that any statements in the try body that throw an exception aren't flagged to the user as needing to be handled. The Cleanup annotation now also calls the cleanup method for you, and will call it at the END of the current scope. The following plans have been tried and abandoned: - Cleanup right after the final mention. This doesn't work, because the final mention may not be the final use-place. Example: @Cleanup InputStream in = new FileInputStream(someFile); InputStreamReader reader = new InputStreamReader(in); reader.read(); //oops - in is already closed by now. - Require an explicit var.cleanup() call and consider that the cue to close off the try block. This doesn't work either, because now variables set in between the @Cleanup declaration and the var.cleanup() call become invisible to following statements. Example: @Cleanup InputStream in = new FileInputStream(someFile); int i = in.read(); in.close(); System.out.println(i); //fail - i is inside the generated try block but this isn't, so 'i' is not visible from here. By running to the end of visible scope, all these problems are avoided. This does remove the flexibility of declaring where you want a close call to be executed, but there are two mitigating factors available: 1) Create an explicit scope block. You can just stick { code } in any place where you can legally write a statement, in java. This is relatively unknown, so I expect most users will go for: 2) Just call close explicitly. I've yet to see a cleanup method which isn't idempotent anyway (calling it multiple times is no different than calling it once). During the course of investigating these options, the AST code has been extended to support live replacement of any child node, including updating the actual underlying system AST as well as our own. Unfortunately, this code has NOT been tested. It was rather a lot of work so I'm leaving it in, and at least for eclipse it even seemed to work.
2009-06-28Preparating for java 1.5-ification. All stuff that isn't specific to javac ↵Reinier Zwitserloot
should run in java 1.5, so that an eclipse started on a 1.5 JVM will still run lombok.
2009-06-28Rolled our own ServiceLoader, because its not part of java 1.5.Reinier Zwitserloot
2009-06-28AptProblem is not available when eclipse is run on java 1.5, and AptProblem ↵Reinier Zwitserloot
is not neccessarily the proper target anyway. Rolled our own DefaultProblem subclass for problem reporting.
2009-06-28Added rebuild support to AST.Node.Reinier Zwitserloot
2009-06-27[IMPROVEMENT]Reinier Zwitserloot
Eclipse will now also hold off on running @PrintAST handlers until the very end. Simple generators such as @Getter didn't need this, because PrintAST's handler will hold off until eclipse does a full parse, but when changing the innards of methods, you would likely not see what you did. Fixed that. Also, PrintAST has an option to, instead of diving into the ASTNodes of bodies (methods, initializers, etc), to just render the java code, to see if the AST creation/rewriting you've been doing looks like the java code you intended.
2009-06-27[BUGFIX] Pretty major bug - due to a typo, ALL values for annotation methods ↵Reinier Zwitserloot
were set to the value of the last annotation method. e.g in: @Foo(bar=10), ALL methods in the Foo annotation were presumed to be listed, and set to 10. This was obviously causing problems. Fixed it.
2009-06-27[BUGFIX] For some reason, JCLiteral objects contain '1' or '0' (integers) ↵Reinier Zwitserloot
for booleans, not actual booleans. You can tell the difference via the getKind() method. hence, boolean fields in annotations were throwing unexpected type errors (Integer instead of Boolean). Fixed this.
2009-06-27[TRIVIAL] Added a toString to AnnotationValue, used to debug something, but ↵Reinier Zwitserloot
useful enough to leave in there.
2009-06-27Whoops - there was some debug printing left in eclipse's HandleGetterReinier Zwitserloot
2009-06-27Added a caching mechanism to AnnotationValues, for instantiating the annotation.Reinier Zwitserloot
2009-06-26Cleanup implemented for eclipse!Reinier Zwitserloot
There's one serious problem though: The cleanup routine modifies the eclipse internal AST, but doesn't update our bi-directional AST. Thus, or example, having a @Cleanup annotation inside the scope of another @Cleanup fails, because the application of the second one climbs up to the wrong block level (the original block level instead of newly built try block).
2009-06-25Bumped version from 0.3.0 to 0.3.5 in celebration of finishing all 3 ↵Reinier Zwitserloot
generating annotations for both javac and eclipse (@Getter, @Setter, and @Data).
2009-06-25Added support for generating toString to javac's HandleData. Now javac's ↵Reinier Zwitserloot
HandleData is COMPLETE! w00t!
2009-06-25Added generating hashCode() to javac's HandleData.Reinier Zwitserloot
2009-06-25trivialReinier Zwitserloot
2009-06-25javac's HandleData now makes equals methods.Reinier Zwitserloot
2009-06-25Removed adding the statement: 'final int PRIME = 31;' in the HandleData's ↵Reinier Zwitserloot
createHashCode method when there are 0 fields in the type (it would generate a local variable never used warning!)
2009-06-25Heh, on errors you'd never actually see any message, just the exception ↵Reinier Zwitserloot
type. Whoops.
2009-06-24javac's HandleData now generates the constructor only if it doesn't already ↵Reinier Zwitserloot
exist, and the staticConstructor is now also completed. Left: toString, hashCode, equals.
2009-06-24Work on HandleData, as well as generalizing features in the the PKG class ↵Reinier Zwitserloot
and updating HandleGetter/Setter to call into it.
2009-06-24Added printing for a constructor if it is the default (generated) ↵Reinier Zwitserloot
constructor or not.
2009-06-24Added proper support for changing the AST as its being visited, both removal ↵Reinier Zwitserloot
and addition. The rule is now: children traversal traverses through the tree mostly as it was when it started.
2009-06-23fixed a bug where the auto-generated constructors (actual or static) would ↵Reinier Zwitserloot
throw eclipse errors if you had 0 non-static fields.
2009-06-23HandleData for eclipse now seems to work 100%. Also updated toString to use ↵Reinier Zwitserloot
deepToString, and added @Override in case people have warnings for missing @Override annotations on.
2009-06-23@Data's generation of the equals() method now works!Reinier Zwitserloot
2009-06-23Fixed some bugs in copyType(), and now the static constructor is generated ↵Reinier Zwitserloot
without any raw generics warnings - it is effectively done.
2009-06-23Figured out that our previous act of just assigning TypeReference objects ↵Reinier Zwitserloot
directly to other nodes (e.g. from a FieldDeclaration's type to a method argument) is NOT a good idea, as this screws up when the TypeReference object represents a generic type (like 'T') - each instance of a generic type has a different resolution, but 1 TypeReference object can only hold 1 resolution. Thus, a copyType() method has been written, and the Handle* classes have been updated to use it. Also, generateEquals() is half-finished in HandleData.
2009-06-23This is a 3-day bughunt that ended up being something extremely simple:Reinier Zwitserloot
** DO NOT REUSE TYPEREFERENCE OBJECTS ** because that makes the binding process go pearshaped - after hte first run, that TypeReference object's binding parameter is set, and as its set, the resolver won't bother re-resolving it. However, each parse run starts with new scope objects, and any 2 bindings created by different scopes aren't equal to each other. urrrrrrgh! Fortunately, a lot of code that 'fixed' methods by adding bindings and scope have all been removed, as the parser patch point is well before these bindings are created. Thus: ** NEVER CREATE YOUR OWN BINDINGS AND SCOPE OBJECTS ** because if it comes down to that, you're doing it entirely wrong. That's eclipse's job. We're patching where we are so you don't have to do this.
2009-06-23Put the actual numeric value of ASTNode.Bit24 in a comment, but it was ↵Reinier Zwitserloot
missing a 0!
2009-06-23Removed the equalsPrime thing, because that's just needlessly putting ↵Reinier Zwitserloot
implementation details in there. If switching primes is so important, hash the type name and turn that into a prime, or something. Also added some javadoc.
2009-06-21More work on the HandleData annotation. Constructor seems to work fine, ↵Reinier Zwitserloot
static constructor not so much.
2009-06-21trivialReinier Zwitserloot
2009-06-21Bug fix: using string literals in any lombok annotation value would blow up ↵Reinier Zwitserloot
that processor.
2009-06-21Due to a java bug, constants in enums don't work, so instead the default ↵Reinier Zwitserloot
access level for @Getter and @Setter have now just been hardcoded in GetterHandler and SetterHandler. Added ability to look up the Node object for any given AST object on Node itself, as you don't usually have the AST object. Added toString() method generating to @Data, and this required some fancy footwork in finding if we've already generated methods, and editing a generated method to fill in binding and type resolutions. HandleGetter and HandleSetter have been updated to use these features. Exceptions caused by lombok handlers show up in the eclipse error log, but now, if they are related to a CompilationUnit, also as a problem (error) on the CUD - those error log entries are easy to miss! Our ASTs can now be appended to. When you generate a new AST node, you should add it to the AST, obviously. Getter/Setter have been updated to use this.
2009-06-19Added initial support for the @Data annotation. Currently produces getters ↵Reinier Zwitserloot
and setters only, not yet a constructor, toString, hashCode, or equals. HandleGetter and HandleSetter have been updated to handle static (theoretic; you can't put annotations on static fields normally). You can now make AnnotationValue objects using just an annotationNode and a target type, as well as check if a given annotationNode is likely to represent a target annotation type. This is in Javac and Eclipse classes. HandleGetter and HandleSetter can now be asked to make a getter/setter, and will grab access level off of a Getter/Setter annotation, if present.
2009-06-18Created a fully working HandleSetter for eclipse, and refactored ↵Reinier Zwitserloot
HandleGetter a little mostly to stuff common code into PKG.
2009-06-18Expanded the AST printers to support a target PrintStream, and expanded the ↵Reinier Zwitserloot
@PrintAST annotation to let you supply an optional filename. Useful particularly for IDEs, which don't usually have a viewable console. Also renamed the printers to just 'Printer', as they are already inner classes of a specifically named type (JavacASTVisitor & co).
2009-06-17AnnotationHandlers can now return a boolean to set if they actually handled ↵Reinier Zwitserloot
the annotation or not (previously, the presumption was they always handled the annotation). This is very useful for PrintAST on eclipse, because before this change, you'd never see method contents (as the initial dietParse would come first). Now Eclipse PrintASTHandler will skip any non-full runs, and only print non-diet. It then returns true only if it printed.
2009-06-17Added 'does setX/getX already exist' check to javac's HandleGetter/Setter. ↵Reinier Zwitserloot
If they exist (with any returntype/paramlist), no getter/setter is generated, and instead a warning is added on the annotation.