From 3400f66fa70da6664e91d98cc63d8ea959979606 Mon Sep 17 00:00:00 2001 From: Reinier Zwitserloot Date: Mon, 22 Mar 2021 11:38:56 +0100 Subject: [deps] pushing ASM to 9.1, and ASM opcode compat levels to ASM9, as we need the support for records --- .../ivy-repo/org.projectlombok-lombok.patcher-0.36.xml | 14 -------------- .../ivy-repo/org.projectlombok-lombok.patcher-0.38.xml | 14 -------------- .../ivy-repo/org.projectlombok-lombok.patcher-0.42.xml | 14 ++++++++++++++ buildScripts/ivy.xml | 2 +- src/core/lombok/bytecode/AsmUtil.java | 4 ++-- src/core/lombok/bytecode/PreventNullAnalysisRemover.java | 4 ++-- src/core/lombok/bytecode/SneakyThrowsRemover.java | 4 ++-- .../resource/after-delombok/BuilderSimpleOnRecord.java | 14 +++++++------- .../resource/after-delombok/BuilderSingularOnRecord.java | 15 +-------------- .../resource/after-delombok/ConstructorsOnRecord.java | 1 + test/transform/resource/after-delombok/DataOnRecord.java | 1 + .../after-delombok/EqualsAndHashCodeOnRecord.java | 1 + .../resource/after-delombok/FieldDefaultsOnRecord.java | 1 + .../after-delombok/FieldNameConstantsOnRecord.java | 2 +- .../transform/resource/after-delombok/GetterOnRecord.java | 1 + .../resource/after-delombok/LoggerConfigOnRecord.java | 1 + .../after-delombok/LoggerSlf4jNonStaticOnRecord.java | 1 + .../resource/after-delombok/LoggerSlf4jOnRecord.java | 2 ++ .../NonNullExistingConstructorOnRecord.java | 3 +-- .../resource/after-delombok/NonNullOnRecord.java | 3 +-- .../transform/resource/after-delombok/SetterOnRecord.java | 1 + .../resource/after-delombok/ToStringOnRecord.java | 1 + .../resource/after-delombok/UtilityClassOnRecord.java | 1 + test/transform/resource/after-delombok/ValueOnRecord.java | 1 + .../transform/resource/after-delombok/WithByOnRecord.java | 2 +- .../resource/after-delombok/WithByOnRecordComponent.java | 1 + test/transform/resource/after-delombok/WithOnRecord.java | 8 +++++++- .../resource/after-delombok/WithOnRecordComponent.java | 4 ++++ .../resource/after-ecj/BuilderSimpleOnRecord.java | 1 + .../resource/after-ecj/BuilderSingularOnRecord.java | 1 + .../resource/after-ecj/ConstructorsOnRecord.java | 1 + test/transform/resource/after-ecj/DataOnRecord.java | 1 + .../resource/after-ecj/EqualsAndHashCodeOnRecord.java | 1 + .../resource/after-ecj/FieldDefaultsOnRecord.java | 1 + .../resource/after-ecj/FieldNameConstantsOnRecord.java | 1 + test/transform/resource/after-ecj/GetterOnRecord.java | 1 + .../resource/after-ecj/LoggerConfigOnRecord.java | 1 + .../transform/resource/after-ecj/LoggerSlf4jOnRecord.java | 1 + .../after-ecj/NonNullExistingConstructorOnRecord.java | 1 + test/transform/resource/after-ecj/NonNullOnRecord.java | 1 + test/transform/resource/after-ecj/SetterOnRecord.java | 1 + test/transform/resource/after-ecj/ToStringOnRecord.java | 1 + .../resource/after-ecj/UtilityClassOnRecord.java | 1 + test/transform/resource/after-ecj/ValueOnRecord.java | 1 + test/transform/resource/after-ecj/WithByOnRecord.java | 1 + .../resource/after-ecj/WithByOnRecordComponent.java | 1 + test/transform/resource/after-ecj/WithOnRecord.java | 1 + .../resource/after-ecj/WithOnRecordComponent.java | 1 + test/transform/resource/before/SuperBuilderOnRecord.java | 2 +- .../messages-delombok/SuperBuilderOnRecord.java.messages | 2 +- .../messages-delombok/UtilityClassOnRecord.java.messages | 2 +- .../messages-ecj/SuperBuilderOnRecord.java.messages | 2 +- .../messages-ecj/UtilityClassOnRecord.java.messages | 2 +- 53 files changed, 83 insertions(+), 68 deletions(-) delete mode 100644 buildScripts/ivy-repo/org.projectlombok-lombok.patcher-0.36.xml delete mode 100644 buildScripts/ivy-repo/org.projectlombok-lombok.patcher-0.38.xml create mode 100644 buildScripts/ivy-repo/org.projectlombok-lombok.patcher-0.42.xml diff --git a/buildScripts/ivy-repo/org.projectlombok-lombok.patcher-0.36.xml b/buildScripts/ivy-repo/org.projectlombok-lombok.patcher-0.36.xml deleted file mode 100644 index b75b111d..00000000 --- a/buildScripts/ivy-repo/org.projectlombok-lombok.patcher-0.36.xml +++ /dev/null @@ -1,14 +0,0 @@ - - - - - - - - - - - - - - diff --git a/buildScripts/ivy-repo/org.projectlombok-lombok.patcher-0.38.xml b/buildScripts/ivy-repo/org.projectlombok-lombok.patcher-0.38.xml deleted file mode 100644 index 1ca9c743..00000000 --- a/buildScripts/ivy-repo/org.projectlombok-lombok.patcher-0.38.xml +++ /dev/null @@ -1,14 +0,0 @@ - - - - - - - - - - - - - - diff --git a/buildScripts/ivy-repo/org.projectlombok-lombok.patcher-0.42.xml b/buildScripts/ivy-repo/org.projectlombok-lombok.patcher-0.42.xml new file mode 100644 index 00000000..c64d09df --- /dev/null +++ b/buildScripts/ivy-repo/org.projectlombok-lombok.patcher-0.42.xml @@ -0,0 +1,14 @@ + + + + + + + + + + + + + + diff --git a/buildScripts/ivy.xml b/buildScripts/ivy.xml index 12dd2c5b..da46ab91 100644 --- a/buildScripts/ivy.xml +++ b/buildScripts/ivy.xml @@ -36,7 +36,7 @@ - + diff --git a/src/core/lombok/bytecode/AsmUtil.java b/src/core/lombok/bytecode/AsmUtil.java index 42bf9700..fc2533e5 100644 --- a/src/core/lombok/bytecode/AsmUtil.java +++ b/src/core/lombok/bytecode/AsmUtil.java @@ -1,5 +1,5 @@ /* - * Copyright (C) 2010-2014 The Project Lombok Authors. + * Copyright (C) 2010-2021 The Project Lombok Authors. * * Permission is hereby granted, free of charge, to any person obtaining a copy * of this software and associated documentation files (the "Software"), to deal @@ -37,7 +37,7 @@ class AsmUtil { ClassReader reader = new ClassReader(byteCode); ClassWriter writer = new FixedClassWriter(reader, 0); - ClassVisitor visitor = new ClassVisitor(Opcodes.ASM7, writer) { + ClassVisitor visitor = new ClassVisitor(Opcodes.ASM9, writer) { @Override public MethodVisitor visitMethod(int access, String name, String desc, String signature, String[] exceptions) { return new JSRInlinerAdapter(super.visitMethod(access, name, desc, signature, exceptions), access, name, desc, signature, exceptions); } diff --git a/src/core/lombok/bytecode/PreventNullAnalysisRemover.java b/src/core/lombok/bytecode/PreventNullAnalysisRemover.java index 14e95c46..8ae7af5b 100644 --- a/src/core/lombok/bytecode/PreventNullAnalysisRemover.java +++ b/src/core/lombok/bytecode/PreventNullAnalysisRemover.java @@ -50,7 +50,7 @@ public class PreventNullAnalysisRemover implements PostCompilerTransformation { class PreventNullAnalysisVisitor extends MethodVisitor { PreventNullAnalysisVisitor(MethodVisitor mv) { - super(Opcodes.ASM7, mv); + super(Opcodes.ASM9, mv); } @Override public void visitMethodInsn(int opcode, String owner, String name, String desc, boolean itf) { @@ -68,7 +68,7 @@ public class PreventNullAnalysisRemover implements PostCompilerTransformation { } } - reader.accept(new ClassVisitor(Opcodes.ASM7, writer) { + reader.accept(new ClassVisitor(Opcodes.ASM9, writer) { @Override public MethodVisitor visitMethod(int access, String name, String desc, String signature, String[] exceptions) { return new PreventNullAnalysisVisitor(super.visitMethod(access, name, desc, signature, exceptions)); } diff --git a/src/core/lombok/bytecode/SneakyThrowsRemover.java b/src/core/lombok/bytecode/SneakyThrowsRemover.java index 7ed3f80f..ea1c3cec 100644 --- a/src/core/lombok/bytecode/SneakyThrowsRemover.java +++ b/src/core/lombok/bytecode/SneakyThrowsRemover.java @@ -52,7 +52,7 @@ public class SneakyThrowsRemover implements PostCompilerTransformation { class SneakyThrowsRemoverVisitor extends MethodVisitor { SneakyThrowsRemoverVisitor(MethodVisitor mv) { - super(Opcodes.ASM7, mv); + super(Opcodes.ASM9, mv); } private boolean methodInsnQueued = false; @@ -177,7 +177,7 @@ public class SneakyThrowsRemover implements PostCompilerTransformation { } } - reader.accept(new ClassVisitor(Opcodes.ASM7, writer) { + reader.accept(new ClassVisitor(Opcodes.ASM9, writer) { @Override public MethodVisitor visitMethod(int access, String name, String desc, String signature, String[] exceptions) { return new SneakyThrowsRemoverVisitor(super.visitMethod(access, name, desc, signature, exceptions)); } diff --git a/test/transform/resource/after-delombok/BuilderSimpleOnRecord.java b/test/transform/resource/after-delombok/BuilderSimpleOnRecord.java index 03aca3aa..aa35cf23 100644 --- a/test/transform/resource/after-delombok/BuilderSimpleOnRecord.java +++ b/test/transform/resource/after-delombok/BuilderSimpleOnRecord.java @@ -1,5 +1,5 @@ +// version 14: import java.util.List; - record BuilderSimpleOnRecord(List l, String a) { @java.lang.SuppressWarnings("all") protected static class BuilderSimpleOnRecordBuilder { @@ -7,35 +7,35 @@ record BuilderSimpleOnRecord(List l, String a) { private List l; @java.lang.SuppressWarnings("all") private String a; - @java.lang.SuppressWarnings("all") BuilderSimpleOnRecordBuilder() { } - + /** + * @return {@code this}. + */ @java.lang.SuppressWarnings("all") public BuilderSimpleOnRecord.BuilderSimpleOnRecordBuilder l(final List l) { this.l = l; return this; } - + /** + * @return {@code this}. + */ @java.lang.SuppressWarnings("all") public BuilderSimpleOnRecord.BuilderSimpleOnRecordBuilder a(final String a) { this.a = a; return this; } - @java.lang.SuppressWarnings("all") public BuilderSimpleOnRecord build() { return new BuilderSimpleOnRecord(this.l, this.a); } - @java.lang.Override @java.lang.SuppressWarnings("all") public java.lang.String toString() { return "BuilderSimpleOnRecord.BuilderSimpleOnRecordBuilder(l=" + this.l + ", a=" + this.a + ")"; } } - @java.lang.SuppressWarnings("all") protected static BuilderSimpleOnRecord.BuilderSimpleOnRecordBuilder builder() { return new BuilderSimpleOnRecord.BuilderSimpleOnRecordBuilder(); diff --git a/test/transform/resource/after-delombok/BuilderSingularOnRecord.java b/test/transform/resource/after-delombok/BuilderSingularOnRecord.java index 32b37865..41a976cd 100644 --- a/test/transform/resource/after-delombok/BuilderSingularOnRecord.java +++ b/test/transform/resource/after-delombok/BuilderSingularOnRecord.java @@ -1,6 +1,6 @@ +// version 14: import java.util.Collection; import java.util.List; - record BuilderSingularOnRecord(List children, Collection scarves, @SuppressWarnings("all") List rawList) { @java.lang.SuppressWarnings("all") public static class BuilderSingularOnRecordBuilder { @@ -10,18 +10,15 @@ record BuilderSingularOnRecord(List children, Collection private java.util.ArrayList scarves; @java.lang.SuppressWarnings("all") private java.util.ArrayList rawList; - @java.lang.SuppressWarnings("all") BuilderSingularOnRecordBuilder() { } - @java.lang.SuppressWarnings("all") public BuilderSingularOnRecord.BuilderSingularOnRecordBuilder child(final T child) { if (this.children == null) this.children = new java.util.ArrayList(); this.children.add(child); return this; } - @java.lang.SuppressWarnings("all") public BuilderSingularOnRecord.BuilderSingularOnRecordBuilder children(final java.util.Collection children) { if (children == null) { @@ -31,20 +28,17 @@ record BuilderSingularOnRecord(List children, Collection this.children.addAll(children); return this; } - @java.lang.SuppressWarnings("all") public BuilderSingularOnRecord.BuilderSingularOnRecordBuilder clearChildren() { if (this.children != null) this.children.clear(); return this; } - @java.lang.SuppressWarnings("all") public BuilderSingularOnRecord.BuilderSingularOnRecordBuilder scarf(final Number scarf) { if (this.scarves == null) this.scarves = new java.util.ArrayList(); this.scarves.add(scarf); return this; } - @java.lang.SuppressWarnings("all") public BuilderSingularOnRecord.BuilderSingularOnRecordBuilder scarves(final java.util.Collection scarves) { if (scarves == null) { @@ -54,20 +48,17 @@ record BuilderSingularOnRecord(List children, Collection this.scarves.addAll(scarves); return this; } - @java.lang.SuppressWarnings("all") public BuilderSingularOnRecord.BuilderSingularOnRecordBuilder clearScarves() { if (this.scarves != null) this.scarves.clear(); return this; } - @java.lang.SuppressWarnings("all") public BuilderSingularOnRecord.BuilderSingularOnRecordBuilder rawList(final java.lang.Object rawList) { if (this.rawList == null) this.rawList = new java.util.ArrayList(); this.rawList.add(rawList); return this; } - @java.lang.SuppressWarnings("all") public BuilderSingularOnRecord.BuilderSingularOnRecordBuilder rawList(final java.util.Collection rawList) { if (rawList == null) { @@ -77,13 +68,11 @@ record BuilderSingularOnRecord(List children, Collection this.rawList.addAll(rawList); return this; } - @java.lang.SuppressWarnings("all") public BuilderSingularOnRecord.BuilderSingularOnRecordBuilder clearRawList() { if (this.rawList != null) this.rawList.clear(); return this; } - @java.lang.SuppressWarnings("all") public BuilderSingularOnRecord build() { java.util.List children; @@ -121,14 +110,12 @@ record BuilderSingularOnRecord(List children, Collection } return new BuilderSingularOnRecord(children, scarves, rawList); } - @java.lang.Override @java.lang.SuppressWarnings("all") public java.lang.String toString() { return "BuilderSingularOnRecord.BuilderSingularOnRecordBuilder(children=" + this.children + ", scarves=" + this.scarves + ", rawList=" + this.rawList + ")"; } } - @java.lang.SuppressWarnings("all") public static BuilderSingularOnRecord.BuilderSingularOnRecordBuilder builder() { return new BuilderSingularOnRecord.BuilderSingularOnRecordBuilder(); diff --git a/test/transform/resource/after-delombok/ConstructorsOnRecord.java b/test/transform/resource/after-delombok/ConstructorsOnRecord.java index 8cef8809..3d091bd5 100644 --- a/test/transform/resource/after-delombok/ConstructorsOnRecord.java +++ b/test/transform/resource/after-delombok/ConstructorsOnRecord.java @@ -1,2 +1,3 @@ +// version 14: record ConstructorsOnRecord(String a, String b) { } diff --git a/test/transform/resource/after-delombok/DataOnRecord.java b/test/transform/resource/after-delombok/DataOnRecord.java index b4384dce..7fde94f9 100644 --- a/test/transform/resource/after-delombok/DataOnRecord.java +++ b/test/transform/resource/after-delombok/DataOnRecord.java @@ -1,2 +1,3 @@ +// version 14: record DataOnRecord(String a, String b) { } diff --git a/test/transform/resource/after-delombok/EqualsAndHashCodeOnRecord.java b/test/transform/resource/after-delombok/EqualsAndHashCodeOnRecord.java index 949cdec6..93213d80 100644 --- a/test/transform/resource/after-delombok/EqualsAndHashCodeOnRecord.java +++ b/test/transform/resource/after-delombok/EqualsAndHashCodeOnRecord.java @@ -1,2 +1,3 @@ +// version 14: record EqualsAndHashCodeOnRecord(String a, String b) { } diff --git a/test/transform/resource/after-delombok/FieldDefaultsOnRecord.java b/test/transform/resource/after-delombok/FieldDefaultsOnRecord.java index 1287dcb0..a7b37d9f 100644 --- a/test/transform/resource/after-delombok/FieldDefaultsOnRecord.java +++ b/test/transform/resource/after-delombok/FieldDefaultsOnRecord.java @@ -1,2 +1,3 @@ +// version 14: record FieldDefaultsOnRecord(String a, String b) { } diff --git a/test/transform/resource/after-delombok/FieldNameConstantsOnRecord.java b/test/transform/resource/after-delombok/FieldNameConstantsOnRecord.java index 2e3339fa..8f29cc96 100644 --- a/test/transform/resource/after-delombok/FieldNameConstantsOnRecord.java +++ b/test/transform/resource/after-delombok/FieldNameConstantsOnRecord.java @@ -1,6 +1,6 @@ +// version 14: record FieldNameConstantsOnRecord(String iAmADvdPlayer, int $skipMe, int andMe, String butPrintMePlease) { static double skipMeToo; - @java.lang.SuppressWarnings("all") static final class Fields { public static final java.lang.String iAmADvdPlayer = "iAmADvdPlayer"; diff --git a/test/transform/resource/after-delombok/GetterOnRecord.java b/test/transform/resource/after-delombok/GetterOnRecord.java index 5090e92d..5b7c5058 100644 --- a/test/transform/resource/after-delombok/GetterOnRecord.java +++ b/test/transform/resource/after-delombok/GetterOnRecord.java @@ -1,2 +1,3 @@ +// version 14: record GetterOnRecord(String a, String b) { } diff --git a/test/transform/resource/after-delombok/LoggerConfigOnRecord.java b/test/transform/resource/after-delombok/LoggerConfigOnRecord.java index 5b43f24e..2ef0bffd 100644 --- a/test/transform/resource/after-delombok/LoggerConfigOnRecord.java +++ b/test/transform/resource/after-delombok/LoggerConfigOnRecord.java @@ -1,2 +1,3 @@ +// version 14: record LoggerConfigOnRecord(String a, String b) { } diff --git a/test/transform/resource/after-delombok/LoggerSlf4jNonStaticOnRecord.java b/test/transform/resource/after-delombok/LoggerSlf4jNonStaticOnRecord.java index e59ed6d3..801c9990 100644 --- a/test/transform/resource/after-delombok/LoggerSlf4jNonStaticOnRecord.java +++ b/test/transform/resource/after-delombok/LoggerSlf4jNonStaticOnRecord.java @@ -1,3 +1,4 @@ +// version 14: record LoggerSlf4jOnRecord(String a, String b) { private static final org.slf4j.Logger log = org.slf4j.LoggerFactory.getLogger(LoggerSlf4jOnRecord.class); } diff --git a/test/transform/resource/after-delombok/LoggerSlf4jOnRecord.java b/test/transform/resource/after-delombok/LoggerSlf4jOnRecord.java index e59ed6d3..caa2ce2c 100644 --- a/test/transform/resource/after-delombok/LoggerSlf4jOnRecord.java +++ b/test/transform/resource/after-delombok/LoggerSlf4jOnRecord.java @@ -1,3 +1,5 @@ +// version 16: the SuppressWarnings is not emitted in java14/15 to work around a javac bug. record LoggerSlf4jOnRecord(String a, String b) { + @java.lang.SuppressWarnings("all") private static final org.slf4j.Logger log = org.slf4j.LoggerFactory.getLogger(LoggerSlf4jOnRecord.class); } diff --git a/test/transform/resource/after-delombok/NonNullExistingConstructorOnRecord.java b/test/transform/resource/after-delombok/NonNullExistingConstructorOnRecord.java index de2757ee..02b66dd1 100644 --- a/test/transform/resource/after-delombok/NonNullExistingConstructorOnRecord.java +++ b/test/transform/resource/after-delombok/NonNullExistingConstructorOnRecord.java @@ -1,5 +1,5 @@ +// version 14: import lombok.NonNull; - record NonNullOnRecord(@NonNull String a, @NonNull String b) { public NonNullOnRecord(@NonNull String b) { this("default", b); @@ -7,7 +7,6 @@ record NonNullOnRecord(@NonNull String a, @NonNull String b) { throw new java.lang.NullPointerException("b is marked non-null but is null"); } } - @java.lang.SuppressWarnings("all") public NonNullOnRecord(@NonNull final String a, @NonNull final String b) { if (a == null) { diff --git a/test/transform/resource/after-delombok/NonNullOnRecord.java b/test/transform/resource/after-delombok/NonNullOnRecord.java index 7147f49c..2ff4a8f7 100644 --- a/test/transform/resource/after-delombok/NonNullOnRecord.java +++ b/test/transform/resource/after-delombok/NonNullOnRecord.java @@ -1,5 +1,5 @@ +// version 14: import lombok.NonNull; - record NonNullOnRecord(@NonNull String a, @NonNull String b) { public void method(@NonNull String param) { if (param == null) { @@ -7,7 +7,6 @@ record NonNullOnRecord(@NonNull String a, @NonNull String b) { } String asd = "a"; } - @java.lang.SuppressWarnings("all") public NonNullOnRecord(@NonNull final String a, @NonNull final String b) { if (a == null) { diff --git a/test/transform/resource/after-delombok/SetterOnRecord.java b/test/transform/resource/after-delombok/SetterOnRecord.java index 39a911ca..31665588 100644 --- a/test/transform/resource/after-delombok/SetterOnRecord.java +++ b/test/transform/resource/after-delombok/SetterOnRecord.java @@ -1,2 +1,3 @@ +// version 14: record SetterOnRecord(String a, String b) { } diff --git a/test/transform/resource/after-delombok/ToStringOnRecord.java b/test/transform/resource/after-delombok/ToStringOnRecord.java index 84db33be..f18508d7 100644 --- a/test/transform/resource/after-delombok/ToStringOnRecord.java +++ b/test/transform/resource/after-delombok/ToStringOnRecord.java @@ -1,2 +1,3 @@ +// version 14: record ToStringOnRecord(String a, String b) { } diff --git a/test/transform/resource/after-delombok/UtilityClassOnRecord.java b/test/transform/resource/after-delombok/UtilityClassOnRecord.java index fbe27370..c6ee509a 100644 --- a/test/transform/resource/after-delombok/UtilityClassOnRecord.java +++ b/test/transform/resource/after-delombok/UtilityClassOnRecord.java @@ -1,2 +1,3 @@ +// version 14: record UtilityClassOnRecord(String a, String b) { } diff --git a/test/transform/resource/after-delombok/ValueOnRecord.java b/test/transform/resource/after-delombok/ValueOnRecord.java index d3d0e6db..4f845c20 100644 --- a/test/transform/resource/after-delombok/ValueOnRecord.java +++ b/test/transform/resource/after-delombok/ValueOnRecord.java @@ -1,2 +1,3 @@ +// version 14: record ValueOnRecord(String a, String b) { } diff --git a/test/transform/resource/after-delombok/WithByOnRecord.java b/test/transform/resource/after-delombok/WithByOnRecord.java index d6a24a9a..6df5c9c4 100644 --- a/test/transform/resource/after-delombok/WithByOnRecord.java +++ b/test/transform/resource/after-delombok/WithByOnRecord.java @@ -1,9 +1,9 @@ +// version 14: record WithByOnRecord(String a, String b) { @java.lang.SuppressWarnings("all") public WithByOnRecord withABy(final java.util.function.Function transformer) { return new WithByOnRecord(transformer.apply(this.a), this.b); } - @java.lang.SuppressWarnings("all") public WithByOnRecord withBBy(final java.util.function.Function transformer) { return new WithByOnRecord(this.a, transformer.apply(this.b)); diff --git a/test/transform/resource/after-delombok/WithByOnRecordComponent.java b/test/transform/resource/after-delombok/WithByOnRecordComponent.java index 5af50625..91dd7b38 100644 --- a/test/transform/resource/after-delombok/WithByOnRecordComponent.java +++ b/test/transform/resource/after-delombok/WithByOnRecordComponent.java @@ -1,3 +1,4 @@ +// version 14: record WithByOnRecordComponent(String a, String b) { @java.lang.SuppressWarnings("all") public WithByOnRecordComponent withABy(final java.util.function.Function transformer) { diff --git a/test/transform/resource/after-delombok/WithOnRecord.java b/test/transform/resource/after-delombok/WithOnRecord.java index bfb123bc..e981cc20 100644 --- a/test/transform/resource/after-delombok/WithOnRecord.java +++ b/test/transform/resource/after-delombok/WithOnRecord.java @@ -1,9 +1,15 @@ +// version 14: record WithOnRecord(String a, String b) { + /** + * @return a clone of this object, except with this updated property (returns {@code this} if an identical value is passed). + */ @java.lang.SuppressWarnings("all") public WithOnRecord withA(final String a) { return this.a == a ? this : new WithOnRecord(a, this.b); } - + /** + * @return a clone of this object, except with this updated property (returns {@code this} if an identical value is passed). + */ @java.lang.SuppressWarnings("all") public WithOnRecord withB(final String b) { return this.b == b ? this : new WithOnRecord(this.a, b); diff --git a/test/transform/resource/after-delombok/WithOnRecordComponent.java b/test/transform/resource/after-delombok/WithOnRecordComponent.java index a5f4ec36..5bc72f34 100644 --- a/test/transform/resource/after-delombok/WithOnRecordComponent.java +++ b/test/transform/resource/after-delombok/WithOnRecordComponent.java @@ -1,4 +1,8 @@ +// version 14: record WithOnRecordComponent(String a, String b) { + /** + * @return a clone of this object, except with this updated property (returns {@code this} if an identical value is passed). + */ @java.lang.SuppressWarnings("all") public WithOnRecordComponent withA(final String a) { return this.a == a ? this : new WithOnRecordComponent(a, this.b); diff --git a/test/transform/resource/after-ecj/BuilderSimpleOnRecord.java b/test/transform/resource/after-ecj/BuilderSimpleOnRecord.java index e73ed92e..f7e3fff1 100644 --- a/test/transform/resource/after-ecj/BuilderSimpleOnRecord.java +++ b/test/transform/resource/after-ecj/BuilderSimpleOnRecord.java @@ -1,3 +1,4 @@ +// version 14: import java.util.List; @lombok.Builder(access = lombok.AccessLevel.PROTECTED) record BuilderSimpleOnRecord(List l, String a) { protected static @java.lang.SuppressWarnings("all") class BuilderSimpleOnRecordBuilder { diff --git a/test/transform/resource/after-ecj/BuilderSingularOnRecord.java b/test/transform/resource/after-ecj/BuilderSingularOnRecord.java index b1d9cf39..3d16d326 100644 --- a/test/transform/resource/after-ecj/BuilderSingularOnRecord.java +++ b/test/transform/resource/after-ecj/BuilderSingularOnRecord.java @@ -1,3 +1,4 @@ +// version 14: import java.util.Collection; import java.util.List; import lombok.Builder; diff --git a/test/transform/resource/after-ecj/ConstructorsOnRecord.java b/test/transform/resource/after-ecj/ConstructorsOnRecord.java index bfd9618f..ce01737c 100644 --- a/test/transform/resource/after-ecj/ConstructorsOnRecord.java +++ b/test/transform/resource/after-ecj/ConstructorsOnRecord.java @@ -1,3 +1,4 @@ +// version 14: import lombok.AllArgsConstructor; import lombok.NoArgsConstructor; import lombok.RequiredArgsConstructor; diff --git a/test/transform/resource/after-ecj/DataOnRecord.java b/test/transform/resource/after-ecj/DataOnRecord.java index 48783330..c9bd19f0 100644 --- a/test/transform/resource/after-ecj/DataOnRecord.java +++ b/test/transform/resource/after-ecj/DataOnRecord.java @@ -1,3 +1,4 @@ +// version 14: import lombok.Data; @Data record DataOnRecord(String a, String b) { /* Implicit */ private final String a; diff --git a/test/transform/resource/after-ecj/EqualsAndHashCodeOnRecord.java b/test/transform/resource/after-ecj/EqualsAndHashCodeOnRecord.java index 60285186..043f1233 100644 --- a/test/transform/resource/after-ecj/EqualsAndHashCodeOnRecord.java +++ b/test/transform/resource/after-ecj/EqualsAndHashCodeOnRecord.java @@ -1,3 +1,4 @@ +// version 14: import lombok.EqualsAndHashCode; @EqualsAndHashCode record EqualsAndHashCodeOnRecord(String a, String b) { /* Implicit */ private final String a; diff --git a/test/transform/resource/after-ecj/FieldDefaultsOnRecord.java b/test/transform/resource/after-ecj/FieldDefaultsOnRecord.java index 95c49a42..54795ef6 100644 --- a/test/transform/resource/after-ecj/FieldDefaultsOnRecord.java +++ b/test/transform/resource/after-ecj/FieldDefaultsOnRecord.java @@ -1,3 +1,4 @@ +// version 14: @lombok.experimental.FieldDefaults(makeFinal = true) record FieldDefaultsOnRecord(String a, String b) { /* Implicit */ private final String a; /* Implicit */ private final String b; diff --git a/test/transform/resource/after-ecj/FieldNameConstantsOnRecord.java b/test/transform/resource/after-ecj/FieldNameConstantsOnRecord.java index b25fd6b3..6499ed4a 100644 --- a/test/transform/resource/after-ecj/FieldNameConstantsOnRecord.java +++ b/test/transform/resource/after-ecj/FieldNameConstantsOnRecord.java @@ -1,3 +1,4 @@ +// version 14: import lombok.experimental.FieldNameConstants; import lombok.AccessLevel; @FieldNameConstants(level = AccessLevel.PACKAGE) record FieldNameConstantsOnRecord(String iAmADvdPlayer, int $skipMe, int andMe, String butPrintMePlease) { diff --git a/test/transform/resource/after-ecj/GetterOnRecord.java b/test/transform/resource/after-ecj/GetterOnRecord.java index 2cb61dba..f694ef8b 100644 --- a/test/transform/resource/after-ecj/GetterOnRecord.java +++ b/test/transform/resource/after-ecj/GetterOnRecord.java @@ -1,3 +1,4 @@ +// version 14: import lombok.Getter; @Getter record GetterOnRecord(String a, String b) { /* Implicit */ private final String a; diff --git a/test/transform/resource/after-ecj/LoggerConfigOnRecord.java b/test/transform/resource/after-ecj/LoggerConfigOnRecord.java index ca572860..c97b7925 100644 --- a/test/transform/resource/after-ecj/LoggerConfigOnRecord.java +++ b/test/transform/resource/after-ecj/LoggerConfigOnRecord.java @@ -1,3 +1,4 @@ +// version 14: import lombok.extern.slf4j.Slf4j; @Slf4j record LoggerConfigOnRecord(String a, String b) { /* Implicit */ private final String a; diff --git a/test/transform/resource/after-ecj/LoggerSlf4jOnRecord.java b/test/transform/resource/after-ecj/LoggerSlf4jOnRecord.java index 804c8582..20a84d0d 100644 --- a/test/transform/resource/after-ecj/LoggerSlf4jOnRecord.java +++ b/test/transform/resource/after-ecj/LoggerSlf4jOnRecord.java @@ -1,3 +1,4 @@ +// version 14: import lombok.extern.slf4j.Slf4j; @Slf4j record LoggerSlf4jOnRecord(org log, String a) { private static final org.slf4j.Logger log = org.slf4j.LoggerFactory.getLogger(LoggerSlf4jOnRecord.class); diff --git a/test/transform/resource/after-ecj/NonNullExistingConstructorOnRecord.java b/test/transform/resource/after-ecj/NonNullExistingConstructorOnRecord.java index 82bc6ffd..dbf2abe8 100644 --- a/test/transform/resource/after-ecj/NonNullExistingConstructorOnRecord.java +++ b/test/transform/resource/after-ecj/NonNullExistingConstructorOnRecord.java @@ -1,3 +1,4 @@ +// version 14: import lombok.NonNull; record NonNullOnRecord(String a, String b) { /* Implicit */ private final String a; diff --git a/test/transform/resource/after-ecj/NonNullOnRecord.java b/test/transform/resource/after-ecj/NonNullOnRecord.java index 7d71d9cc..c8efdbe6 100644 --- a/test/transform/resource/after-ecj/NonNullOnRecord.java +++ b/test/transform/resource/after-ecj/NonNullOnRecord.java @@ -1,3 +1,4 @@ +// version 14: import lombok.NonNull; record NonNullOnRecord(String a, String b) { /* Implicit */ private final String a; diff --git a/test/transform/resource/after-ecj/SetterOnRecord.java b/test/transform/resource/after-ecj/SetterOnRecord.java index c9d3764f..d0103759 100644 --- a/test/transform/resource/after-ecj/SetterOnRecord.java +++ b/test/transform/resource/after-ecj/SetterOnRecord.java @@ -1,3 +1,4 @@ +// version 14: import lombok.Setter; @Setter record SetterOnRecord(String a, String b) { /* Implicit */ private final String a; diff --git a/test/transform/resource/after-ecj/ToStringOnRecord.java b/test/transform/resource/after-ecj/ToStringOnRecord.java index 8decb8d1..68caa235 100644 --- a/test/transform/resource/after-ecj/ToStringOnRecord.java +++ b/test/transform/resource/after-ecj/ToStringOnRecord.java @@ -1,3 +1,4 @@ +// version 14: import lombok.ToString; @ToString record ToStringOnRecord(String a, String b) { /* Implicit */ private final String a; diff --git a/test/transform/resource/after-ecj/UtilityClassOnRecord.java b/test/transform/resource/after-ecj/UtilityClassOnRecord.java index 036c0f86..0c0c138f 100644 --- a/test/transform/resource/after-ecj/UtilityClassOnRecord.java +++ b/test/transform/resource/after-ecj/UtilityClassOnRecord.java @@ -1,3 +1,4 @@ +// version 14: import lombok.experimental.UtilityClass; @UtilityClass record UtilityClassOnRecord(String a, String b) { /* Implicit */ private final String a; diff --git a/test/transform/resource/after-ecj/ValueOnRecord.java b/test/transform/resource/after-ecj/ValueOnRecord.java index 5b505c76..f1623ed3 100644 --- a/test/transform/resource/after-ecj/ValueOnRecord.java +++ b/test/transform/resource/after-ecj/ValueOnRecord.java @@ -1,3 +1,4 @@ +// version 14: import lombok.Value; @Value record ValueOnRecord(String a, String b) { /* Implicit */ private final String a; diff --git a/test/transform/resource/after-ecj/WithByOnRecord.java b/test/transform/resource/after-ecj/WithByOnRecord.java index c40841c8..8f179407 100644 --- a/test/transform/resource/after-ecj/WithByOnRecord.java +++ b/test/transform/resource/after-ecj/WithByOnRecord.java @@ -1,3 +1,4 @@ +// version 14: import lombok.experimental.WithBy; @WithBy record WithByOnRecord(String a, String b) { /* Implicit */ private final String a; diff --git a/test/transform/resource/after-ecj/WithByOnRecordComponent.java b/test/transform/resource/after-ecj/WithByOnRecordComponent.java index 19fe508c..5ee14810 100644 --- a/test/transform/resource/after-ecj/WithByOnRecordComponent.java +++ b/test/transform/resource/after-ecj/WithByOnRecordComponent.java @@ -1,3 +1,4 @@ +// version 14: import lombok.experimental.WithBy; record WithByOnRecordComponent(String a, String b) { /* Implicit */ private final String a; diff --git a/test/transform/resource/after-ecj/WithOnRecord.java b/test/transform/resource/after-ecj/WithOnRecord.java index 5ab8d6ac..2b24147a 100644 --- a/test/transform/resource/after-ecj/WithOnRecord.java +++ b/test/transform/resource/after-ecj/WithOnRecord.java @@ -1,3 +1,4 @@ +// version 14: import lombok.With; @With record WithOnRecord(String a, String b) { /* Implicit */ private final String a; diff --git a/test/transform/resource/after-ecj/WithOnRecordComponent.java b/test/transform/resource/after-ecj/WithOnRecordComponent.java index 42028f81..d1a602a6 100644 --- a/test/transform/resource/after-ecj/WithOnRecordComponent.java +++ b/test/transform/resource/after-ecj/WithOnRecordComponent.java @@ -1,3 +1,4 @@ +// version 14: import lombok.With; record WithOnRecordComponent(String a, String b) { /* Implicit */ private final String a; diff --git a/test/transform/resource/before/SuperBuilderOnRecord.java b/test/transform/resource/before/SuperBuilderOnRecord.java index 8925176e..23e5efac 100644 --- a/test/transform/resource/before/SuperBuilderOnRecord.java +++ b/test/transform/resource/before/SuperBuilderOnRecord.java @@ -4,5 +4,5 @@ import lombok.experimental.SuperBuilder; @SuperBuilder -record SupeBuilderOnRecord(String a, String b) { +record SuperBuilderOnRecord(String a, String b) { } \ No newline at end of file diff --git a/test/transform/resource/messages-delombok/SuperBuilderOnRecord.java.messages b/test/transform/resource/messages-delombok/SuperBuilderOnRecord.java.messages index 25b474ab..42d73efe 100644 --- a/test/transform/resource/messages-delombok/SuperBuilderOnRecord.java.messages +++ b/test/transform/resource/messages-delombok/SuperBuilderOnRecord.java.messages @@ -1 +1 @@ -6 @SuperBuilder is only supported on types. +6 @SuperBuilder is only supported on classes. diff --git a/test/transform/resource/messages-delombok/UtilityClassOnRecord.java.messages b/test/transform/resource/messages-delombok/UtilityClassOnRecord.java.messages index 9de73ebd..4091de0c 100644 --- a/test/transform/resource/messages-delombok/UtilityClassOnRecord.java.messages +++ b/test/transform/resource/messages-delombok/UtilityClassOnRecord.java.messages @@ -1 +1 @@ -5 @UtilityClass is only supported on a class (can't be an interface, enum, annotation, or record). +5 @UtilityClass is only supported on a class. diff --git a/test/transform/resource/messages-ecj/SuperBuilderOnRecord.java.messages b/test/transform/resource/messages-ecj/SuperBuilderOnRecord.java.messages index 25b474ab..42d73efe 100644 --- a/test/transform/resource/messages-ecj/SuperBuilderOnRecord.java.messages +++ b/test/transform/resource/messages-ecj/SuperBuilderOnRecord.java.messages @@ -1 +1 @@ -6 @SuperBuilder is only supported on types. +6 @SuperBuilder is only supported on classes. diff --git a/test/transform/resource/messages-ecj/UtilityClassOnRecord.java.messages b/test/transform/resource/messages-ecj/UtilityClassOnRecord.java.messages index 9de73ebd..4091de0c 100644 --- a/test/transform/resource/messages-ecj/UtilityClassOnRecord.java.messages +++ b/test/transform/resource/messages-ecj/UtilityClassOnRecord.java.messages @@ -1 +1 @@ -5 @UtilityClass is only supported on a class (can't be an interface, enum, annotation, or record). +5 @UtilityClass is only supported on a class. -- cgit