From 045638ec1f79f68747f135061d2e026faa719642 Mon Sep 17 00:00:00 2001
From: Roel Spilker <r.spilker@gmail.com>
Date: Mon, 6 Nov 2017 23:45:52 +0100
Subject: Generate correct hashCode when callSuper and no fields included.
 Fixes #1505

---
 .../eclipse/handlers/HandleEqualsAndHashCode.java  | 32 ++++++++++++----------
 1 file changed, 18 insertions(+), 14 deletions(-)

(limited to 'src/core/lombok/eclipse')

diff --git a/src/core/lombok/eclipse/handlers/HandleEqualsAndHashCode.java b/src/core/lombok/eclipse/handlers/HandleEqualsAndHashCode.java
index 37fa78ab..0d0f51db 100644
--- a/src/core/lombok/eclipse/handlers/HandleEqualsAndHashCode.java
+++ b/src/core/lombok/eclipse/handlers/HandleEqualsAndHashCode.java
@@ -299,7 +299,7 @@ public class HandleEqualsAndHashCode extends EclipseAnnotationHandler<EqualsAndH
 		
 		/* final int PRIME = X; */ {
 			/* Without fields, PRIME isn't used, and that would trigger a 'local variable not used' warning. */
-			if (!isEmpty || callSuper) {
+			if (!isEmpty) {
 				LocalDeclaration primeDecl = new LocalDeclaration(PRIME, pS, pE);
 				setGeneratedBy(primeDecl, source);
 				primeDecl.modifiers |= Modifier.FINAL;
@@ -311,26 +311,30 @@ public class HandleEqualsAndHashCode extends EclipseAnnotationHandler<EqualsAndH
 			}
 		}
 		
-		/* int result = 1; */ {
-			LocalDeclaration resultDecl = new LocalDeclaration(RESULT, pS, pE);
+		/*int result = ... */{
+		LocalDeclaration resultDecl = new LocalDeclaration(RESULT, pS, pE);
 			setGeneratedBy(resultDecl, source);
-			resultDecl.initialization = makeIntLiteral("1".toCharArray(), source);
+			final Expression init;
+			if (callSuper) {
+				/* ... super.hashCode(); */
+				MessageSend callToSuper = new MessageSend();
+				setGeneratedBy(callToSuper, source);
+				callToSuper.sourceStart = pS; callToSuper.sourceEnd = pE;
+				callToSuper.receiver = new SuperReference(pS, pE);
+				setGeneratedBy(callToSuper.receiver, source);
+				callToSuper.selector = "hashCode".toCharArray();
+				init = callToSuper;
+			} else {
+				/* ... 1; */
+				init = makeIntLiteral("1".toCharArray(), source);
+			}
+			resultDecl.initialization = init;
 			resultDecl.type = TypeReference.baseTypeReference(TypeIds.T_int, 0);
 			resultDecl.type.sourceStart = pS; resultDecl.type.sourceEnd = pE;
 			setGeneratedBy(resultDecl.type, source);
 			statements.add(resultDecl);
 		}
 		
-		if (callSuper) {
-			MessageSend callToSuper = new MessageSend();
-			setGeneratedBy(callToSuper, source);
-			callToSuper.sourceStart = pS; callToSuper.sourceEnd = pE;
-			callToSuper.receiver = new SuperReference(pS, pE);
-			setGeneratedBy(callToSuper.receiver, source);
-			callToSuper.selector = "hashCode".toCharArray();
-			statements.add(createResultCalculation(source, callToSuper));
-		}
-		
 		for (EclipseNode field : fields) {
 			TypeReference fType = getFieldType(field, fieldAccess);
 			char[] dollarFieldName = ("$" + field.getName()).toCharArray();
-- 
cgit