From 7e84f8d1c2abd902dfc7a88c2f60c58717a955a1 Mon Sep 17 00:00:00 2001 From: Reinier Zwitserloot Date: Mon, 12 Nov 2012 22:07:07 +0100 Subject: [refactor] Cleaned up static imports (always use *), and refactored out getCtcInt calls into constants as defined in Javac. --- src/core/lombok/javac/handlers/HandleGetter.java | 21 ++++++++++----------- 1 file changed, 10 insertions(+), 11 deletions(-) (limited to 'src/core/lombok/javac/handlers/HandleGetter.java') diff --git a/src/core/lombok/javac/handlers/HandleGetter.java b/src/core/lombok/javac/handlers/HandleGetter.java index 8a1fb4e1..65947c72 100644 --- a/src/core/lombok/javac/handlers/HandleGetter.java +++ b/src/core/lombok/javac/handlers/HandleGetter.java @@ -42,7 +42,6 @@ import lombok.javac.handlers.JavacHandlerUtil.FieldAccess; import org.mangosdk.spi.ProviderFor; import com.sun.tools.javac.code.Flags; -import com.sun.tools.javac.code.TypeTags; import com.sun.tools.javac.tree.JCTree; import com.sun.tools.javac.tree.TreeMaker; import com.sun.tools.javac.tree.JCTree.JCAnnotation; @@ -288,14 +287,14 @@ public class HandleGetter extends JavacAnnotationHandler { private static final java.util.Map TYPE_MAP; static { Map m = new HashMap(); - m.put(getCtcInt(TypeTags.class, "INT"), "java.lang.Integer"); - m.put(getCtcInt(TypeTags.class, "DOUBLE"), "java.lang.Double"); - m.put(getCtcInt(TypeTags.class, "FLOAT"), "java.lang.Float"); - m.put(getCtcInt(TypeTags.class, "SHORT"), "java.lang.Short"); - m.put(getCtcInt(TypeTags.class, "BYTE"), "java.lang.Byte"); - m.put(getCtcInt(TypeTags.class, "LONG"), "java.lang.Long"); - m.put(getCtcInt(TypeTags.class, "BOOLEAN"), "java.lang.Boolean"); - m.put(getCtcInt(TypeTags.class, "CHAR"), "java.lang.Character"); + m.put(CTC_INT, "java.lang.Integer"); + m.put(CTC_DOUBLE, "java.lang.Double"); + m.put(CTC_FLOAT, "java.lang.Float"); + m.put(CTC_SHORT, "java.lang.Short"); + m.put(CTC_BYTE, "java.lang.Byte"); + m.put(CTC_LONG, "java.lang.Long"); + m.put(CTC_BOOLEAN, "java.lang.Boolean"); + m.put(CTC_CHAR, "java.lang.Character"); TYPE_MAP = Collections.unmodifiableMap(m); } @@ -361,7 +360,7 @@ public class HandleGetter extends JavacAnnotationHandler { innerIfStatements.append(statement); } - JCBinary isNull = maker.Binary(getCtcInt(JCTree.class, "EQ"), maker.Ident(valueName), maker.Literal(getCtcInt(TypeTags.class, "BOT"), null)); + JCBinary isNull = maker.Binary(CTC_EQUAL, maker.Ident(valueName), maker.Literal(CTC_BOT, null)); JCIf ifStatement = maker.If(isNull, maker.Block(0, innerIfStatements.toList()), null); synchronizedStatements.append(ifStatement); } @@ -369,7 +368,7 @@ public class HandleGetter extends JavacAnnotationHandler { synchronizedStatement = maker.Synchronized(createFieldAccessor(maker, fieldNode, FieldAccess.ALWAYS_FIELD), maker.Block(0, synchronizedStatements.toList())); } - JCBinary isNull = maker.Binary(getCtcInt(JCTree.class, "EQ"), maker.Ident(valueName), maker.Literal(getCtcInt(TypeTags.class, "BOT"), null)); + JCBinary isNull = maker.Binary(CTC_EQUAL, maker.Ident(valueName), maker.Literal(CTC_BOT, null)); JCIf ifStatement = maker.If(isNull, maker.Block(0, List.of(synchronizedStatement)), null); statements.append(ifStatement); } -- cgit