From f84f3a1bc8407160b82580300d2a58fd8c66aaa1 Mon Sep 17 00:00:00 2001 From: Reinier Zwitserloot Date: Sat, 11 Jul 2009 11:12:47 +0200 Subject: The setter/getter handlers now mark themselves as not wanted to be called upon anymore when reporting errors. They were logging 4 or more identical warnings per problem before this change. --- src/lombok/eclipse/handlers/HandleSetter.java | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to 'src/lombok/eclipse/handlers/HandleSetter.java') diff --git a/src/lombok/eclipse/handlers/HandleSetter.java b/src/lombok/eclipse/handlers/HandleSetter.java index 70eb855e..b08f298a 100644 --- a/src/lombok/eclipse/handlers/HandleSetter.java +++ b/src/lombok/eclipse/handlers/HandleSetter.java @@ -95,7 +95,7 @@ public class HandleSetter implements EclipseAnnotationHandler { private boolean createSetterForField(AccessLevel level, Node fieldNode, Node errorNode, ASTNode pos, boolean whineIfExists) { if ( fieldNode.getKind() != Kind.FIELD ) { errorNode.addError("@Setter is only supported on a field."); - return false; + return true; } FieldDeclaration field = (FieldDeclaration) fieldNode.get(); @@ -110,7 +110,7 @@ public class HandleSetter implements EclipseAnnotationHandler { if ( whineIfExists ) errorNode.addWarning( String.format("Not generating %s(%s %s): A method with that name already exists", setterName, field.type, new String(field.name))); - return false; + return true; default: case NOT_EXISTS: //continue with creating the setter @@ -121,7 +121,7 @@ public class HandleSetter implements EclipseAnnotationHandler { injectMethod(fieldNode.up(), method); - return false; + return true; } private MethodDeclaration generateSetter(TypeDeclaration parent, FieldDeclaration field, String name, -- cgit