From a27826b268c28a7aa1596bb07461ab1cfb113d82 Mon Sep 17 00:00:00 2001 From: Reinier Zwitserloot Date: Mon, 23 Apr 2018 22:36:07 +0200 Subject: [bugfix] generics on inner classes whose outer type has generics, when the outer type is an interface, caused bugs in ecj. --- ...ndHashCodeWithGenericsOnInnersInInterfaces.java | 27 +++++++++++++++++++ ...ndHashCodeWithGenericsOnInnersInInterfaces.java | 30 ++++++++++++++++++++++ .../before/BuilderWithRecursiveGenerics.java | 2 +- ...ndHashCodeWithGenericsOnInnersInInterfaces.java | 6 +++++ 4 files changed, 64 insertions(+), 1 deletion(-) create mode 100644 test/transform/resource/after-delombok/EqualsAndHashCodeWithGenericsOnInnersInInterfaces.java create mode 100644 test/transform/resource/after-ecj/EqualsAndHashCodeWithGenericsOnInnersInInterfaces.java create mode 100644 test/transform/resource/before/EqualsAndHashCodeWithGenericsOnInnersInInterfaces.java (limited to 'test/transform') diff --git a/test/transform/resource/after-delombok/EqualsAndHashCodeWithGenericsOnInnersInInterfaces.java b/test/transform/resource/after-delombok/EqualsAndHashCodeWithGenericsOnInnersInInterfaces.java new file mode 100644 index 00000000..ed25b317 --- /dev/null +++ b/test/transform/resource/after-delombok/EqualsAndHashCodeWithGenericsOnInnersInInterfaces.java @@ -0,0 +1,27 @@ +public interface EqualsAndHashCodeWithGenericsOnInnersInInterfaces { + class Inner { + int x; + @java.lang.Override + @java.lang.SuppressWarnings("all") + public boolean equals(final java.lang.Object o) { + if (o == this) return true; + if (!(o instanceof EqualsAndHashCodeWithGenericsOnInnersInInterfaces.Inner)) return false; + final EqualsAndHashCodeWithGenericsOnInnersInInterfaces.Inner other = (EqualsAndHashCodeWithGenericsOnInnersInInterfaces.Inner) o; + if (!other.canEqual((java.lang.Object) this)) return false; + if (this.x != other.x) return false; + return true; + } + @java.lang.SuppressWarnings("all") + protected boolean canEqual(final java.lang.Object other) { + return other instanceof EqualsAndHashCodeWithGenericsOnInnersInInterfaces.Inner; + } + @java.lang.Override + @java.lang.SuppressWarnings("all") + public int hashCode() { + final int PRIME = 59; + int result = 1; + result = result * PRIME + this.x; + return result; + } + } +} diff --git a/test/transform/resource/after-ecj/EqualsAndHashCodeWithGenericsOnInnersInInterfaces.java b/test/transform/resource/after-ecj/EqualsAndHashCodeWithGenericsOnInnersInInterfaces.java new file mode 100644 index 00000000..8c849502 --- /dev/null +++ b/test/transform/resource/after-ecj/EqualsAndHashCodeWithGenericsOnInnersInInterfaces.java @@ -0,0 +1,30 @@ +public interface EqualsAndHashCodeWithGenericsOnInnersInInterfaces { + @lombok.EqualsAndHashCode class Inner { + int x; + Inner() { + super(); + } + public @java.lang.Override @java.lang.SuppressWarnings("all") boolean equals(final java.lang.Object o) { + if ((o == this)) + return true; + if ((! (o instanceof EqualsAndHashCodeWithGenericsOnInnersInInterfaces.Inner))) + return false; + final EqualsAndHashCodeWithGenericsOnInnersInInterfaces.Inner other = (EqualsAndHashCodeWithGenericsOnInnersInInterfaces.Inner) o; + if ((! other.canEqual((java.lang.Object) this))) + return false; + if ((this.x != other.x)) + return false; + return true; + } + protected @java.lang.SuppressWarnings("all") boolean canEqual(final java.lang.Object other) { + return (other instanceof EqualsAndHashCodeWithGenericsOnInnersInInterfaces.Inner); + } + public @java.lang.Override @java.lang.SuppressWarnings("all") int hashCode() { + final int PRIME = 59; + int result = 1; + result = ((result * PRIME) + this.x); + return result; + } + } +} + diff --git a/test/transform/resource/before/BuilderWithRecursiveGenerics.java b/test/transform/resource/before/BuilderWithRecursiveGenerics.java index 041da414..0ab86220 100644 --- a/test/transform/resource/before/BuilderWithRecursiveGenerics.java +++ b/test/transform/resource/before/BuilderWithRecursiveGenerics.java @@ -5,7 +5,7 @@ import lombok.Value; public class BuilderWithRecursiveGenerics { interface Inter> {} - + @Builder @Value public static class Test, Quz extends Inter> { Foo foo; Bar bar; diff --git a/test/transform/resource/before/EqualsAndHashCodeWithGenericsOnInnersInInterfaces.java b/test/transform/resource/before/EqualsAndHashCodeWithGenericsOnInnersInInterfaces.java new file mode 100644 index 00000000..585ebbde --- /dev/null +++ b/test/transform/resource/before/EqualsAndHashCodeWithGenericsOnInnersInInterfaces.java @@ -0,0 +1,6 @@ +public interface EqualsAndHashCodeWithGenericsOnInnersInInterfaces { + @lombok.EqualsAndHashCode class Inner { + int x; + } +} + -- cgit