From c10fe50f6a704228bf91aeaea620e2a84c017df9 Mon Sep 17 00:00:00 2001 From: Reinier Zwitserloot Date: Fri, 18 Sep 2020 01:01:41 +0200 Subject: [tests] removed a ridiculously exotic feature that still works, but is too hard to test Specifically, using as custom logger topic a concatenated string, like literally `"A" + "B"`. It works, but depending on javac and phase of the moon that ends up as `"A" + "B"` or `"AB"`, and I don't think it's worthwhile for lombok to try to be consistent in this and test for that. --- test/transform/resource/after-delombok/LoggerSlf4j.java | 5 ----- test/transform/resource/after-ecj/LoggerSlf4j.java | 8 -------- test/transform/resource/before/LoggerSlf4j.java | 4 ---- 3 files changed, 17 deletions(-) (limited to 'test/transform') diff --git a/test/transform/resource/after-delombok/LoggerSlf4j.java b/test/transform/resource/after-delombok/LoggerSlf4j.java index 70f11ae4..152c8708 100644 --- a/test/transform/resource/after-delombok/LoggerSlf4j.java +++ b/test/transform/resource/after-delombok/LoggerSlf4j.java @@ -29,8 +29,3 @@ class LoggerSlf4jWithTwoStaticFields { private static final org.slf4j.Logger log = org.slf4j.LoggerFactory.getLogger(LoggerSlf4jWithTwoStaticFields.TOPIC + LoggerSlf4jWithTwoStaticFields.TOPIC); static final String TOPIC = "StaticField"; } - -class LoggerSlf4jWithTwoLiterals { - @java.lang.SuppressWarnings("all") - private static final org.slf4j.Logger log = org.slf4j.LoggerFactory.getLogger("A" + "B"); -} \ No newline at end of file diff --git a/test/transform/resource/after-ecj/LoggerSlf4j.java b/test/transform/resource/after-ecj/LoggerSlf4j.java index c303a895..286d023b 100644 --- a/test/transform/resource/after-ecj/LoggerSlf4j.java +++ b/test/transform/resource/after-ecj/LoggerSlf4j.java @@ -56,11 +56,3 @@ class LoggerSlf4jOuter { super(); } } -@Slf4j(topic = ExtendedStringLiteral{AB}) class LoggerSlf4jWithTwoLiterals { - private static final org.slf4j.Logger log = org.slf4j.LoggerFactory.getLogger("AB"); - () { - } - LoggerSlf4jWithTwoLiterals() { - super(); - } -} \ No newline at end of file diff --git a/test/transform/resource/before/LoggerSlf4j.java b/test/transform/resource/before/LoggerSlf4j.java index 3f8284e8..c59db4ee 100644 --- a/test/transform/resource/before/LoggerSlf4j.java +++ b/test/transform/resource/before/LoggerSlf4j.java @@ -28,7 +28,3 @@ class LoggerSlf4jWithStaticField { class LoggerSlf4jWithTwoStaticFields { static final String TOPIC = "StaticField"; } - -@Slf4j(topic="A"+"B") -class LoggerSlf4jWithTwoLiterals { -} \ No newline at end of file -- cgit