From 78e526690c22f1c5a1c93705076229ff32284741 Mon Sep 17 00:00:00 2001 From: Kevin Chirls Date: Wed, 15 Mar 2017 10:09:04 -0700 Subject: Updates for pull request #1284. Fix for issues #869 and #1018. Added name to AUTHORS file. Added ECJ fix and test. Made one of the variables final to also verify the final error case. --- .../after-delombok/ConstructorsWithAccessors.java | 3 +-- .../after-ecj/ConstructorsWithAccessors.java | 30 ++++++++++++++++++++++ .../resource/before/ConstructorsWithAccessors.java | 2 +- 3 files changed, 32 insertions(+), 3 deletions(-) (limited to 'test') diff --git a/test/transform/resource/after-delombok/ConstructorsWithAccessors.java b/test/transform/resource/after-delombok/ConstructorsWithAccessors.java index 25455943..6e9398ba 100644 --- a/test/transform/resource/after-delombok/ConstructorsWithAccessors.java +++ b/test/transform/resource/after-delombok/ConstructorsWithAccessors.java @@ -23,12 +23,11 @@ class NonNullConstructorsWithAccessors { @lombok.NonNull Integer _huh; @lombok.NonNull - Integer __huh2; + final Integer __huh2; @java.beans.ConstructorProperties({"plower", "upper", "huh", "_huh2"}) @java.lang.SuppressWarnings("all") @javax.annotation.Generated("lombok") - @lombok.Generated public NonNullConstructorsWithAccessors(@lombok.NonNull final Integer plower, @lombok.NonNull final Integer upper, @lombok.NonNull final Integer huh, @lombok.NonNull final Integer _huh2) { if (plower == null) { throw new java.lang.NullPointerException("plower"); diff --git a/test/transform/resource/after-ecj/ConstructorsWithAccessors.java b/test/transform/resource/after-ecj/ConstructorsWithAccessors.java index 7c691b42..b7a20e18 100644 --- a/test/transform/resource/after-ecj/ConstructorsWithAccessors.java +++ b/test/transform/resource/after-ecj/ConstructorsWithAccessors.java @@ -11,3 +11,33 @@ this.__huh2 = _huh2; } } +@lombok.AllArgsConstructor @lombok.experimental.Accessors(prefix = {"p", "_"}) class NonNullConstructorsWithAccessors { + @lombok.NonNull Integer plower; + @lombok.NonNull Integer pUpper; + @lombok.NonNull Integer _huh; + final @lombok.NonNull Integer __huh2; + public @java.beans.ConstructorProperties({"plower", "upper", "huh", "_huh2"}) @java.lang.SuppressWarnings("all") @javax.annotation.Generated("lombok") NonNullConstructorsWithAccessors(final @lombok.NonNull Integer plower, final @lombok.NonNull Integer upper, final @lombok.NonNull Integer huh, final @lombok.NonNull Integer _huh2) { + super(); + if ((plower == null)) + { + throw new java.lang.NullPointerException("plower"); + } + if ((upper == null)) + { + throw new java.lang.NullPointerException("upper"); + } + if ((huh == null)) + { + throw new java.lang.NullPointerException("huh"); + } + if ((_huh2 == null)) + { + throw new java.lang.NullPointerException("_huh2"); + } + this.plower = plower; + this.pUpper = upper; + this._huh = huh; + this.__huh2 = _huh2; + } +} + diff --git a/test/transform/resource/before/ConstructorsWithAccessors.java b/test/transform/resource/before/ConstructorsWithAccessors.java index 6facb03a..12221ab7 100644 --- a/test/transform/resource/before/ConstructorsWithAccessors.java +++ b/test/transform/resource/before/ConstructorsWithAccessors.java @@ -9,6 +9,6 @@ @lombok.NonNull Integer plower; @lombok.NonNull Integer pUpper; @lombok.NonNull Integer _huh; - @lombok.NonNull Integer __huh2; + @lombok.NonNull final Integer __huh2; } -- cgit