From 48fe08caf430672b0497ae496b64ca1f6e3bfb21 Mon Sep 17 00:00:00 2001 From: Ivan Molodetskikh Date: Mon, 14 Jul 2025 14:53:04 +0300 Subject: CONTRIBUTING.md: Mention testing in writing PRs --- CONTRIBUTING.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 64eea3d8..3844a16b 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -86,6 +86,7 @@ When creating pull requests, please keep the following in mind. - When you address a review comment, mark it as resolved. - Remember to [run tests](https://github.com/YaLTeR/niri/wiki/Developing-niri#tests) and format the code with `cargo +nightly fmt --all`. - For new layout actions, remember to add them to the randomized tests. For weird Wayland handling, adding client-server tests in `src/tests/` could be very useful. +- Test your changes by hand thoroughly, including for edge cases and weird interactions. See the Testing section above for some tips. - Remember to document new config options on the wiki. - When opening a pull request, ensure "Allow edits from maintainers" is enabled, so I can make final tweaks before merging. -- cgit