From 47a8e75fd585e351dd2846a58152a7766403ca11 Mon Sep 17 00:00:00 2001 From: TheZoq2 Date: Mon, 22 Apr 2024 22:51:52 +0200 Subject: Add is_active_in_column Add missing ``` Fix tests --- src/layout/mod.rs | 3 +++ src/layout/workspace.rs | 8 +++++--- src/window/mapped.rs | 10 ++++++++++ src/window/mod.rs | 13 +++++++++++++ 4 files changed, 31 insertions(+), 3 deletions(-) (limited to 'src') diff --git a/src/layout/mod.rs b/src/layout/mod.rs index 75f6cd4c..0cb8e493 100644 --- a/src/layout/mod.rs +++ b/src/layout/mod.rs @@ -152,6 +152,7 @@ pub trait LayoutElement { fn output_leave(&self, output: &Output); fn set_offscreen_element_id(&self, id: Option); fn set_activated(&mut self, active: bool); + fn set_active_in_column(&mut self, active: bool); fn set_bounds(&self, bounds: Size); fn send_pending_configure(&mut self); @@ -2190,6 +2191,8 @@ mod tests { fn send_pending_configure(&mut self) {} + fn set_active_in_column(&mut self, _active: bool) {} + fn is_fullscreen(&self) -> bool { false } diff --git a/src/layout/workspace.rs b/src/layout/workspace.rs index 3dbb473b..b2d1d5a2 100644 --- a/src/layout/workspace.rs +++ b/src/layout/workspace.rs @@ -2459,9 +2459,11 @@ impl Workspace { for (tile_idx, tile) in col.tiles.iter_mut().enumerate() { let win = tile.window_mut(); - let active = is_active - && self.active_column_idx == col_idx - && col.active_tile_idx == tile_idx; + + let active_in_column = col.active_tile_idx == tile_idx; + win.set_active_in_column(active_in_column); + + let active = is_active && self.active_column_idx == col_idx && active_in_column; win.set_activated(active); win.set_interactive_resize(col_resize_data); diff --git a/src/window/mapped.rs b/src/window/mapped.rs index 4b31da22..bdb62df8 100644 --- a/src/window/mapped.rs +++ b/src/window/mapped.rs @@ -49,6 +49,9 @@ pub struct Mapped { /// Whether this window has the keyboard focus. is_focused: bool, + /// Whether this window is the active window in its column. + pub is_active_in_column: bool, + /// Buffer to draw instead of the window when it should be blocked out. block_out_buffer: RefCell, @@ -102,6 +105,7 @@ impl Mapped { rules, need_to_recompute_rules: false, is_focused: false, + is_active_in_column: false, block_out_buffer: RefCell::new(SolidColorBuffer::new((0, 0), [0., 0., 0., 1.])), animate_next_configure: false, animate_serials: Vec::new(), @@ -458,6 +462,12 @@ impl LayoutElement for Mapped { self.need_to_recompute_rules |= changed; } + fn set_active_in_column(&mut self, active: bool) { + let changed = self.is_active_in_column != active; + self.is_active_in_column = active; + self.need_to_recompute_rules |= changed; + } + fn set_bounds(&self, bounds: Size) { self.toplevel().with_pending_state(|state| { state.bounds = Some(bounds); diff --git a/src/window/mod.rs b/src/window/mod.rs index 3af9eebd..4ccbb111 100644 --- a/src/window/mod.rs +++ b/src/window/mod.rs @@ -85,6 +85,13 @@ impl<'a> WindowRef<'a> { WindowRef::Mapped(mapped) => mapped.is_focused(), } } + + pub fn is_active_in_column(self) -> bool { + match self { + WindowRef::Unmapped(_) => false, + WindowRef::Mapped(mapped) => mapped.is_active_in_column, + } + } } impl ResolvedWindowRules { @@ -254,5 +261,11 @@ fn window_matches(window: WindowRef, role: &XdgToplevelSurfaceRoleAttributes, m: } } + if let Some(is_active_in_column) = m.is_active_in_column { + if window.is_active_in_column() != is_active_in_column { + return false; + } + } + true } -- cgit