From b5467c3a5fe97e006e8946bc99e569199fe9d887 Mon Sep 17 00:00:00 2001
From: James Smith <js5@sanger.ac.uk>
Date: Mon, 13 Dec 2021 04:12:49 +0000
Subject: Update blog.txt

---
 challenge-139/james-smith/blog.txt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/challenge-139/james-smith/blog.txt b/challenge-139/james-smith/blog.txt
index 6a2d58b005..dc41a6e2bd 100644
--- a/challenge-139/james-smith/blog.txt
+++ b/challenge-139/james-smith/blog.txt
@@ -1 +1 @@
-https://github.com/drbaggy/perlweeklychallenge-club/new/master/challenge-139/james-smith
+https://github.com/drbaggy/perlweeklychallenge-club/tree/master/challenge-139/james-smith
-- 
cgit 


From 13d671c38f5bfdcec24b93cfd5bfd2ded929ce2a Mon Sep 17 00:00:00 2001
From: drbaggy <js5@sanger.ac.uk>
Date: Mon, 13 Dec 2021 12:49:40 +0000
Subject: first submit

---
 challenge-143/james-smith/README.md    | 29 ++++++++++++----------------
 challenge-143/james-smith/blog.txt     |  1 +
 challenge-143/james-smith/perl/ch-1.pl | 35 ++++++++++++++++++++++++++++++++++
 challenge-143/james-smith/perl/ch-2.pl | 33 ++++++++++++++++++++++++++++++++
 4 files changed, 81 insertions(+), 17 deletions(-)
 create mode 100644 challenge-143/james-smith/blog.txt
 create mode 100644 challenge-143/james-smith/perl/ch-1.pl
 create mode 100644 challenge-143/james-smith/perl/ch-2.pl

diff --git a/challenge-143/james-smith/README.md b/challenge-143/james-smith/README.md
index 90c0a8816c..67a6742064 100644
--- a/challenge-143/james-smith/README.md
+++ b/challenge-143/james-smith/README.md
@@ -1,4 +1,4 @@
-# Perl Weekly Challenge #142
+# Perl Weekly Challenge #143
 
 You can find more information about this weeks, and previous weeks challenges at:
 
@@ -10,32 +10,27 @@ submit solutions in whichever language you feel comfortable with.
 
 You can find the solutions here on github at:
 
-https://github.com/drbaggy/perlweeklychallenge-club/tree/master/challenge-142/james-smith/perl
+https://github.com/drbaggy/perlweeklychallenge-club/tree/master/challenge-143/james-smith/perl
 
-# Challenge 1 - Divisor Last Digit
+# Challenge 1 - Calculator
 
-***You are given positive integers, `$m` and `$n`.  Write a script to find total count of divisors of `$m` having last digit `$n`.***
+***You are given a string, `$s`, containing mathematical expression. Write a script to print the result of the mathematical expression. To keep it simple, please only accept `+ - * ()`.***`
 
 ## The solution
 
 ```perl
-sub divisor_last_digit {
-  my($m,$n)=@_;
-  ($n==1?1:0)+grep{$_%10==$n}
-              map{$m%$_?():$m==$_*$_?($_):($_,$m/$_)}
-              2..sqrt$m;
+sub evaluate  {
+  my $str = shift;
+  1 while $str =~ s/\(\s*([^()]*?)\s*\)/       evaluate($1)             /e;
+  1 while $str =~ s/(-?\d+)\s*\*\s*(-?\d+)/    $1 * $2                  /e;
+  1 while $str =~ s/(-?\d+)\s*([-+])\s*(-?\d+)/$2 eq '+' ? $1+$3 : $1-$3/e;
+  return $str;
 }
 ```
 
- * First we find all the factors - by looping over all values between `2` and the square root of `$m`. If the value is a factor, so is `$m/$_`.
- * We have a special case when `$m` is a square to avoid including the square root twice.
- * We then `grep` to obtain those which have the correct last digit.
- * There is one extra special case if `$n` is `1` we have to add `1` as `1` is a factor which we miss out in our calculations (so we don't
-   equally get `$m` as a factor).
+# Challenge 2 - Stealthy Number
 
-# Challenge 2 - Sleep sort
-
-***Another joke sort similar to JortSort suggested by champion Adam Russell. You are given a list of numbers. Write a script to implement Sleep Sort.***
+***You are given a positive number, `$n`.  Write a script to find out if the given number is Stealthy Number. A positive integer `N` is stealthy, if there exist positive integers `a`, `b`, `c`, `d` such that `a * b = c * d = N` and `a + b = c + d + 1`.***
 
 To perform a sleep sort - we loop through the list of numbers, sleeping for `$value` seconds and updating the list of results with `$value`
 
diff --git a/challenge-143/james-smith/blog.txt b/challenge-143/james-smith/blog.txt
new file mode 100644
index 0000000000..efff1b655b
--- /dev/null
+++ b/challenge-143/james-smith/blog.txt
@@ -0,0 +1 @@
+https://github.com/drbaggy/perlweeklychallenge-club/new/master/challenge-143/james-smith
diff --git a/challenge-143/james-smith/perl/ch-1.pl b/challenge-143/james-smith/perl/ch-1.pl
new file mode 100644
index 0000000000..a4abfdeaab
--- /dev/null
+++ b/challenge-143/james-smith/perl/ch-1.pl
@@ -0,0 +1,35 @@
+#!/usr/local/bin/perl
+
+use strict;
+
+use warnings;
+use feature qw(say);
+use Test::More;
+use Benchmark qw(cmpthese timethis);
+use Data::Dumper qw(Dumper);
+
+my @TESTS = (
+  [ '10 + 20 - 5', 25 ],
+  [ '(10 + 20 - 5) * 2', 50 ],
+  [ '(5 - 10) * -5', 25 ],
+  [ '10 * 10 - 6 * 6 - 8 * 8', 0 ],
+  [ '4 + 4 - 6 - 2', 0 ],
+  [ '(10 + 10) * (10 - 10) * (10 + 10) * (20 - (((20))))', 0 ],
+);
+
+is( evaluate($_->[0]), $_->[1] ) foreach @TESTS;
+is( eval(    $_->[0]), $_->[1] ) foreach @TESTS;
+cmpthese( 20000, {
+  'evaluate' => sub { evaluate($_->[0]) for @TESTS },
+  'eval'     => sub { eval(    $_->[0]) for @TESTS },
+});
+done_testing();
+
+sub evaluate  {
+  my $str = shift;
+  1 while $str =~ s/\(\s*([^()]*?)\s*\)/       evaluate($1)             /e;
+  1 while $str =~ s/(-?\d+)\s*\*\s*(-?\d+)/    $1 * $2                  /e;
+  1 while $str =~ s/(-?\d+)\s*([-+])\s*(-?\d+)/$2 eq '+' ? $1+$3 : $1-$3/e;
+  return $str;
+}
+
diff --git a/challenge-143/james-smith/perl/ch-2.pl b/challenge-143/james-smith/perl/ch-2.pl
new file mode 100644
index 0000000000..ddfe30d376
--- /dev/null
+++ b/challenge-143/james-smith/perl/ch-2.pl
@@ -0,0 +1,33 @@
+#!/usr/local/bin/perl
+
+use strict;
+
+use warnings;
+use feature qw(say);
+use Test::More;
+use Benchmark qw(cmpthese timethis);
+use Data::Dumper qw(Dumper);
+
+my @ST = (4,12,24,36,40,60,72,84,112,120,144,180,220,240,
+ 252,264,312,336,360,364,400,420,432,480,504,540,
+ 544,600,612,660,672,684,760,792,840,864,900,924,
+ 936,1012,1080,1092,1104,1120,1200,1260,1300,1320);
+my @NST = map { $_ + 15 } @ST;
+my @TESTS = (
+  [ 36, 1 ],
+  [ 12, 1 ],
+  [  6, 0 ],
+  ( map { [$_ => 1] } @ST  ),
+  ( map { [$_ => 0] } @NST ),
+);
+
+is( stealthy_number($_->[0]), $_->[1] ) foreach @TESTS;
+
+done_testing();
+
+sub stealthy_number {
+  my($n,%c) = shift;
+  $n%$_||($c{$n/$_+$_ }++,$c{$n/$_+$_+1}++) for 1..sqrt$n;
+  (grep { $_ > 1 } values %c) ? 1 : 0;
+}
+
-- 
cgit 


From 07b1884f7284cfcd9bd72829b5de4c4751b90100 Mon Sep 17 00:00:00 2001
From: drbaggy <js5@sanger.ac.uk>
Date: Mon, 13 Dec 2021 12:59:40 +0000
Subject: first submit

---
 challenge-143/james-smith/README.md | 43 ++++++-------------------------------
 1 file changed, 6 insertions(+), 37 deletions(-)

diff --git a/challenge-143/james-smith/README.md b/challenge-143/james-smith/README.md
index 67a6742064..d7d0f3e04a 100644
--- a/challenge-143/james-smith/README.md
+++ b/challenge-143/james-smith/README.md
@@ -10,7 +10,7 @@ submit solutions in whichever language you feel comfortable with.
 
 You can find the solutions here on github at:
 
-https://github.com/drbaggy/perlweeklychallenge-club/tree/master/challenge-143/james-smith/perl
+https://github.com/drbaggy/perlweeklychallenge-club/tree/master/challenge-143/james-smith
 
 # Challenge 1 - Calculator
 
@@ -32,44 +32,13 @@ sub evaluate  {
 
 ***You are given a positive number, `$n`.  Write a script to find out if the given number is Stealthy Number. A positive integer `N` is stealthy, if there exist positive integers `a`, `b`, `c`, `d` such that `a * b = c * d = N` and `a + b = c + d + 1`.***
 
-To perform a sleep sort - we loop through the list of numbers, sleeping for `$value` seconds and updating the list of results with `$value`
-
 ## The solution
 
-We need to parallelise this process
-
-There are different ways of doing this `fork`, `threads`, `Promises`.
-
-We will go for the `threads` approach as it easier to implement that `Promises` but doesn't eat at memory by forking lots of times.
-
 ```perl
-use threads;
-use threads::shared;
-use Time::HiRes qw(sleep);
-
-my @res :shared;
-my @list=map{0.001*int rand 3000}1..20;
-
-say "@list";
-
-sub sleeper {sleep$_[0];push@res,$_[0]}
-
-threads->new( \&sleeper, $_ ) for @list;
-
-$_->join for threads->list;
-
-say for @res;
+sub stealthy_number {
+  my($n,%c) = shift;
+  $n%$_||($c{$n/$_+$_ }++,$c{$n/$_+$_+1}++) for 1..sqrt$n;
+  (grep { $_ > 1 } values %c) ? 1 : 0;
+}
 ```
 
-## Notes
-
- * We create a test set of 20 values between `0` and `3`.
- * We fire off all the threads (`threads->new`)
- * Wait for them to finish `$_->join for threads->list`
- * Return the results.
- * As well as `use threads`, we also `use threads::shared`. This lets us declare the results array `@res` shareable across all processes, which we need to collect the values.
-
-## Caveat
-
-Not all threads start at the same time so sometimes results don't quite come back in the same order - especially if values are close together.
-
-- 
cgit 


From 526c322c070f34841e5a75a25a1d86bd370d88e8 Mon Sep 17 00:00:00 2001
From: drbaggy <js5@sanger.ac.uk>
Date: Mon, 13 Dec 2021 17:22:06 +0000
Subject: some notes

---
 challenge-143/james-smith/README.md | 24 ++++++++++++++++++++++++
 1 file changed, 24 insertions(+)

diff --git a/challenge-143/james-smith/README.md b/challenge-143/james-smith/README.md
index d7d0f3e04a..fc9a9a857d 100644
--- a/challenge-143/james-smith/README.md
+++ b/challenge-143/james-smith/README.md
@@ -18,6 +18,22 @@ https://github.com/drbaggy/perlweeklychallenge-club/tree/master/challenge-143/ja
 
 ## The solution
 
+The simple solution is just to "`eval`" the string, but where is the fun in that... We can either go for a tokenizing parser - where we create an array of elements brackets, symbols, numbers, or we can use regular expressions to reduce the equation.
+
+All students will remember BODMAS - Brackets, order, Division/Multiplication, Addition/Division. (or BIDMAS, PIDMAS, PEMDAS or whatever you used to remember it). So we have to break our prasing down into:
+
+ * Brackets
+ * Order    - we don't have this in our equations
+ * Division/Multiplication - we only have the latter
+ * Addition/Subtraction.
+
+So our logic becomes:
+
+ * Find brackets without brackets within - for these we evaluate the contents using the same algorithm;
+ * If there are no brackets left - we then looking for multiplications from left to right and evaluate these.
+ * If there are no brackets or multiplications we look at the addition/subtraction again left to right.
+ * This gives the following perl function:
+
 ```perl
 sub evaluate  {
   my $str = shift;
@@ -28,12 +44,20 @@ sub evaluate  {
 }
 ```
 
+For small strings - this is about the same speed as `eval`, for larger strings not so, but in both cases it is "safer" as string `eval` of "tainted" input is a real security risk.
+
 # Challenge 2 - Stealthy Number
 
 ***You are given a positive number, `$n`.  Write a script to find out if the given number is Stealthy Number. A positive integer `N` is stealthy, if there exist positive integers `a`, `b`, `c`, `d` such that `a * b = c * d = N` and `a + b = c + d + 1`.***
 
 ## The solution
 
+First we find all the factors of `N` (well the ones for where `N=a*b` and `a<b`)
+
+We then store the sum of the factors in a hash (as the keys), we also store the sum of the factors + 1 in the hash {using `++` so what is stored is the count of these numbers}.
+
+So if we have the condition `a+b == c+d+1` is equivalent to seeing which keys in the hash have a value greater than 1. In which case we have our value. For the problem we don't need this value - just whether there is a value. So our function comes down to this.
+
 ```perl
 sub stealthy_number {
   my($n,%c) = shift;
-- 
cgit 


From 6a1bfd09b0b9869dfeba6f1a9d183d3c884c984d Mon Sep 17 00:00:00 2001
From: drbaggy <js5@sanger.ac.uk>
Date: Tue, 14 Dec 2021 20:59:50 +0000
Subject: white space

---
 challenge-143/james-smith/perl/ch-2.pl | 13 ++++++-------
 1 file changed, 6 insertions(+), 7 deletions(-)

diff --git a/challenge-143/james-smith/perl/ch-2.pl b/challenge-143/james-smith/perl/ch-2.pl
index ddfe30d376..e3be4ea96c 100644
--- a/challenge-143/james-smith/perl/ch-2.pl
+++ b/challenge-143/james-smith/perl/ch-2.pl
@@ -8,15 +8,14 @@ use Test::More;
 use Benchmark qw(cmpthese timethis);
 use Data::Dumper qw(Dumper);
 
-my @ST = (4,12,24,36,40,60,72,84,112,120,144,180,220,240,
- 252,264,312,336,360,364,400,420,432,480,504,540,
- 544,600,612,660,672,684,760,792,840,864,900,924,
- 936,1012,1080,1092,1104,1120,1200,1260,1300,1320);
+my @ST = qw(
+   4   12   24   36   40   60   72   84  112  120  144  180
+ 220  240  252  264  312  336  360  364  400  420  432  480
+ 504  540  544  600  612  660  672  684  760  792  840  864
+ 900  924  936 1012 1080 1092 1104 1120 1200 1260 1300 1320
+);
 my @NST = map { $_ + 15 } @ST;
 my @TESTS = (
-  [ 36, 1 ],
-  [ 12, 1 ],
-  [  6, 0 ],
   ( map { [$_ => 1] } @ST  ),
   ( map { [$_ => 0] } @NST ),
 );
-- 
cgit 


From c12a27d57313357ebab130cfcff7ae9cf1c058d3 Mon Sep 17 00:00:00 2001
From: drbaggy <js5@sanger.ac.uk>
Date: Tue, 14 Dec 2021 21:11:13 +0000
Subject: add rpn tokenizer

---
 challenge-143/james-smith/perl/ch-1.pl | 59 ++++++++++++++++++++++++++++++++--
 1 file changed, 57 insertions(+), 2 deletions(-)

diff --git a/challenge-143/james-smith/perl/ch-1.pl b/challenge-143/james-smith/perl/ch-1.pl
index a4abfdeaab..2b0c32a29a 100644
--- a/challenge-143/james-smith/perl/ch-1.pl
+++ b/challenge-143/james-smith/perl/ch-1.pl
@@ -8,6 +8,22 @@ use Test::More;
 use Benchmark qw(cmpthese timethis);
 use Data::Dumper qw(Dumper);
 
+my(@s,@o);
+
+## List of operators - Entries in each array are:
+##  * precedence of operator
+##  * function to be run when finding operator in infix stream
+##  * function to be run when finding operator in rpn stream
+
+my %f;
+%f = (
+  '('=>[0,sub{push@s,'(' },                                                       ],
+  ')'=>[0,sub{push@o,$_ while($_=pop@s)ne'('},                                    ],
+  '*'=>[2,sub{push@o,pop@s while@s&&$f{$s[-1]}[0]>1;push@s,'*'},sub{$s[-2]*=pop@s}],
+  '+'=>[1,sub{push@o,pop@s while@s&&$f{$s[-1]}[0];  push@s,'+'},sub{$s[-2]+=pop@s}],
+  '-'=>[1,sub{push@o,pop@s while@s&&$f{$s[-1]}[0];  push@s,'-'},sub{$s[-2]-=pop@s}],
+);
+
 my @TESTS = (
   [ '10 + 20 - 5', 25 ],
   [ '(10 + 20 - 5) * 2', 50 ],
@@ -17,10 +33,14 @@ my @TESTS = (
   [ '(10 + 10) * (10 - 10) * (10 + 10) * (20 - (((20))))', 0 ],
 );
 
-is( evaluate($_->[0]), $_->[1] ) foreach @TESTS;
-is( eval(    $_->[0]), $_->[1] ) foreach @TESTS;
+is( evaluate(        $_->[0]), $_->[1] ) foreach @TESTS;
+is( evaluate_via_rpn($_->[0]), $_->[1] ) foreach @TESTS;
+is( evaluate_rpn_hsh($_->[0]), $_->[1] ) foreach @TESTS;
+is( eval(            $_->[0]), $_->[1] ) foreach @TESTS;
 cmpthese( 20000, {
   'evaluate' => sub { evaluate($_->[0]) for @TESTS },
+  'eval_rpn' => sub { evaluate_via_rpn($_->[0]) for @TESTS },
+  'eval_hsh' => sub { evaluate_rpn_hsh($_->[0]) for @TESTS },
   'eval'     => sub { eval(    $_->[0]) for @TESTS },
 });
 done_testing();
@@ -33,3 +53,38 @@ sub evaluate  {
   return $str;
 }
 
+sub evaluate_via_rpn  {
+  @s=();@o=();
+
+  for ( $_[0] =~ m{(-?\d+|[-+*()])}g ) {
+    if( m{\d} ) {
+      push @o, $_;
+    } elsif( $_ eq '(' ) {
+      push @s, $_;
+    } elsif( $_ eq ')' ) {
+      push @o, $_ while ($_ = pop @s) ne '(';
+    } else {
+      push @o, pop @s while @s && $f{$s[-1]}[0] && $f{$_}[0]<=$f{$s[-1]}[0];
+      push @s, $_;
+    }
+  }
+  push @o, reverse @s;
+
+  @s = ();
+  ## Now evaluate the RPN tree...
+    $_ eq '+' ? $s[-2] += pop @s
+  : $_ eq '-' ? $s[-2] -= pop @s
+  : $_ eq '*' ? $s[-2] *= pop @s
+  :             (push @s, $_) for @o;
+  $s[0];
+}
+
+## Code from hell... First for loop processes the infix into rpn
+##                   Second for loop processes the rpn stream
+sub evaluate_rpn_hsh  {
+  @o=(); @s=();
+  ($f{$_}) ? (&{$f{$_}[1]}) : (push@o,$_) for $_[0] =~ m{(-?\d+|[-+*()])}g;
+  ($f{$_}) ? (&{$f{$_}[2]}) : (push@s,$_) for @o, reverse splice @s,0;
+  $s[0];
+}
+
-- 
cgit 


From 9360aab24ec3cf381253e031275cd36cbdfddd51 Mon Sep 17 00:00:00 2001
From: James Smith <js5@sanger.ac.uk>
Date: Fri, 17 Dec 2021 21:39:52 +0000
Subject: Update README.md

---
 challenge-143/james-smith/README.md | 43 +++++++++++++++++++++++++++++++++++++
 1 file changed, 43 insertions(+)

diff --git a/challenge-143/james-smith/README.md b/challenge-143/james-smith/README.md
index fc9a9a857d..ff3e4cc4df 100644
--- a/challenge-143/james-smith/README.md
+++ b/challenge-143/james-smith/README.md
@@ -46,6 +46,49 @@ sub evaluate  {
 
 For small strings - this is about the same speed as `eval`, for larger strings not so, but in both cases it is "safer" as string `eval` of "tainted" input is a real security risk.
 
+## As a challenge infix->RPN converter than evaluate
+
+On the Perl Programming Facebook Group - the use or RPN was mentioned - and so the challenge lead to reimplementing this by converting the infix notation to Reverse Polish and then evaluating the RPN stack.
+
+Infix `(a+b)*c+d` would become `a b + c * d +` in Reverse Polish Notation. 
+
+To achieve this we set up a dispatch table - which stores methods for every operator we see in the string...
+And then when we see an operator in the stream (either infix or rpn) we use the appropriate function. This simplifies the code considerably...
+
+```perl
+my(@s,@o,%f);
+
+## THe 3 values are:
+##  precedence
+##  fn to apply when finding operator in infix stream
+##  fn to apply when finding operator in RPN stream
+ 
+%f = (
+  '('=>[0,sub{push@s,'(' },                                                       ],
+  ')'=>[0,sub{push@o,$_ while($_=pop@s)ne'('},                                    ],
+  '*'=>[2,sub{push@o,pop@s while@s&&$f{$s[-1]}[0]>1;push@s,'*'},sub{$s[-2]*=pop@s}],
+  '+'=>[1,sub{push@o,pop@s while@s&&$f{$s[-1]}[0];  push@s,'+'},sub{$s[-2]+=pop@s}],
+  '-'=>[1,sub{push@o,pop@s while@s&&$f{$s[-1]}[0];  push@s,'-'},sub{$s[-2]-=pop@s}],
+);
+
+## @o is output, @s is a stack..
+## Two loops - first line converts infix to rpn
+##             second evaluates the rpn string.
+sub evaluate_rpn  {
+  @o=(); @s=(); ## Clear output and stack.
+  ## If operator use function in f hash to update output/stack
+  ##    othewise it is a number and we push to output.
+  ($f{$_}) ? (&{$f{$_}[1]}) : (push@o,$_) for $_[0] =~ m{(-?\d+|[-+*()])}g;
+  ## If operator use function in f to update stack
+  ##    otherwise we push the value onto the stack
+  ## ** we use reverse splice to reverse the string AND clear the stack at the
+  ##    same time for the loop to work.
+  ($f{$_}) ? (&{$f{$_}[2]}) : (push@s,$_) for @o, reverse splice @s,0;
+  ## The result is the remaining value in the stack.
+  $s[0];
+}
+```
+
 # Challenge 2 - Stealthy Number
 
 ***You are given a positive number, `$n`.  Write a script to find out if the given number is Stealthy Number. A positive integer `N` is stealthy, if there exist positive integers `a`, `b`, `c`, `d` such that `a * b = c * d = N` and `a + b = c + d + 1`.***
-- 
cgit 


From dfd5cf296cab8343df70e757c449715036affa36 Mon Sep 17 00:00:00 2001
From: drbaggy <js5@sanger.ac.uk>
Date: Sat, 18 Dec 2021 07:42:08 +0000
Subject: add some comments

---
 challenge-143/james-smith/perl/ch-1.pl | 22 +++++++++++++---------
 1 file changed, 13 insertions(+), 9 deletions(-)

diff --git a/challenge-143/james-smith/perl/ch-1.pl b/challenge-143/james-smith/perl/ch-1.pl
index 2b0c32a29a..9581393720 100644
--- a/challenge-143/james-smith/perl/ch-1.pl
+++ b/challenge-143/james-smith/perl/ch-1.pl
@@ -31,6 +31,7 @@ my @TESTS = (
   [ '10 * 10 - 6 * 6 - 8 * 8', 0 ],
   [ '4 + 4 - 6 - 2', 0 ],
   [ '(10 + 10) * (10 - 10) * (10 + 10) * (20 - (((20))))', 0 ],
+  [ '(((((10+10)*10+10)*10+10)*10+10)*10+10)*10+10', 2111110 ],
 );
 
 is( evaluate(        $_->[0]), $_->[1] ) foreach @TESTS;
@@ -42,9 +43,13 @@ cmpthese( 20000, {
   'eval_rpn' => sub { evaluate_via_rpn($_->[0]) for @TESTS },
   'eval_hsh' => sub { evaluate_rpn_hsh($_->[0]) for @TESTS },
   'eval'     => sub { eval(    $_->[0]) for @TESTS },
+  'eval_x'   => sub { eval_x(  $_->[0]) for @TESTS },
 });
 done_testing();
 
+sub eval_x {
+  return eval( shift );
+}
 sub evaluate  {
   my $str = shift;
   1 while $str =~ s/\(\s*([^()]*?)\s*\)/       evaluate($1)             /e;
@@ -54,18 +59,17 @@ sub evaluate  {
 }
 
 sub evaluate_via_rpn  {
-  @s=();@o=();
-
+  @s=();@o=(); ## Stack/output
   for ( $_[0] =~ m{(-?\d+|[-+*()])}g ) {
-    if( m{\d} ) {
+    if( m{\d} ) { ## Number push to output
       push @o, $_;
-    } elsif( $_ eq '(' ) {
-      push @s, $_;
-    } elsif( $_ eq ')' ) {
-      push @o, $_ while ($_ = pop @s) ne '(';
-    } else {
-      push @o, pop @s while @s && $f{$s[-1]}[0] && $f{$_}[0]<=$f{$s[-1]}[0];
+    } elsif( $_ eq '(' ) { # open bracket add to stack
       push @s, $_;
+    } elsif( $_ eq ')' ) { # close bracket
+      push @o, $_ while ($_ = pop @s) ne '('; # push everything to output (in reverse order)
+    } else {                                  # until we reach the open bracket
+      push @o, pop @s while @s && $f{$s[-1]}[0] && $f{$_}[0]<=$f{$s[-1]}[0]; # pop off
+      push @s, $_;           # and push to stack if higher precidence and push value to stack
     }
   }
   push @o, reverse @s;
-- 
cgit 


From d7e3759bfc4e6d7194d75a014f0b9201fbe2c450 Mon Sep 17 00:00:00 2001
From: James Smith <js5@sanger.ac.uk>
Date: Sat, 18 Dec 2021 07:44:05 +0000
Subject: Update README.md

---
 challenge-141/james-smith/README.md | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/challenge-141/james-smith/README.md b/challenge-141/james-smith/README.md
index f61f2d0a52..d2595516fd 100644
--- a/challenge-141/james-smith/README.md
+++ b/challenge-141/james-smith/README.md
@@ -1,3 +1,5 @@
+[< Previous 140](https://github.com/drbaggy/perlweeklychallenge-club/tree/master/challenge-140/james-smith) |
+[Next 142 >](https://github.com/drbaggy/perlweeklychallenge-club/tree/master/challenge-142/james-smith)
 # Perl Weekly Challenge #141
 
 You can find more information about this weeks, and previous weeks challenges at:
-- 
cgit 


From 74ff1131dcee659872a8c780ab5e08ef965a0aaa Mon Sep 17 00:00:00 2001
From: James Smith <js5@sanger.ac.uk>
Date: Sat, 18 Dec 2021 07:44:36 +0000
Subject: Update README.md

---
 challenge-142/james-smith/README.md | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/challenge-142/james-smith/README.md b/challenge-142/james-smith/README.md
index 90c0a8816c..342c737974 100644
--- a/challenge-142/james-smith/README.md
+++ b/challenge-142/james-smith/README.md
@@ -1,3 +1,5 @@
+[< Previous 141](https://github.com/drbaggy/perlweeklychallenge-club/tree/master/challenge-141/james-smith) |
+[Next 143 >](https://github.com/drbaggy/perlweeklychallenge-club/tree/master/challenge-143/james-smith)
 # Perl Weekly Challenge #142
 
 You can find more information about this weeks, and previous weeks challenges at:
-- 
cgit 


From d8f09f025dbca165508634cfa23c6b2bf2b5419b Mon Sep 17 00:00:00 2001
From: James Smith <js5@sanger.ac.uk>
Date: Sat, 18 Dec 2021 07:44:59 +0000
Subject: Update README.md

---
 challenge-143/james-smith/README.md | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/challenge-143/james-smith/README.md b/challenge-143/james-smith/README.md
index ff3e4cc4df..81438e5d1f 100644
--- a/challenge-143/james-smith/README.md
+++ b/challenge-143/james-smith/README.md
@@ -1,3 +1,5 @@
+[< Previous 142](https://github.com/drbaggy/perlweeklychallenge-club/tree/master/challenge-142/james-smith) |
+[Next 144 >](https://github.com/drbaggy/perlweeklychallenge-club/tree/master/challenge-144/james-smith)
 # Perl Weekly Challenge #143
 
 You can find more information about this weeks, and previous weeks challenges at:
-- 
cgit 


From 817b2d237bf87bab2452f1608c319425b5371f1a Mon Sep 17 00:00:00 2001
From: James Smith <js5@sanger.ac.uk>
Date: Sat, 18 Dec 2021 07:46:44 +0000
Subject: Update blog.txt

---
 challenge-143/james-smith/blog.txt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/challenge-143/james-smith/blog.txt b/challenge-143/james-smith/blog.txt
index efff1b655b..4b908804ee 100644
--- a/challenge-143/james-smith/blog.txt
+++ b/challenge-143/james-smith/blog.txt
@@ -1 +1 @@
-https://github.com/drbaggy/perlweeklychallenge-club/new/master/challenge-143/james-smith
+https://github.com/drbaggy/perlweeklychallenge-club/tree/master/challenge-143/james-smith
-- 
cgit 


From 90ddf7a7d3e3c5482bb12fdd24cca801c6936810 Mon Sep 17 00:00:00 2001
From: James Smith <js5@sanger.ac.uk>
Date: Sat, 18 Dec 2021 07:47:18 +0000
Subject: Create blog.txt

---
 challenge-141/james-smith/blog.txt | 1 +
 1 file changed, 1 insertion(+)
 create mode 100644 challenge-141/james-smith/blog.txt

diff --git a/challenge-141/james-smith/blog.txt b/challenge-141/james-smith/blog.txt
new file mode 100644
index 0000000000..fcbd6d2085
--- /dev/null
+++ b/challenge-141/james-smith/blog.txt
@@ -0,0 +1 @@
+https://github.com/drbaggy/perlweeklychallenge-club/tree/master/challenge-141/james-smith
-- 
cgit