From 658e60b76deb452bf572385355917a0c46c19853 Mon Sep 17 00:00:00 2001 From: dcw Date: Sun, 19 Jun 2022 21:19:30 +0100 Subject: oops! found a serious error in my PrimeFactors() function last week.. fixed --- challenge-168/duncan-c-white/perl/PrimeFactors.pm | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/challenge-168/duncan-c-white/perl/PrimeFactors.pm b/challenge-168/duncan-c-white/perl/PrimeFactors.pm index 5ec2210764..95c5043d15 100644 --- a/challenge-168/duncan-c-white/perl/PrimeFactors.pm +++ b/challenge-168/duncan-c-white/perl/PrimeFactors.pm @@ -40,7 +40,7 @@ fun prime_factors( $n ) { die "prime_factors: n ($n) must be >1\n" if $n<=1; my @result; - my $lim = int(sqrt($n)); + my $lim = $n; my $orign = $n; foreach my $f (2..$lim) { @@ -50,8 +50,6 @@ fun prime_factors( $n ) { say "pf($orign): n=$n, adding $f to result" if $debug; push @result, $f; - my $other = $orign / $f; - push @result, $other if isprime($other) && $other != $f; $n /= $f; say "pf($orign): n /= $f (so n=$n now)" if $debug; } -- cgit