From b9798d4f8d8d14c5230c442253ad52e6994da391 Mon Sep 17 00:00:00 2001 From: Niels van Dijke Date: Mon, 22 May 2023 21:42:43 +0000 Subject: Some comments --- challenge-218/perlboy1967/perl/ch1.pl | 3 +++ challenge-218/perlboy1967/perl/ch2.pl | 3 ++- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/challenge-218/perlboy1967/perl/ch1.pl b/challenge-218/perlboy1967/perl/ch1.pl index 79ef7e0701..48bbc2aa76 100755 --- a/challenge-218/perlboy1967/perl/ch1.pl +++ b/challenge-218/perlboy1967/perl/ch1.pl @@ -27,12 +27,15 @@ use Test::More; sub maxProduct (@) { my (@n,@p); + # Find negative and positive factors for (@_) { $_ < 0 ? push(@n,$_) : $_ > 0 ? push(@p,$_) : 0; } + # If we have an odd number of negative factors, + # ditch the one closest to zero @n = sort {$a <=> $b} @n; pop @n if (@n % 2); diff --git a/challenge-218/perlboy1967/perl/ch2.pl b/challenge-218/perlboy1967/perl/ch2.pl index 9eaefc1b60..757630f319 100755 --- a/challenge-218/perlboy1967/perl/ch2.pl +++ b/challenge-218/perlboy1967/perl/ch2.pl @@ -40,7 +40,8 @@ sub matrixScore (\@) { for my $c (1 .. $nC) { my $ones = grep { $ar->[$_][$c] == 1 } (0 .. $nR); - # Flip bits in column C if number of '1's ir smaller than rows + + # Flip bits in column C if number of '1's is smaller than # of rows map { $ar->[$_][$c] = ++$$ar[$_][$c] % 2 } (0 .. $nR) if ($ones < $nR); } -- cgit