From 5308a28435efdeb6f5fecf14914eed6394600112 Mon Sep 17 00:00:00 2001
From: Thierry Berger <contact@thierryberger.com>
Date: Sun, 23 Jun 2024 23:01:55 +0200
Subject: fix: less invasive `solve_character_collision_impulses` function
 (#652)

* fix: less invasive `solve_character_collision_impulses` function

Taking ownership of the elements is not necessary.

It also conveys the information that elements are only read.

* Add Changelog
---
 src/control/character_controller.rs | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

(limited to 'src/control')

diff --git a/src/control/character_controller.rs b/src/control/character_controller.rs
index 2332bc3..230b1eb 100644
--- a/src/control/character_controller.rs
+++ b/src/control/character_controller.rs
@@ -788,7 +788,7 @@ impl KinematicCharacterController {
     /// impulses to the rigid-bodies surrounding the character shape at the time of the collisions.
     /// Note that the impulse calculation is only approximate as it is not based on a global
     /// constraints resolution scheme.
-    pub fn solve_character_collision_impulses(
+    pub fn solve_character_collision_impulses<'a>(
         &self,
         dt: Real,
         bodies: &mut RigidBodySet,
@@ -796,7 +796,7 @@ impl KinematicCharacterController {
         queries: &QueryPipeline,
         character_shape: &dyn Shape,
         character_mass: Real,
-        collisions: impl IntoIterator<Item = CharacterCollision>,
+        collisions: impl IntoIterator<Item = &'a CharacterCollision>,
         filter: QueryFilter,
     ) {
         for collision in collisions {
@@ -807,7 +807,7 @@ impl KinematicCharacterController {
                 queries,
                 character_shape,
                 character_mass,
-                &collision,
+                collision,
                 filter,
             );
         }
-- 
cgit