From 94993901cdb75fad7b68080eaa0e9b546810a107 Mon Sep 17 00:00:00 2001 From: Terence Date: Tue, 1 Jun 2021 20:41:38 -0400 Subject: wip --- src/dynamics/solver/velocity_constraint.rs | 8 +++- src/dynamics/solver/velocity_constraint_element.rs | 8 +++- .../solver/velocity_ground_constraint_element.rs | 7 +++- src/utils.rs | 43 ++++++++++++++++++++++ 4 files changed, 63 insertions(+), 3 deletions(-) (limited to 'src') diff --git a/src/dynamics/solver/velocity_constraint.rs b/src/dynamics/solver/velocity_constraint.rs index e15f2d8..90c574c 100644 --- a/src/dynamics/solver/velocity_constraint.rs +++ b/src/dynamics/solver/velocity_constraint.rs @@ -385,7 +385,13 @@ where let relative_linvel = linvel1 - linvel2; let mut tangent_relative_linvel = relative_linvel - force_dir1 * (force_dir1.dot(&relative_linvel)); - let tangent_linvel_norm = tangent_relative_linvel.normalize_mut(); + + let tangent_linvel_norm = { + let _disable_fe_except = + crate::utils::DisableFloatingPointExceptionsFlags::disable_floating_point_exceptions(); + tangent_relative_linvel.normalize_mut() + }; + let threshold: N::Element = na::convert(1.0e-4); let use_fallback = tangent_linvel_norm.simd_lt(N::splat(threshold)); let tangent_fallback = force_dir1.orthonormal_vector(); diff --git a/src/dynamics/solver/velocity_constraint_element.rs b/src/dynamics/solver/velocity_constraint_element.rs index 1324c35..d1ad6ac 100644 --- a/src/dynamics/solver/velocity_constraint_element.rs +++ b/src/dynamics/solver/velocity_constraint_element.rs @@ -99,7 +99,13 @@ impl VelocityConstraintTangentPart { self.impulse[0] - self.r[0] * dimpulse_0, self.impulse[1] - self.r[1] * dimpulse_1, ); - let new_impulse = new_impulse.simd_cap_magnitude(limit); + let new_impulse = { + let _disable_fe_except = + crate::utils::DisableFloatingPointExceptionsFlags:: + disable_floating_point_exceptions(); + new_impulse.simd_cap_magnitude(limit) + }; + let dlambda = new_impulse - self.impulse; self.impulse = new_impulse; diff --git a/src/dynamics/solver/velocity_ground_constraint_element.rs b/src/dynamics/solver/velocity_ground_constraint_element.rs index 8bcdc82..c4c6393 100644 --- a/src/dynamics/solver/velocity_ground_constraint_element.rs +++ b/src/dynamics/solver/velocity_ground_constraint_element.rs @@ -78,7 +78,12 @@ impl VelocityGroundConstraintTangentPart { self.impulse[0] - self.r[0] * dimpulse_0, self.impulse[1] - self.r[1] * dimpulse_1, ); - let new_impulse = new_impulse.simd_cap_magnitude(limit); + let new_impulse = { + let _disable_fe_except = + crate::utils::DisableFloatingPointExceptionsFlags:: + disable_floating_point_exceptions(); + new_impulse.simd_cap_magnitude(limit) + }; let dlambda = new_impulse - self.impulse; self.impulse = new_impulse; diff --git a/src/utils.rs b/src/utils.rs index c1eb31d..4ea2339 100644 --- a/src/utils.rs +++ b/src/utils.rs @@ -4,6 +4,7 @@ use na::{Matrix3, Point2, Point3, Scalar, SimdRealField, Vector2, Vector3}; use num::Zero; use simba::simd::SimdValue; use std::ops::IndexMut; +use std::os::raw::c_int; use parry::utils::SdpMatrix3; use { @@ -670,6 +671,48 @@ impl Drop for FlushToZeroDenormalsAreZeroFlags { } } +// This is an RAII structure that disables floating point exceptions while +// it is alive, so that operations which generate NaNs and infinite values +// intentionally will not trip an exception when debugging problematic +// code that is generating NaNs and infinite values erroneously. +#[derive(Clone, Debug, PartialEq, Eq)] +pub(crate) struct DisableFloatingPointExceptionsFlags { + original_flags: c_int, +} + +#[cfg(feature = "avoid-fe-exceptions")] +extern "C" { + fn feenableexcept(flags: c_int); + fn fecleareexcept(flags: c_int); + fn fetestexcept(flags: c_int) -> c_int; + static FE_ALL_EXCEPT: c_int; +} + +impl DisableFloatingPointExceptionsFlags { + #[cfg(not(feature = "avoid-fe-exceptions"))] + pub fn disable_floating_point_exceptions() -> Self { + Self { original_flags: 0 } + } + + #[cfg(feature = "avoid-fe-exceptions")] + pub fn disable_floating_point_exceptions() -> Self { + unsafe { + let original_flags = fetestexcept(FE_ALL_EXCEPT); + fecleareexcept(FE_ALL_EXCEPT); + Self { original_flags } + } + } +} + +#[cfg(feature = "avoid-fe-exceptions")] +impl Drop for DisableFloatingPointExceptionsFlags { + fn drop(&mut self) { + unsafe { + feenableexcept(self.original_flags); + } + } +} + pub(crate) fn select_other(pair: (T, T), elt: T) -> T { if pair.0 == elt { pair.1 -- cgit