upgrade typescript, improve workflow, bunch of bug fixes and some other things

2 files changed, 58 insertions, 79 deletions

diff --git a/.github/workflows/checks.yml b/.github/workflows/checks.yml
new file mode 100644
index 0000000..ef643c8
--- /dev/null
+++ b/.github/workflows/checks.yml
@@ -0,0 +1,58 @@
+name: Checks
+
+on: [push, pull_request, workflow_dispatch]
+
+jobs:
+  test:
+    name: ESLint and Build
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout Repo
+        uses: actions/checkout@v2
+      - name: Setup Node.js
+        uses: actions/setup-node@v1
+        with:
+          node-version: 16.x
+      - name: Yarn Cache
+        uses: c-hive/gha-yarn-cache@v2
+      - name: Install Dependencies
+        run: yarn install --frozen-lockfile
+      - name: Create Fake Ignored files
+        run: |
+          cp src/config/example-options.ts src/config/options.ts
+          cp src/lib/badlinks.ts src/lib/badlinks-secret.ts
+      - name: ESLint
+        run: yarn lint
+      - name: Build
+        run: yarn build-tsc:no-emit
+
+  formatting:
+    name: Formatting
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout Repo
+        uses: actions/checkout@v2
+        with:
+          persist-credentials: false
+          fetch-depth: 0
+      - name: Setup Node.js
+        uses: actions/setup-node@v1
+        with:
+          node-version: 16.x
+      - name: Yarn Cache
+        uses: c-hive/gha-yarn-cache@v2
+      - name: Install Dependencies
+        run: yarn install --frozen-lockfile
+      - name: Configure Git
+        run: |
+          git config --local user.email "41898282+github-actions[bot]@users.noreply.github.com"
+          git config --local user.name "github-actions[bot]"
+      - name: Format and Commit
+        run: |
+          yarn format
+          git commit -am "Automatically format code" || true
+      - name: Push Changes
+        uses: NotEnoughUpdates/github-push-action@master
+        with:
+          github_token: ${{ secrets.GITHUB_TOKEN }}
+          branch: ${{ github.ref }}
diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml
deleted file mode 100644
index c958b6f..0000000
--- a/.github/workflows/lint.yml
+++ /dev/null
@@ -1,79 +0,0 @@
-name: lint
-
-on:
-  push:
-    branches: ['*']
-  pull_request:
-    branches: ['*']
-
-  workflow_dispatch:
-
-jobs:
-  Test:
-    runs-on: ubuntu-latest
-
-    steps:
-      - uses: actions/checkout@v2
-      - name: Use Node.js 16.x
-        uses: actions/setup-node@v1
-        with:
-          node-version: 16.x
-      - name: Get yarn cache directory path
-        id: yarn-cache-dir-path
-        run: echo "::set-output name=dir::$(yarn config get cacheFolder)"
-      - uses: actions/cache@v2
-        id: yarn-cache # use this to check for `cache-hit` (`steps.yarn-cache.outputs.cache-hit != 'true'`)
-        with:
-          path: ${{ steps.yarn-cache-dir-path.outputs.dir }}
-          key: ${{ runner.os }}-yarn-${{ hashFiles('**/yarn.lock') }}
-          restore-keys: |
-            ${{ runner.os }}-yarn-
-      - name: Install dependencies
-        run: yarn
-      - name: Fix config
-        run: cp src/config/example-options.ts src/config/options.ts
-      - name: Fix badlinks-secret.json
-        run: cp src/lib/badlinks.ts src/lib/badlinks-secret.ts
-      - name: ESLint
-        run: yarn lint
-      - name: Test Build
-        run: yarn build-tsc
-
-  Check-Formatting:
-    runs-on: ubuntu-latest
-    name: Check formatting
-
-    steps:
-      - uses: actions/checkout@v2
-        with:
-          persist-credentials: false
-          fetch-depth: 0
-      - name: Use Node.js 16.x
-        uses: actions/setup-node@v1
-        with:
-          node-version: 16.x
-      - name: Get yarn cache directory path
-        id: yarn-cache-dir-path
-        run: echo "::set-output name=dir::$(yarn config get cacheFolder)"
-      - uses: actions/cache@v2
-        id: yarn-cache # use this to check for `cache-hit` (`steps.yarn-cache.outputs.cache-hit != 'true'`)
-        with:
-          path: ${{ steps.yarn-cache-dir-path.outputs.dir }}
-          key: ${{ runner.os }}-yarn-${{ hashFiles('**/yarn.lock') }}
-          restore-keys: |
-            ${{ runner.os }}-yarn-
-      - name: Install dependencies
-        run: yarn
-      - name: Configure git
-        run: |
-          git config --local user.email "41898282+github-actions[bot]@users.noreply.github.com"
-          git config --local user.name "github-actions[bot]"
-      - name: Format and commit code if needed
-        run: |
-          yarn format
-          git commit -am "Automatically format code" || true
-      - name: Push changes
-        uses: NotEnoughUpdates/github-push-action@master
-        with:
-          github_token: ${{ secrets.GITHUB_TOKEN }}
-          branch: ${{ github.ref }}