From bb71a49c886fc0bd0377be246f72d2d672de4a61 Mon Sep 17 00:00:00 2001 From: Benjamin Jackson <38561765+benjymansy123@users.noreply.github.com> Date: Thu, 16 Jun 2022 13:08:58 -0400 Subject: Fix steps numbering and clarify SQL naming convention. (#728) --- docs/how-to-create-a-db-pr.md | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/docs/how-to-create-a-db-pr.md b/docs/how-to-create-a-db-pr.md index 82729d1..bbf4a44 100644 --- a/docs/how-to-create-a-db-pr.md +++ b/docs/how-to-create-a-db-pr.md @@ -39,7 +39,7 @@ As a result, your fork's `master` branch should say: ![AzerothCore fork updated](http://www.azerothcore.org/wiki/assets/images/pr-tutorial/update-fork-2.png) -### 1. Create a new branch +### 2. Create a new branch Make sure you have the `master` branch currently selected, click on the branches dropdown and create a new branch. @@ -52,7 +52,7 @@ You should see a message like **Create branch my-new-branch-123 from master**. After you create the new branch, make sure you **keep that one selected**. -### 1. Navigate to the pending_db_world folder +### 3. Navigate to the pending_db_world folder You now need to navigate inside the `data/sql/updates/pending_db_world` folder of your fork. @@ -62,7 +62,7 @@ You can either do it manually by clicking on the `data` folder, then `sql`, `upd **https://github.com/YourUsername/azerothcore-wotlk/tree/my-new-branch-123/data/sql/updates/pending_db_world** -### 1. Create and commit a new file +### 4. Create and commit a new file Back on GitHub, from the `pending_db_world` folder, click **Add file** and then **Create new file**: @@ -70,7 +70,7 @@ Back on GitHub, from the `pending_db_world` folder, click **Add file** and then Now you need to: -- Give the file a name. +- Give the file any name with the file extension `.sql`. - Add a new line, then add your own SQL code below and then add a new empty line at the end of the file. ![AzerothCore new SQL file example](http://www.azerothcore.org/wiki/assets/images/pr-tutorial/web-create-new-file-2.png) @@ -85,7 +85,7 @@ Now scroll down the page, you'll need to: ![AzerothCore create new commit](http://www.azerothcore.org/wiki/assets/images/pr-tutorial/web-create-commit.png) -### 1. Open the PR +### 5. Open the PR Go back to the [main AzerothCore repository](https://github.com/azerothcore/azerothcore-wotlk), you will notice that GitHub is smart enough to realize that you are about to open a PR -- cgit