From 92b70452e18302ef3ea339b94505e44eebf2c4ba Mon Sep 17 00:00:00 2001 From: Kitzunu <24550914+Kitzunu@users.noreply.github.com> Date: Tue, 21 Feb 2023 22:12:31 +0100 Subject: Update reserved_name.md --- docs/reserved_name.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'docs') diff --git a/docs/reserved_name.md b/docs/reserved_name.md index 66303fe..08a957d 100644 --- a/docs/reserved_name.md +++ b/docs/reserved_name.md @@ -16,4 +16,4 @@ ### name -`field-no-description|1` +Name to be reserevd -- cgit From 934846c109c88c9bf4c60c21ea29933bb022e56f Mon Sep 17 00:00:00 2001 From: Nariman Date: Fri, 24 Feb 2023 22:51:56 +0000 Subject: ac-dashboard-core-install: Fix conf file section (#871) The current worldserver and authserver fails to load if you don't have the worldserver.conf and authserver.conf. The ./acore run-{world,auth}server commands also gets stuck in an infinite loop and bails (nice check!) due to worldserver and authserver returning a non-zero exit value. This was required to make this work under Ubuntu on WSL2 running on Windows 11. --- docs/ac-dashboard-core-installation.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'docs') diff --git a/docs/ac-dashboard-core-installation.md b/docs/ac-dashboard-core-installation.md index cb9089c..0b4c080 100644 --- a/docs/ac-dashboard-core-installation.md +++ b/docs/ac-dashboard-core-installation.md @@ -79,9 +79,9 @@ Get the latest client data: ./acore.sh client-data ``` -### Server config files (optional) +### Server config files -create these 2 files if you want to change the default configurations of the server +create these 2 files. They contain the default configuration for the worldserver and authserver, if you don't wish to modify simply copying them is enough. #### Linux and Mac -- cgit From 5fad0027400b66e72010567098cae4d011eda9c0 Mon Sep 17 00:00:00 2001 From: Nariman Date: Sat, 25 Feb 2023 15:28:52 +0000 Subject: macos-core-installation.md: Fix paths for brew packages (#874) Also streamline the usage of nproc in the commands --- docs/macos-core-installation.md | 20 ++++++-------------- 1 file changed, 6 insertions(+), 14 deletions(-) (limited to 'docs') diff --git a/docs/macos-core-installation.md b/docs/macos-core-installation.md index db1e49d..eb639a4 100644 --- a/docs/macos-core-installation.md +++ b/docs/macos-core-installation.md @@ -64,26 +64,18 @@ cmake ../ \ -DCMAKE_INSTALL_PREFIX=$HOME/azeroth-server/ \ -DTOOLS_BUILD=all \ -DSCRIPTS=static \ --DMYSQL_ADD_INCLUDE_PATH=/usr/local/include \ --DMYSQL_LIBRARY=/usr/local/lib/libmysqlclient.dylib \ --DREADLINE_INCLUDE_DIR=/usr/local/opt/readline/include \ --DREADLINE_LIBRARY=/usr/local/opt/readline/lib/libreadline.dylib \ +-DMYSQL_ADD_INCLUDE_PATH=/opt/homebrew/include/mysql \ +-DMYSQL_LIBRARY=/opt/homebrew/lib/libmysqlclient.dylib \ +-DREADLINE_INCLUDE_DIR=/opt/homebrew/opt/readline/include \ +-DREADLINE_LIBRARY=/opt/homebrew/opt/readline/lib/libreadline.dylib \ -DOPENSSL_INCLUDE_DIR="$OPENSSL_ROOT_DIR/include" \ -DOPENSSL_SSL_LIBRARIES="$OPENSSL_ROOT_DIR/lib/libssl.dylib" \ -DOPENSSL_CRYPTO_LIBRARIES="$OPENSSL_ROOT_DIR/lib/libcrypto.dylib" ``` - -To know the amount of cores available. -You can use the following command - -```sh -nproc --all -``` - -Then, replacing `4` with the number of threads that you want to execute, type: +Then, to build and install: ```sh -make -j 4 +make -j `nproc` make install ``` -- cgit From 012645aa9e2d480882ddedfc12c42beaf419cfe8 Mon Sep 17 00:00:00 2001 From: Johaine <32821455+Johaine@users.noreply.github.com> Date: Sat, 25 Feb 2023 22:48:11 +0100 Subject: Explicitly exclude database name in queries (#875) Was noted in https://github.com/azerothcore/azerothcore-wotlk/pull/15201 Some people might not use the standard database names --- docs/sql-standards.md | 2 ++ 1 file changed, 2 insertions(+) (limited to 'docs') diff --git a/docs/sql-standards.md b/docs/sql-standards.md index 23823c5..388a17e 100644 --- a/docs/sql-standards.md +++ b/docs/sql-standards.md @@ -13,6 +13,8 @@ We always use backticks \` around table- and column names. \`creature_loot_templ We always use single quotes around string values ' ' but NEVER around an integer. +We never include the database name in queries. + ### INSERT & DELETE We always DELETE before an INSERT to ensure we always put fields in the query and that no errors occur. -- cgit From b58f87e50d316f4c50aa0fa37a485ab81014f2b7 Mon Sep 17 00:00:00 2001 From: neifion-00000000 <91289495+neifion-00000000@users.noreply.github.com> Date: Thu, 2 Mar 2023 03:00:50 -0600 Subject: add link to commands breakdown page (#878) * add link to commands breakdown page * Update command.md --- docs/command.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'docs') diff --git a/docs/command.md b/docs/command.md index 0958c80..fe8e507 100644 --- a/docs/command.md +++ b/docs/command.md @@ -22,7 +22,7 @@ Holds help and security information for commands. This table does NOT create new ### name -The name of the command. +The name of the command. See: [included commands](gm-commands.md) ### security -- cgit From 13a1aeafe718a1db4718a4d24c2db764262e49cb Mon Sep 17 00:00:00 2001 From: neifion-00000000 <91289495+neifion-00000000@users.noreply.github.com> Date: Thu, 2 Mar 2023 03:02:01 -0600 Subject: adds npc guid to wiki (#877) --- docs/gm-commands.md | 1 + 1 file changed, 1 insertion(+) (limited to 'docs') diff --git a/docs/gm-commands.md b/docs/gm-commands.md index 6dca5d7..305f78a 100644 --- a/docs/gm-commands.md +++ b/docs/gm-commands.md @@ -325,6 +325,7 @@ Note: Some commands are working only by selecting a player or a creature. These | npc delete | 3 | `.npc delete [#guid]` | Delete creature with guid #guid (or the selected if no guid is provided) | | npc follow stop | 2 | `.npc follow stop` | Selected creature (non pet) stop follow you. | | npc follow | 2 | `.npc follow start` | Selected creature start follow you until death/fight/etc. | +| npc guid | 1 | `.npc guid` | Intended to display database GUID of targeted creature. Currently displays GUID, faction, NPC flags, Entry ID, Model ID for selected creature. | | npc info | 1 | `.npc info` | Display a list of details for the selected creature. The list includes: - GUID, Faction, NPC flags, Entry ID, Model ID, - Level, - Health (current/maximum), - Field flags, dynamic flags, faction template, - Position information, - and the creature type, e.g. if the creature is a vendor. | | npc move | 3 | `.npc move [#creature_guid]` | Move the targeted creature spawn point to your coordinates. | | npc playemote | 3 | `.npc playemote #emoteid` | Make the selected creature emote with an emote of id #emoteid. | -- cgit From b71bed83ddcc00ca060323d2f5e6323280784715 Mon Sep 17 00:00:00 2001 From: Liam Date: Mon, 6 Mar 2023 20:07:45 +0800 Subject: Fix the file name error related to mapextractor, vmap4assembler and vmap4extractor executable files. In the current version, their correct file names should be map_extractor, vmap4_assembler and vmap4_extractor. (#879) Co-authored-by: lai.li --- docs/linux-server-setup.md | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) (limited to 'docs') diff --git a/docs/linux-server-setup.md b/docs/linux-server-setup.md index 632bbe6..2b1e84c 100644 --- a/docs/linux-server-setup.md +++ b/docs/linux-server-setup.md @@ -9,27 +9,27 @@ Go to your AzerothCore build directory (e.g. $HOME/build/bin/) and copy the following files to your World of Warcraft binaries directory. -* **mapextractor** +* **map_extractor** * **mmaps_generator** -* **vmap4assembler** -* **vmap4extractor** +* **vmap4_assembler** +* **vmap4_extractor** **DBC and Maps files** ``` cd -./mapextractor +./map_extractor ``` -**Visual Maps (aka vmaps) Note: If you stop vmap4extractor before finish you will need to delete the Buildings directory before start again.** +**Visual Maps (aka vmaps) Note: If you stop vmap4_extractor before finish you will need to delete the Buildings directory before start again.** You can also extract vmaps which will take quite a while depending on your machine (up to hours on ancient hardware). ``` cd -./vmap4extractor +./vmap4_extractor mkdir vmaps; -./vmap4assembler Buildings vmaps +./vmap4_assembler Buildings vmaps ``` When this is complete you will receive the following message which can be safely ignored. -- cgit From ff774a5f4092d7c78b6c7b3781840f2f759bcb35 Mon Sep 17 00:00:00 2001 From: avarishd <46330494+avarishd@users.noreply.github.com> Date: Wed, 15 Mar 2023 14:42:19 +0200 Subject: update (#880) --- docs/conditions.md | 8 ++++---- docs/playercreateinfo_skills.md | 2 +- docs/playercreateinfo_spell_custom.md | 4 ++-- docs/quest_template_addon.md | 2 +- docs/spell_area.md | 2 +- 5 files changed, 9 insertions(+), 9 deletions(-) (limited to 'docs') diff --git a/docs/conditions.md b/docs/conditions.md index 55a34b6..566cab2 100644 --- a/docs/conditions.md +++ b/docs/conditions.md @@ -697,7 +697,7 @@ data (see corresponding script source files for more info) CONDITION_CLASS
15 -Class mask from ChrClasses.dbc
+Class mask from ChrClasses.dbc
Add flags together for all classes where condition is true. Always 0 Always 0 @@ -705,7 +705,7 @@ Add flags together for all classes where condition is true. CONDITION_RACE 16 -Race mask from ChrRaces.dbc .
+Race mask from ChrRaces.dbc .
Add flags together for all races where condition is true. Always 0 Always 0 @@ -1347,13 +1347,13 @@ Note: it will show or hide spells in vehicle spell bar. \***CONDITION\_CLASS = 15** -- - ConditionValue1: class mask. Add flags together for all classes condition should be true for. See [ChrClasses.dbc](ChrClasses) +- - ConditionValue1: class mask. Add flags together for all classes condition should be true for. See [ChrClasses.dbc](chrclasses) - ConditionValue2: always 0 - ConditionValue3: always 0 \***CONDITION\_RACE = 16** -- - ConditionValue1: race mask. Add flags together for all races condition should be true for. See [ChrRaces.dbc](ChrRaces) +- - ConditionValue1: race mask. Add flags together for all races condition should be true for. See [ChrRaces.dbc](chrraces) - ConditionValue2: always 0 - ConditionValue3: always 0 diff --git a/docs/playercreateinfo_skills.md b/docs/playercreateinfo_skills.md index fd0a3c6..f71aa04 100644 --- a/docs/playercreateinfo_skills.md +++ b/docs/playercreateinfo_skills.md @@ -26,7 +26,7 @@ This table holds information on what skills newly created characters should star ### racemask -One or more character's race. See [ChrRaces.dbc](ChrRaces). +One or more character's race. See [ChrRaces.dbc](chrraces). ### classmask diff --git a/docs/playercreateinfo_spell_custom.md b/docs/playercreateinfo_spell_custom.md index 093447d..f7f1f6b 100644 --- a/docs/playercreateinfo_spell_custom.md +++ b/docs/playercreateinfo_spell_custom.md @@ -24,11 +24,11 @@ Please note you'll have to set PlayerStart.AllSpells to 1 in config, else this t ### racemask -One or more character's race. See [ChrRaces.dbc](ChrRaces). +One or more character's race. See [ChrRaces.dbc](chrraces). ### classmask -One or more character's class. See [ChrClasses.dbc](ChrClasses) +One or more character's class. See [ChrClasses.dbc](chrclasses) ### Spell diff --git a/docs/quest_template_addon.md b/docs/quest_template_addon.md index 98f0897..8e7853b 100644 --- a/docs/quest_template_addon.md +++ b/docs/quest_template_addon.md @@ -59,7 +59,7 @@ Maximum player level at which a character can get the quest. ### **AllowableClasses** Classes required to get the quest. 0 means the quest is available for all classes. -This field is a bitmask, you can combine class values. See [ChrClasses.dbc](ChrClasses) +This field is a bitmask, you can combine class values. See [ChrClasses.dbc](chrclasses) ### **SourceSpellID** diff --git a/docs/spell_area.md b/docs/spell_area.md index 965dcc5..a503656 100644 --- a/docs/spell_area.md +++ b/docs/spell_area.md @@ -62,7 +62,7 @@ The value has the following effect: ### racemask -This ID is automatically called from [ChrRaces.dbc](ChrRaces). The bitmask is entered here. +This ID is automatically called from [ChrRaces.dbc](chrraces). The bitmask is entered here. - 0, 1791 = All Races - 690 (2 + 16 + 32 + 128 + 512) = Horde Only -- cgit From 8f6be9b570ef752c3c5749796f923bfaa4102420 Mon Sep 17 00:00:00 2001 From: Kitzunu <24550914+Kitzunu@users.noreply.github.com> Date: Fri, 17 Mar 2023 12:46:33 +0100 Subject: Update sql-standards.md --- docs/sql-standards.md | 49 +++++++++++++++++++++++++++++++++++++------------ 1 file changed, 37 insertions(+), 12 deletions(-) (limited to 'docs') diff --git a/docs/sql-standards.md b/docs/sql-standards.md index 388a17e..7604cf7 100644 --- a/docs/sql-standards.md +++ b/docs/sql-standards.md @@ -205,12 +205,13 @@ We do not define the width of an integer when we create new columns. (Width is d TINYINT(M) -> TINYINT SMALLINT(M) -> SMALLINT INT(M) -> INT -MEDIUMINT(M) -> MEDIUMINT BIGINT(M) -> BIGINT BOOL -> Never used, synonym for TINYINT. 0 = false <>0 = true ``` +We never use MEDIUMINT. Use INT instead! + ### Float, Double, Decimal These data types cannot be UNSIGNED and therefore we use CHECK CONSTRAINTS instead. (UNSIGNED Float, Double, Decimal is deprecated in later versions of MySQL 8) @@ -219,17 +220,6 @@ These data types cannot be UNSIGNED and therefore we use CHECK CONSTRAINTS inste FLOAT UNSIGNED -> CHECK (`column`>=0) ``` -### Character Encoding - -We use UTF8MB4 where you would previously use UTF8 or UTF8MB3. (utf8 is an alias and utf8mb3 is deprecated in later versions of MySQL 8) - -``` -utf8 -> utf8mb4 -utf8mb3 -> utf8mb4 -``` - -To be able to support MariaDB alongside MySQL we are limited to using `utf8mb4_general_ci` as coallation. - ### Check Constraints You can see [here](https://github.com/Azerothcore/azerothcore-wotlk/blob/master/data/sql/base/db_auth/realmlist.sql) how check contraints are made. @@ -244,6 +234,41 @@ SELECT * FROM information_schema.CHECK_CONSTRAINTS; SELECT * FROM information_schema.TABLE_CONSTRAINTS; ``` +### Charset + +We always use `utf8mb4` as charset + +### Collation + +We always use `utf8mb4_unicode_ci` as collation + +### Engine + +We always use `InnoDB` as the engine + +### Row Format + +We always use `DEFAULT` as row format + +### Dummy script for table + +```sql + +DROP TABLE IF EXISTS `our_table_name`; +CREATE TABLE `our_table_name` ( + `aColumnName` INT UNSIGNED NOT NULL DEFAULT '69' COMMENT 'ColumnComment', + `aSecondName` VARCHAR(100) NOT NULL DEFAULT '', + PRIMARY KEY (`aColumnName`), + CONSTRAINT `our_table_name_chk_1` CHECK (`aColumnName` >= 0) +) +COMMENT = 'TableComment' +CHARSET = utf8mb4 +COLLATE = utf8mb4_unicode_ci +ENGINE = InnoDB +ROW_FORMAT = DEFAULT +; +``` + ## Note for SQL reviewer When we work with GUID's, make sure that we use as low entries as possible to fill out the gaps in the database. This can easily be done with tools like [Unused GUID Searcher](https://github.com/azerothcore/unused-guid-search). -- cgit