diff options
| author | Linnea Gräf <nea@nea.moe> | 2024-05-24 01:06:39 +0200 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2024-05-24 01:06:39 +0200 |
| commit | 284f294c8c40ae61214ec6d8378415a457ebac33 (patch) | |
| tree | 0a6e2495ac8ff85734f2b3c878775c7e7742abe1 | |
| parent | d5585f83808a68fcee6ed2786980fd9e7825fb0c (diff) | |
| download | skyhanni-284f294c8c40ae61214ec6d8378415a457ebac33.tar.gz skyhanni-284f294c8c40ae61214ec6d8378415a457ebac33.tar.bz2 skyhanni-284f294c8c40ae61214ec6d8378415a457ebac33.zip | |
Add PR review policy (#1870)
| -rw-r--r-- | pull_request_template.md | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/pull_request_template.md b/pull_request_template.md index f7bfe3c3f..2dd04bcec 100644 --- a/pull_request_template.md +++ b/pull_request_template.md @@ -1,5 +1,11 @@ <!-- remove all unused parts --> +## PR Reviews + +When your PR is marked as ready for review, some of our maintainers will look through your code to make sure everything is good to go. In order to do this, they may request some changes you will need to do, **or fix smaller stuff (like merge conflicts) for you**. If a maintainer has reviewed your PR, make sure to **pull any of their changes** into your local project before doing more work on your code. Having maintainers fix small stuff for you helps us speed up the process of merging your PR, so if some of your systems warrant further care, be sure to let us know (preferably with a code comment). + +Make sure to only mark your PR as "Ready to review" when it is. If you still want to do major changes, you can keep a draft PR open until then. + ## Dependencies - pr_number_or_link_here |