aboutsummaryrefslogtreecommitdiff
path: root/CONTRIBUTING.md
diff options
context:
space:
mode:
authorDavid Cole <40234707+DavidArthurCole@users.noreply.github.com>2024-09-26 03:56:44 -0400
committerGitHub <noreply@github.com>2024-09-26 09:56:44 +0200
commit092a29dd8b13c2b04b0b7c259446ab697201dd5e (patch)
treef3704e259d34bfccef083834cb9106578695a694 /CONTRIBUTING.md
parente90fd65559ef551b29de7d28f4fea3a46cc2a4e6 (diff)
downloadskyhanni-092a29dd8b13c2b04b0b7c259446ab697201dd5e.tar.gz
skyhanni-092a29dd8b13c2b04b0b7c259446ab697201dd5e.tar.bz2
skyhanni-092a29dd8b13c2b04b0b7c259446ab697201dd5e.zip
Backend: Dekekt (#2547)
Co-authored-by: Linnea Gräf <nea@nea.moe> Co-authored-by: hannibal2 <24389977+hannibal00212@users.noreply.github.com> Co-authored-by: Cal <cwolfson58@gmail.com>
Diffstat (limited to 'CONTRIBUTING.md')
-rw-r--r--CONTRIBUTING.md5
1 files changed, 5 insertions, 0 deletions
diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
index fc0f2d5c4..d68b88f9f 100644
--- a/CONTRIBUTING.md
+++ b/CONTRIBUTING.md
@@ -97,6 +97,11 @@ format like "- #821" to illustrate the dependency.
- Follow the [Hypixel Rules](https://hypixel.net/rules).
- Use the coding conventions for [Kotlin](https://kotlinlang.org/docs/coding-conventions.html)
and [Java](https://www.oracle.com/java/technologies/javase/codeconventions-contents.html).
+- **My build is failing due to `detekt`, what do I do?**
+ - `detekt` is our code quality tool. It checks for code smells and style issues.
+ - If you have a build failure stating `Analysis failed with ... weighted issues.`, you can check `versions/[target version]/build/reports/detekt/` for a comprehensive list of issues.
+ - **There are valid reasons to deviate from the norm**
+ - If you have such a case, either use `@Supress("rule_name")`, or re-build the `baseline.xml` file, using `./gradlew detektBaseline`.
- Do not copy features from other mods. Exceptions:
- Mods that are paid to use.
- Mods that have reached their end of life. (Rip SBA, Dulkir and Soopy).