From 73541f85a6c5f507124e7e7fb95244239c3f52b1 Mon Sep 17 00:00:00 2001 From: hannibal2 <24389977+hannibal00212@users.noreply.github.com> Date: Thu, 30 Nov 2023 11:55:02 +0100 Subject: code cleanup --- .../at/hannibal2/skyhanni/config/features/minion/MinionsConfig.java | 2 +- src/main/java/at/hannibal2/skyhanni/features/minion/MinionFeatures.kt | 2 +- src/main/java/at/hannibal2/skyhanni/features/minion/MinionXp.kt | 3 +++ 3 files changed, 5 insertions(+), 2 deletions(-) diff --git a/src/main/java/at/hannibal2/skyhanni/config/features/minion/MinionsConfig.java b/src/main/java/at/hannibal2/skyhanni/config/features/minion/MinionsConfig.java index 9fcc10341..4f089ce9d 100644 --- a/src/main/java/at/hannibal2/skyhanni/config/features/minion/MinionsConfig.java +++ b/src/main/java/at/hannibal2/skyhanni/config/features/minion/MinionsConfig.java @@ -36,7 +36,7 @@ public class MinionsConfig { public boolean hopperProfitDisplay = true; @Expose - @ConfigOption(name = "Show Xp", desc = "Shows how many Exp you will get") + @ConfigOption(name = "Show Xp", desc = "Shows how much skill experience you will get when picking up items from the minion storage.") @ConfigEditorBoolean @FeatureToggle public boolean xpDisplay = true; diff --git a/src/main/java/at/hannibal2/skyhanni/features/minion/MinionFeatures.kt b/src/main/java/at/hannibal2/skyhanni/features/minion/MinionFeatures.kt index a6101ceb8..bd1a5e468 100644 --- a/src/main/java/at/hannibal2/skyhanni/features/minion/MinionFeatures.kt +++ b/src/main/java/at/hannibal2/skyhanni/features/minion/MinionFeatures.kt @@ -135,7 +135,7 @@ class MinionFeatures { } } - MinionStorageOpenEvent(lastStorage, event.inventoryItems).postAndCatch()//TODO + MinionStorageOpenEvent(lastStorage, event.inventoryItems).postAndCatch() minionStorageInventoryOpen = true } diff --git a/src/main/java/at/hannibal2/skyhanni/features/minion/MinionXp.kt b/src/main/java/at/hannibal2/skyhanni/features/minion/MinionXp.kt index 80dd9d9aa..3b2108648 100644 --- a/src/main/java/at/hannibal2/skyhanni/features/minion/MinionXp.kt +++ b/src/main/java/at/hannibal2/skyhanni/features/minion/MinionXp.kt @@ -32,11 +32,14 @@ class MinionXp { val timestamp: SimpleTimeMark = SimpleTimeMark.now() } + // TODO move to some other spot. This can be used at other features as well private data class PrimitiveItemStack(val name: NEUInternalName, val stackSize: Int) private fun toPrimitiveItemStack(itemStack: ItemStack) = PrimitiveItemStack(itemStack.getInternalName(), itemStack.stackSize) + // TODO use upper case names, created a function to get type by lowercase name + // TODO maybe: rename to SkillType, move somewhere else enum class XpType { Farming, Mining, -- cgit