From c1149d3c1b0d1f47bc6b0c1c65a70e5174022025 Mon Sep 17 00:00:00 2001
From: Walker Selby <git@walkerselby.com>
Date: Sat, 28 Oct 2023 19:10:18 +0100
Subject: Deprecate string functions where InternalName should be used
 functions (#613)

Mark functions around item utils and neu items as deprecated. #613
---
 src/main/java/at/hannibal2/skyhanni/utils/ItemUtils.kt | 1 +
 src/main/java/at/hannibal2/skyhanni/utils/NEUItems.kt  | 2 ++
 2 files changed, 3 insertions(+)

diff --git a/src/main/java/at/hannibal2/skyhanni/utils/ItemUtils.kt b/src/main/java/at/hannibal2/skyhanni/utils/ItemUtils.kt
index f98a3a23a..d39587d4d 100644
--- a/src/main/java/at/hannibal2/skyhanni/utils/ItemUtils.kt
+++ b/src/main/java/at/hannibal2/skyhanni/utils/ItemUtils.kt
@@ -117,6 +117,7 @@ object ItemUtils {
     }
 
     // TODO remove
+    @Deprecated("Use NEUInternalName rather than String", ReplaceWith("getInternalName()"))
     fun ItemStack.getInternalName_old() = getInternalName().asString()
 
     fun ItemStack.getInternalName() = getInternalNameOrNull() ?: NEUInternalName.NONE
diff --git a/src/main/java/at/hannibal2/skyhanni/utils/NEUItems.kt b/src/main/java/at/hannibal2/skyhanni/utils/NEUItems.kt
index 641cd692e..3fa8a09ad 100644
--- a/src/main/java/at/hannibal2/skyhanni/utils/NEUItems.kt
+++ b/src/main/java/at/hannibal2/skyhanni/utils/NEUItems.kt
@@ -47,6 +47,7 @@ object NEUItems {
     }
 
     // TODO remove
+    @Deprecated("Use NEUInternalName rather than String", ReplaceWith("getInternalNameFromItemName()"))
     fun getRawInternalName(itemName: String): String {
         return getInternalNameFromItemName(itemName).asString()
     }
@@ -174,6 +175,7 @@ object NEUItems {
     fun getItemStackOrNull(internalName: String) = internalName.asInternalName().getItemStackOrNull()
 
     // TODO remove
+    @Deprecated("Use NEUInternalName rather than String", ReplaceWith("getItemStack()"))
     fun getItemStack(internalName: String): ItemStack =
         internalName.asInternalName().getItemStack()
 
-- 
cgit