From e41b7e4bd2526950625b0d72f6cf1af0fb7f2224 Mon Sep 17 00:00:00 2001 From: hannibal2 <24389977+hannibal002@users.noreply.github.com> Date: Sun, 26 May 2024 11:38:17 +0200 Subject: Fix: Small Memory Leak (#1890) Co-authored-by: hannibal2 <24389977+hannibal00212@users.noreply.github.com> --- .../hannibal2/skyhanni/features/slayer/HideMobNames.kt | 17 ++++++++++------- 1 file changed, 10 insertions(+), 7 deletions(-) (limited to 'src/main/java/at/hannibal2/skyhanni/features/slayer') diff --git a/src/main/java/at/hannibal2/skyhanni/features/slayer/HideMobNames.kt b/src/main/java/at/hannibal2/skyhanni/features/slayer/HideMobNames.kt index 28b03f597..c2534b02b 100644 --- a/src/main/java/at/hannibal2/skyhanni/features/slayer/HideMobNames.kt +++ b/src/main/java/at/hannibal2/skyhanni/features/slayer/HideMobNames.kt @@ -5,16 +5,18 @@ import at.hannibal2.skyhanni.events.LorenzWorldChangeEvent import at.hannibal2.skyhanni.events.SkyHanniRenderEntityEvent import at.hannibal2.skyhanni.utils.LorenzUtils import at.hannibal2.skyhanni.utils.StringUtils.matchMatcher +import at.hannibal2.skyhanni.utils.TimeLimitedCache import net.minecraft.entity.EntityLivingBase import net.minecraft.entity.item.EntityArmorStand import net.minecraftforge.fml.common.eventhandler.EventPriority import net.minecraftforge.fml.common.eventhandler.SubscribeEvent import java.util.regex.Pattern +import kotlin.time.Duration.Companion.minutes class HideMobNames { - private val lastMobName = mutableMapOf() - private val mobNamesHidden = mutableListOf() + private val lastMobName = TimeLimitedCache(2.minutes) + private val mobNamesHidden = mutableListOf() private val patterns = mutableListOf() init { @@ -56,19 +58,20 @@ class HideMobNames { if (!entity.hasCustomName()) return val name = entity.name - if (lastMobName.getOrDefault(entity, "abc") == name) { - if (entity in mobNamesHidden) { + val id = entity.entityId + if (lastMobName.getOrNull(id) == name) { + if (id in mobNamesHidden) { event.isCanceled = true } return } - lastMobName[entity] = name - mobNamesHidden.remove(entity) + lastMobName.put(id, name) + mobNamesHidden.remove(id) if (shouldNameBeHidden(name)) { event.isCanceled = true - mobNamesHidden.add(entity) + mobNamesHidden.add(id) } } -- cgit