From fdb79e487c3c02d3e30ce48cc2ec62dac27cbb7e Mon Sep 17 00:00:00 2001
From: hannibal2 <24389977+hannibal00212@users.noreply.github.com>
Date: Sat, 7 Oct 2023 20:27:25 +0200
Subject: fixed icon hide logic bug

---
 src/main/java/at/hannibal2/skyhanni/config/features/MiscConfig.java   | 2 +-
 .../skyhanni/features/misc/compacttablist/TabListRenderer.kt          | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

(limited to 'src/main/java/at/hannibal2/skyhanni')

diff --git a/src/main/java/at/hannibal2/skyhanni/config/features/MiscConfig.java b/src/main/java/at/hannibal2/skyhanni/config/features/MiscConfig.java
index fcdc3ef38..9eaa1ec7c 100644
--- a/src/main/java/at/hannibal2/skyhanni/config/features/MiscConfig.java
+++ b/src/main/java/at/hannibal2/skyhanni/config/features/MiscConfig.java
@@ -573,7 +573,7 @@ public class MiscConfig {
             public boolean reverseSort = false;
 
             @Expose
-            @ConfigOption(name = "Hide Player Icons", desc = "Hide the icons of player in the tab list.")
+            @ConfigOption(name = "Hide Player Icons", desc = "Hide the icons/skins of player in the tab list.")
             @ConfigEditorBoolean
             public boolean hidePlayerIcons = false;
 
diff --git a/src/main/java/at/hannibal2/skyhanni/features/misc/compacttablist/TabListRenderer.kt b/src/main/java/at/hannibal2/skyhanni/features/misc/compacttablist/TabListRenderer.kt
index b653bd472..d5cc7f875 100644
--- a/src/main/java/at/hannibal2/skyhanni/features/misc/compacttablist/TabListRenderer.kt
+++ b/src/main/java/at/hannibal2/skyhanni/features/misc/compacttablist/TabListRenderer.kt
@@ -105,8 +105,8 @@ object TabListRenderer {
             for (tabLine in column.lines) {
                 val savedX = middleX
 
-                val isEnabled = !config.advancedPlayerList.hidePlayerIcons && !AdvancedPlayerList.ignoreCustomTabList()
-                if (tabLine.type == TabStringType.PLAYER && isEnabled) {
+                val hideIcons = config.advancedPlayerList.hidePlayerIcons && !AdvancedPlayerList.ignoreCustomTabList()
+                if (tabLine.type == TabStringType.PLAYER && !hideIcons) {
                     val playerInfo = tabLine.getInfo()
                     if (playerInfo != null) {
                         minecraft.textureManager.bindTexture(playerInfo.locationSkin)
-- 
cgit