aboutsummaryrefslogtreecommitdiff
path: root/src/gradlecomp/java/com/amadornes/artifactural/gradle/ReflectionUtils.java
diff options
context:
space:
mode:
authorAaron Hill <aa1ronham@gmail.com>2019-04-25 16:44:20 -0400
committerAaron Hill <aa1ronham@gmail.com>2019-04-25 21:47:24 -0400
commit747c582804bdcd0409417fdd92f7a3042d80b6b5 (patch)
tree945e46af6d7359a987d31a30c162bc167e741407 /src/gradlecomp/java/com/amadornes/artifactural/gradle/ReflectionUtils.java
parent37d713bdb7459cdd44707b350fd12fd59517b415 (diff)
downloadArtifactural-747c582804bdcd0409417fdd92f7a3042d80b6b5.tar.gz
Artifactural-747c582804bdcd0409417fdd92f7a3042d80b6b5.tar.bz2
Artifactural-747c582804bdcd0409417fdd92f7a3042d80b6b5.zip
Add compatibility with Gradle 4.10 and above
This commits adds compatibility for Gradle 4.10 onward (tested on 4.10 and 5,4), while retainting compatibiliy with 4.9 Due to the ABI-incompatible changes in some internal gradle classes, we need to use bytecode manipulation to ensure that our built class files are compatible with both Gradle 4.9 and Gradle >= 4.10 Bytecode manipulation is performed at built time. A custom Gradle task is used to read in the compiled class files from disk, and write out a modified version to the final jar artifact. In order to make as few bytecode modifications as possible, this commit bumps the Gradle wrapper version to 4.10. This means that we're compiling against Gradle 4.10, and using bytecode manipulation to retain compatibility with 4.9. Doing the reverse (compiling against 4.9) would be significantly more difficult, as we would need to statically reference classes that exist in Gradle 4.10 but not 4.9 (specifically, RepositoryDescriptor) We perform two different bytecode transformations: 1. We modify the call to 'super()' in GradleRepositoryAdapter. In Gradle 4.10, the suepr constructor takes one argument, but in 4.9, it takes zero arguments. In order to allow GradleRepositoryAdapter to compile normally, we write a 'fake' call to 'super(null)', and replace with a call to 'super()'. 2. We delete the method 'getDescriptor' from GradleRepositoryAdapter. In Gradle 4.9, its return type does not exist, and will cause a NoClassDefFoundError when Gradle attempts to classload it via Class#getDeclaredMethods. However, it's necessary to include 'getDescriptor' so that GradleRepositoryAdapter (we need to override the abstract method in a parent class).
Diffstat (limited to 'src/gradlecomp/java/com/amadornes/artifactural/gradle/ReflectionUtils.java')
0 files changed, 0 insertions, 0 deletions