Various small, code inspection related changes

6 files changed, 14 insertions, 1 deletions

diff --git a/src/main/java/de/cowtipper/cowlection/data/DataHelper.java b/src/main/java/de/cowtipper/cowlection/data/DataHelper.java
index 95c2133..028fe62 100644
--- a/src/main/java/de/cowtipper/cowlection/data/DataHelper.java
+++ b/src/main/java/de/cowtipper/cowlection/data/DataHelper.java
@@ -38,6 +38,7 @@ public final class DataHelper {
     }
 
     // TODO replace with api request: https://github.com/HypixelDev/PublicAPI/blob/master/Documentation/misc/GameType.md
+    @SuppressWarnings("unused")
     public enum GameType {
         QUAKECRAFT("Quakecraft"),
         WALLS("Walls"),
@@ -126,7 +127,7 @@ public final class DataHelper {
     public static Map<String, String> getMinions() {
         // key = skin id, value = minion type and tier
         Map<String, String> minions = new HashMap<>();
-        // TODO currently Fishing VI + VII and Creeper V + VI each use the same skull texture (server-side) - thus can't be distinguished
+        // TODO currently Fishing VI + VII use the same skull texture (server-side) - thus can't be distinguished
         minions.put("2f93289a82bd2a06cbbe61b733cfdc1f1bd93c4340f7a90abd9bdda774109071", "Cobblestone I");
         minions.put("3fd87486dc94cb8cd04a3d7d06f191f027f38dad7b4ed34c6681fb4d08834c06", "Cobblestone II");
         minions.put("cc088ed6bb8763af4eb7d006e00fda7dc11d7681e97c983b7011c3e872f6aab9", "Cobblestone III");
diff --git a/src/main/java/de/cowtipper/cowlection/data/Friend.java b/src/main/java/de/cowtipper/cowlection/data/Friend.java
index 81d93d7..9ef368e 100644
--- a/src/main/java/de/cowtipper/cowlection/data/Friend.java
+++ b/src/main/java/de/cowtipper/cowlection/data/Friend.java
@@ -5,6 +5,7 @@ import java.util.UUID;
 
 public class Friend {
     public static final Friend FRIEND_NOT_FOUND = new Friend();
+    @SuppressWarnings("unused")
     private UUID id;
     private String name;
     private long lastChecked;
diff --git a/src/main/java/de/cowtipper/cowlection/data/HyApiKey.java b/src/main/java/de/cowtipper/cowlection/data/HyApiKey.java
index 96b391a..ca7152c 100644
--- a/src/main/java/de/cowtipper/cowlection/data/HyApiKey.java
+++ b/src/main/java/de/cowtipper/cowlection/data/HyApiKey.java
@@ -1,7 +1,9 @@
 package de.cowtipper.cowlection.data;
 
 public class HyApiKey {
+    @SuppressWarnings("unused")
     private boolean success;
+    @SuppressWarnings("unused")
     private String cause;
 
     /**
diff --git a/src/main/java/de/cowtipper/cowlection/data/HyPlayerData.java b/src/main/java/de/cowtipper/cowlection/data/HyPlayerData.java
index 22e1eaa..96c3325 100644
--- a/src/main/java/de/cowtipper/cowlection/data/HyPlayerData.java
+++ b/src/main/java/de/cowtipper/cowlection/data/HyPlayerData.java
@@ -2,6 +2,7 @@ package de.cowtipper.cowlection.data;
 
 import net.minecraft.util.EnumChatFormatting;
 
+@SuppressWarnings("unused")
 public class HyPlayerData {
     private String displayname;
     private String rank;
@@ -74,6 +75,9 @@ public class HyPlayerData {
                     return EnumChatFormatting.RED + "[ADMIN]";
                 case "YOUTUBER":
                     return EnumChatFormatting.RED + "[" + EnumChatFormatting.WHITE + "YOUTUBE" + EnumChatFormatting.RED + "]";
+                default:
+                    // unknown rank, fall-through
+                    break;
             }
         }
         if (rankPlusColor == null) {
diff --git a/src/main/java/de/cowtipper/cowlection/data/HySkyBlockStats.java b/src/main/java/de/cowtipper/cowlection/data/HySkyBlockStats.java
index b268406..7ebd894 100644
--- a/src/main/java/de/cowtipper/cowlection/data/HySkyBlockStats.java
+++ b/src/main/java/de/cowtipper/cowlection/data/HySkyBlockStats.java
@@ -16,6 +16,7 @@ import java.io.ByteArrayInputStream;
 import java.io.IOException;
 import java.util.*;
 
+@SuppressWarnings({"FieldCanBeLocal", "FieldMayBeFinal", "unused", "MismatchedQueryAndUpdateOfCollection"})
 public class HySkyBlockStats {
     private boolean success;
     private String cause;
diff --git a/src/main/java/de/cowtipper/cowlection/data/HyStalkingData.java b/src/main/java/de/cowtipper/cowlection/data/HyStalkingData.java
index 45f3344..14c2c4b 100644
--- a/src/main/java/de/cowtipper/cowlection/data/HyStalkingData.java
+++ b/src/main/java/de/cowtipper/cowlection/data/HyStalkingData.java
@@ -3,6 +3,7 @@ package de.cowtipper.cowlection.data;
 import de.cowtipper.cowlection.util.Utils;
 import org.apache.commons.lang3.StringUtils;
 
+@SuppressWarnings("unused")
 public class HyStalkingData {
     private boolean success;
     private String cause;
@@ -108,6 +109,9 @@ public class HyStalkingData {
                         return "Gold Mine";
                     case "mining_2":
                         return "Deep Caverns";
+                    default:
+                        // fall-through
+                        break;
                 }
             }
             return Utils.fancyCase(mode);