aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorD-Cysteine <54219287+D-Cysteine@users.noreply.github.com>2021-11-21 06:51:34 -0700
committerD-Cysteine <54219287+D-Cysteine@users.noreply.github.com>2021-11-21 06:51:34 -0700
commita4d6e33b06059629b3fb86465c9c8c146407fb82 (patch)
treeeca4e6c8a230d1fb3f036987ba2d2ddfd474c5e1
parent8231f6ccbb9e9b6d2d61e11e4fab7f0ee1a7a46c (diff)
downloadGT5-Unofficial-a4d6e33b06059629b3fb86465c9c8c146407fb82.tar.gz
GT5-Unofficial-a4d6e33b06059629b3fb86465c9c8c146407fb82.tar.bz2
GT5-Unofficial-a4d6e33b06059629b3fb86465c9c8c146407fb82.zip
Add comment about GTppRecipeHelper
-rw-r--r--src/main/java/gregtech/api/util/GT_Recipe.java15
1 files changed, 14 insertions, 1 deletions
diff --git a/src/main/java/gregtech/api/util/GT_Recipe.java b/src/main/java/gregtech/api/util/GT_Recipe.java
index d94d161f14..c0ea06af07 100644
--- a/src/main/java/gregtech/api/util/GT_Recipe.java
+++ b/src/main/java/gregtech/api/util/GT_Recipe.java
@@ -376,6 +376,19 @@ public class GT_Recipe implements Comparable<GT_Recipe> {
return isRecipeInputEqual(aDecreaseStacksizeBySuccess, false, aFluidInputs, aInputs);
}
+ /**
+ * Okay, did some code archeology to figure out what's going on here.
+ *
+ * <p>This variable was added in
+ * <a href=https://github.com/GTNewHorizons/GT5-Unofficial/commit/9959ab7443982a19ad329bca424ab515493432e9>this commit,</a>
+ * in order to fix the issues mentioned in
+ * <a href=https://github.com/GTNewHorizons/GT5-Unofficial/pull/183>the PR</a>.
+ *
+ * <p>It looks like it controls checking NBT. At this point, since we are still using universal
+ * fluid cells which store their fluids in NBT, it probably will not be safe to disable the NBT
+ * checks in the near future. Data sticks may be another case. Anyway, we probably can't get rid
+ * of this without some significant changes to clean up recipe inputs.
+ */
public static boolean GTppRecipeHelper;
/**
@@ -443,7 +456,7 @@ public class GT_Recipe implements Comparable<GT_Recipe> {
for (int i = 0; i < aInputs.length; i++) {
ItemStack providedItem = aInputs[i];
if (GT_OreDictUnificator.isInputStackEqual(providedItem, unifiedItemCost)) {
- if (GTppRecipeHelper) { // remove once the fix is out
+ if (GTppRecipeHelper) { // Please see JavaDoc on GTppRecipeHelper for why this is here.
if (GT_Utility.areStacksEqual(providedItem, Ic2Items.FluidCell.copy(), true) || GT_Utility.areStacksEqual(providedItem, ItemList.Tool_DataStick.get(1L), true) || GT_Utility.areStacksEqual(providedItem, ItemList.Tool_DataOrb.get(1L), true)) {
if (!GT_Utility.areStacksEqual(providedItem, recipeItemCost, false))
continue;