diff options
| author | Alexdoru <57050655+Alexdoru@users.noreply.github.com> | 2024-10-02 07:31:08 +0200 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2024-10-02 05:31:08 +0000 |
| commit | 3b9bd1188e932e6bb8041f7bb9afbf3ce75e26d3 (patch) | |
| tree | 107d9d2442891990ef1cdef1d8bb2df6bb96952a /src/main/java/galacticgreg/schematics | |
| parent | bfc7b2b07f72d0903a70791ff96f9c837ddd5ff0 (diff) | |
| download | GT5-Unofficial-3b9bd1188e932e6bb8041f7bb9afbf3ce75e26d3.tar.gz GT5-Unofficial-3b9bd1188e932e6bb8041f7bb9afbf3ce75e26d3.tar.bz2 GT5-Unofficial-3b9bd1188e932e6bb8041f7bb9afbf3ce75e26d3.zip | |
Cleanup the codebase (#3311)
Co-authored-by: boubou19 <miisterunknown@gmail.com>
Diffstat (limited to 'src/main/java/galacticgreg/schematics')
| -rw-r--r-- | src/main/java/galacticgreg/schematics/SpaceSchematicHandler.java | 6 | ||||
| -rw-r--r-- | src/main/java/galacticgreg/schematics/SpaceSchematicWrapper.java | 4 |
2 files changed, 5 insertions, 5 deletions
diff --git a/src/main/java/galacticgreg/schematics/SpaceSchematicHandler.java b/src/main/java/galacticgreg/schematics/SpaceSchematicHandler.java index 9282ebca06..575befaf0a 100644 --- a/src/main/java/galacticgreg/schematics/SpaceSchematicHandler.java +++ b/src/main/java/galacticgreg/schematics/SpaceSchematicHandler.java @@ -47,7 +47,7 @@ public class SpaceSchematicHandler { if (_mSpaceSchematics == null) return null; - if (_mSpaceSchematics.size() == 0) return null; + if (_mSpaceSchematics.isEmpty()) return null; if (_mSpaceSchematics.size() == 1) { tChoosenSchematic = _mSpaceSchematics.get(0); @@ -59,7 +59,7 @@ public class SpaceSchematicHandler { } } - if (tRandomIDs.size() > 0) { + if (!tRandomIDs.isEmpty()) { int tRnd = GalacticGreg.GalacticRandom.nextInt(tRandomIDs.size()); tChoosenSchematic = _mSpaceSchematics.get(tRandomIDs.get(tRnd)); } @@ -128,7 +128,7 @@ public class SpaceSchematicHandler { public boolean SaveSpaceStructure(SpaceSchematic pSchematic) { try { if (pSchematic.getName() - .length() < 1) return false; + .isEmpty()) return false; JAXBContext tJaxbCtx = JAXBContext.newInstance(SpaceSchematic.class); Marshaller jaxMarsh = tJaxbCtx.createMarshaller(); diff --git a/src/main/java/galacticgreg/schematics/SpaceSchematicWrapper.java b/src/main/java/galacticgreg/schematics/SpaceSchematicWrapper.java index 4addc5107d..06ffd079d2 100644 --- a/src/main/java/galacticgreg/schematics/SpaceSchematicWrapper.java +++ b/src/main/java/galacticgreg/schematics/SpaceSchematicWrapper.java @@ -22,7 +22,7 @@ import galacticgreg.schematics.SpaceSchematic.BaseStructureInfo; */ public class SpaceSchematicWrapper implements ISpaceObjectGenerator { - private SpaceSchematic _mSchematic; + private final SpaceSchematic _mSchematic; private Vec3 _mCenter = Vec3.createVectorHelper(0, 0, 0); private List<StructureInformation> _mFinalizedStructure; @@ -31,7 +31,7 @@ public class SpaceSchematicWrapper implements ISpaceObjectGenerator { } public boolean isCalculated() { - return _mFinalizedStructure != null && _mFinalizedStructure.size() > 0; + return _mFinalizedStructure != null && !_mFinalizedStructure.isEmpty(); } /** |