diff options
author | Léa Gris <lea.gris@noiraude.net> | 2022-08-09 04:41:27 +0200 |
---|---|---|
committer | GitHub <noreply@github.com> | 2022-08-09 03:41:27 +0100 |
commit | 18d72ee94c18a8b6e330c255bb6ca650e6220196 (patch) | |
tree | 4f482ca6b488c09267b99cb393b2b9733113f41e /src/main/java/gregtech/api/enums/GT_Values.java | |
parent | 3d26fefc4089fde7b26f8c95235737a89403e1c9 (diff) | |
download | GT5-Unofficial-18d72ee94c18a8b6e330c255bb6ca650e6220196.tar.gz GT5-Unofficial-18d72ee94c18a8b6e330c255bb6ca650e6220196.tar.bz2 GT5-Unofficial-18d72ee94c18a8b6e330c255bb6ca650e6220196.zip |
fix(warnings): remove broad wanings suppression (#1223)
* fix(warnings): remove broad wanings suppression
This shell script was applied to remove all instances of
`@SuppressWarnings("ALL")`:
```sh
grep -lr '@SuppressWarnings([[:space:]]*"ALL"[[:space:]]*)' src/ |
xargs -l1 \
sed -n -i.bak '/@SuppressWarnings([[:space:]]*"ALL"[[:space:]]*)/!p'
```
* nuke @SuppressWarnings("all") in GT_NEI_DefaultHandler
Case insensitive:
```sh
grep -lr '@SuppressWarnings([[:space:]]*"[Aa][Ll][Ll]"[[:space:]]*)' src/ |
xargs -l1 \
sed -n -i.bak '/@SuppressWarnings([[:space:]]*"[Aa][Ll][Ll]"[[:space:]]*)/!p'
find src -type f -name '*.bak' -delete
```
* fix(warnings): GT_NEI_DefaultHandler
* fix(warnings): GT_Mod
* fix(warnings): GT_Values
* fix(warnings): Materials
* fix(warnings): GT_BeeDefinition
* fix(warnings): GT_PostLoad
* fix(warnings): GT_Worldgenloader
* fix(warnings): GT_PreLoad
Diffstat (limited to 'src/main/java/gregtech/api/enums/GT_Values.java')
-rw-r--r-- | src/main/java/gregtech/api/enums/GT_Values.java | 19 |
1 files changed, 9 insertions, 10 deletions
diff --git a/src/main/java/gregtech/api/enums/GT_Values.java b/src/main/java/gregtech/api/enums/GT_Values.java index ea27be01ad..f830459996 100644 --- a/src/main/java/gregtech/api/enums/GT_Values.java +++ b/src/main/java/gregtech/api/enums/GT_Values.java @@ -23,7 +23,7 @@ import java.util.Set; * <p/> * Go to "Window > Preferences > Java > Editor > Content Assist > Favorites" to set static importable Constant Classes such as this one as AutoCompleteable. */ -@SuppressWarnings("ALL") +@SuppressWarnings("unused") // API Legitimately has unused fields and methods public class GT_Values { // unused: A, C, D, G, H, I, J, K, N, O, Q, R, S, T @@ -39,6 +39,7 @@ public class GT_Values { /** * The first 32 Bits */ + @SuppressWarnings("PointlessBitwiseExpression") // Nicer source layout this way public static final int[] B = new int[]{ 1 << 0, 1 << 1, 1 << 2, 1 << 3, 1 << 4, 1 << 5, @@ -102,8 +103,9 @@ public class GT_Values { //Macerator/Compressor/Furnace... and for cheap recipes any /** - * keeping Voltage*Amps < Integer.MAX_VALUE-7 for machines (and tier logic 4x EUt 2/ time) - * AMV[4]= max amps at tier 4 + * Array of Maximum Amperes at given Tier index + * <p>keeping Voltage*Amps < Integer.MAX_VALUE-7 for machines (and tier logic 4x EUt 2/ time)</p> + * <p>AMV[4]= max amps at tier 4</p> */ public static final long[] AatV = new long[]{ @@ -349,11 +351,13 @@ public class GT_Values { */ public static int oreveinAttempts; /** - * Control number of attempts to place a valid orevein. If a vein wasn't placed due to height restrictions, completely in the water, etc, another attempt is tried. + * Control number of attempts to place a valid ore vein. + * <p>If a vein wasn't placed due to height restrictions, + * completely in the water, etc, another attempt is tried.</p> */ public static int oreveinMaxPlacementAttempts; /** - * Whether or not to place small ores as placer ores for an orevein + * Whether to place small ores as placer ores for an orevein */ public static boolean oreveinPlacerOres; /** @@ -361,11 +365,6 @@ public class GT_Values { */ public static int oreveinPlacerOresMultiplier; /** - * How wide to look for oreveins that affect a requested chunk. Trying to use oreveins larger than this will not work correctly. Increasing the size will cause additional worldgenerator lag. - * Disabled for now, using 64 in Deep Dark, 32 elsewhere - */ - // public static int oreveinMaxSize; - /** * Not really Constants, but they set using the Config and therefore should be constant (those are for the Debug Mode) */ public static boolean D1 = false, D2 = false; |