Cleanup the codebase (#3311)

Co-authored-by: boubou19 <miisterunknown@gmail.com>

8 files changed, 9 insertions, 10 deletions

diff --git a/src/main/java/gregtech/api/enums/Element.java b/src/main/java/gregtech/api/enums/Element.java
index 0931663b0b..3eaacb01f4 100644
--- a/src/main/java/gregtech/api/enums/Element.java
+++ b/src/main/java/gregtech/api/enums/Element.java
@@ -287,7 +287,6 @@ public enum Element {
      * Links to every pure Material containing just this Element.
      */
     // bartworks.system.material.werkstoff_loaders.registration.BridgeMaterialsLoader reassigns it, so no final here
-    @SuppressWarnings("NonFinalFieldInEnum")
     public ArrayList<Materials> mLinkedMaterials = new ArrayList<>();
 
     /**
diff --git a/src/main/java/gregtech/api/enums/GTStones.java b/src/main/java/gregtech/api/enums/GTStones.java
index af14301a5d..2a9aeca409 100644
--- a/src/main/java/gregtech/api/enums/GTStones.java
+++ b/src/main/java/gregtech/api/enums/GTStones.java
@@ -387,7 +387,7 @@ public enum GTStones {
 
     public final StoneBuilder stone;
 
-    private GTStones(StoneBuilder stone) {
+    GTStones(StoneBuilder stone) {
         this.stone = stone;
     }
 
diff --git a/src/main/java/gregtech/api/enums/InventoryType.java b/src/main/java/gregtech/api/enums/InventoryType.java
index f8e3c47741..5092738174 100644
--- a/src/main/java/gregtech/api/enums/InventoryType.java
+++ b/src/main/java/gregtech/api/enums/InventoryType.java
@@ -3,5 +3,5 @@ package gregtech.api.enums;
 public enum InventoryType {
     Input,
     Output,
-    Both;
+    Both
 }
diff --git a/src/main/java/gregtech/api/enums/ItemList.java b/src/main/java/gregtech/api/enums/ItemList.java
index 52e3484156..540b8bf37d 100644
--- a/src/main/java/gregtech/api/enums/ItemList.java
+++ b/src/main/java/gregtech/api/enums/ItemList.java
@@ -2724,7 +2724,7 @@ public enum ItemList implements IItemContainer {
         StringBuilder tCamelCasedDisplayNameBuilder = new StringBuilder();
         final String[] tDisplayNameWords = aDisplayName.split("\\W");
         for (String tWord : tDisplayNameWords) {
-            if (tWord.length() > 0) tCamelCasedDisplayNameBuilder.append(
+            if (!tWord.isEmpty()) tCamelCasedDisplayNameBuilder.append(
                 tWord.substring(0, 1)
                     .toUpperCase(Locale.US));
             if (tWord.length() > 1) tCamelCasedDisplayNameBuilder.append(
diff --git a/src/main/java/gregtech/api/enums/Materials.java b/src/main/java/gregtech/api/enums/Materials.java
index 95463122f1..9a2c5b5125 100644
--- a/src/main/java/gregtech/api/enums/Materials.java
+++ b/src/main/java/gregtech/api/enums/Materials.java
@@ -2792,7 +2792,7 @@ public class Materials implements IColorModulationContainer, ISubTagContainer {
 
     public long getProtons() {
         if (mElement != null) return mElement.getProtons();
-        if (mMaterialList.size() == 0) return Element.Tc.getProtons();
+        if (mMaterialList.isEmpty()) return Element.Tc.getProtons();
         long rAmount = 0, tAmount = 0;
         for (MaterialStack tMaterial : mMaterialList) {
             tAmount += tMaterial.mAmount;
@@ -2803,7 +2803,7 @@ public class Materials implements IColorModulationContainer, ISubTagContainer {
 
     public long getNeutrons() {
         if (mElement != null) return mElement.getNeutrons();
-        if (mMaterialList.size() == 0) return Element.Tc.getNeutrons();
+        if (mMaterialList.isEmpty()) return Element.Tc.getNeutrons();
         long rAmount = 0, tAmount = 0;
         for (MaterialStack tMaterial : mMaterialList) {
             tAmount += tMaterial.mAmount;
@@ -2814,7 +2814,7 @@ public class Materials implements IColorModulationContainer, ISubTagContainer {
 
     public long getMass() {
         if (mElement != null) return mElement.getMass();
-        if (mMaterialList.size() == 0) return Element.Tc.getMass();
+        if (mMaterialList.isEmpty()) return Element.Tc.getMass();
         long rAmount = 0, tAmount = 0;
         for (MaterialStack tMaterial : mMaterialList) {
             tAmount += tMaterial.mAmount;
diff --git a/src/main/java/gregtech/api/enums/MetaTileEntityIDs.java b/src/main/java/gregtech/api/enums/MetaTileEntityIDs.java
index c3cbbb02cf..3cebf19b0f 100644
--- a/src/main/java/gregtech/api/enums/MetaTileEntityIDs.java
+++ b/src/main/java/gregtech/api/enums/MetaTileEntityIDs.java
@@ -1952,7 +1952,7 @@ public enum MetaTileEntityIDs {
 
     public final int ID;
 
-    private MetaTileEntityIDs(int ID) {
+    MetaTileEntityIDs(int ID) {
         this.ID = ID;
     }
 }
diff --git a/src/main/java/gregtech/api/enums/OreMixes.java b/src/main/java/gregtech/api/enums/OreMixes.java
index 8c9800ba00..034e73763e 100644
--- a/src/main/java/gregtech/api/enums/OreMixes.java
+++ b/src/main/java/gregtech/api/enums/OreMixes.java
@@ -1003,7 +1003,7 @@ public enum OreMixes {
 
     public final OreMixBuilder oreMixBuilder;
 
-    private OreMixes(OreMixBuilder oreMixBuilder) {
+    OreMixes(OreMixBuilder oreMixBuilder) {
         this.oreMixBuilder = oreMixBuilder;
     }
 
diff --git a/src/main/java/gregtech/api/enums/SmallOres.java b/src/main/java/gregtech/api/enums/SmallOres.java
index 3cd15b5f86..ec11c211c2 100644
--- a/src/main/java/gregtech/api/enums/SmallOres.java
+++ b/src/main/java/gregtech/api/enums/SmallOres.java
@@ -541,7 +541,7 @@ public enum SmallOres {
 
     public final SmallOreBuilder smallOreBuilder;
 
-    private SmallOres(gregtech.common.SmallOreBuilder smallOreBuilder) {
+    SmallOres(gregtech.common.SmallOreBuilder smallOreBuilder) {
         this.smallOreBuilder = smallOreBuilder;
     }