diff options
| author | chill <chill.gtnh@outlook.com> | 2023-05-28 11:22:32 +0200 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2023-05-28 11:22:32 +0200 |
| commit | 8b70580d87db7151da71caa71f89f08f05921e29 (patch) | |
| tree | 6c73785ab356950e8a9e34d13b1197ef6cd81446 /src/main/java/gregtech/api/enums | |
| parent | fecc8533c5d52cf9bee137687fdda280dab2e39a (diff) | |
| download | GT5-Unofficial-8b70580d87db7151da71caa71f89f08f05921e29.tar.gz GT5-Unofficial-8b70580d87db7151da71caa71f89f08f05921e29.tar.bz2 GT5-Unofficial-8b70580d87db7151da71caa71f89f08f05921e29.zip | |
make enum fields final where possible (#2029)
Non-final enum fields make a global mutable state, which should be used only
when necessary. Let's make the enum fields final where possible.
Diffstat (limited to 'src/main/java/gregtech/api/enums')
| -rw-r--r-- | src/main/java/gregtech/api/enums/Element.java | 2 | ||||
| -rw-r--r-- | src/main/java/gregtech/api/enums/OrePrefixes.java | 2 | ||||
| -rw-r--r-- | src/main/java/gregtech/api/enums/TC_Aspects.java | 2 | ||||
| -rw-r--r-- | src/main/java/gregtech/api/enums/Textures.java | 2 |
4 files changed, 5 insertions, 3 deletions
diff --git a/src/main/java/gregtech/api/enums/Element.java b/src/main/java/gregtech/api/enums/Element.java index b4bcb01a41..a769a94a4e 100644 --- a/src/main/java/gregtech/api/enums/Element.java +++ b/src/main/java/gregtech/api/enums/Element.java @@ -285,6 +285,8 @@ public enum Element { /** * Links to every pure Material containing just this Element. */ + // bartworks.system.material.werkstoff_loaders.registration.BridgeMaterialsLoader reassigns it, so no final here + @SuppressWarnings("NonFinalFieldInEnum") public ArrayList<Materials> mLinkedMaterials = new ArrayList<>(); /** diff --git a/src/main/java/gregtech/api/enums/OrePrefixes.java b/src/main/java/gregtech/api/enums/OrePrefixes.java index 79ca638bef..c029083a50 100644 --- a/src/main/java/gregtech/api/enums/OrePrefixes.java +++ b/src/main/java/gregtech/api/enums/OrePrefixes.java @@ -1007,7 +1007,7 @@ public enum OrePrefixes { public OrePrefixes mPrefixInto = this; public float mHeatDamage = 0.0F; // Negative for Frost Damage private final GT_HashSet<GT_ItemStack2> mContainsTestCache = new GT_HashSet<>(512, 0.5f); - public static List<OrePrefixes> mPreventableComponents = new LinkedList<>( + public static final List<OrePrefixes> mPreventableComponents = new LinkedList<>( Arrays.asList( OrePrefixes.gem, OrePrefixes.ingotHot, diff --git a/src/main/java/gregtech/api/enums/TC_Aspects.java b/src/main/java/gregtech/api/enums/TC_Aspects.java index 7d0ca56fbf..24d19b0b73 100644 --- a/src/main/java/gregtech/api/enums/TC_Aspects.java +++ b/src/main/java/gregtech/api/enums/TC_Aspects.java @@ -64,7 +64,7 @@ public enum TC_Aspects { */ public Object mAspect; - public int mValue; + public final int mValue; TC_Aspects(int aValue) { mValue = aValue; diff --git a/src/main/java/gregtech/api/enums/Textures.java b/src/main/java/gregtech/api/enums/Textures.java index d8271e86ed..a38a10ccce 100644 --- a/src/main/java/gregtech/api/enums/Textures.java +++ b/src/main/java/gregtech/api/enums/Textures.java @@ -1649,7 +1649,7 @@ public class Textures { * USE casingTexturePages[page] instead of CASING_BLOCKS since it is casingTexturePages[0] */ @Deprecated - public static ITexture[] CASING_BLOCKS = new ITexture[128]; // original variable still limited to 128 + public static final ITexture[] CASING_BLOCKS = new ITexture[128]; // original variable still limited to 128 public static ITexture[][] MACHINE_CASINGS = new ITexture[15][17]; /** |