Jabel, Generic injection and mostly automatic code cleanup (#1829)

* Enable Jabel&Generic injection, fix type error caused by this

* add missing <>

* Infer generic types automatically

* Parametrize cast types

* Use enhanced for loops

* Unnecessary boxing

* Unnecessary unboxing

* Use Objects.equals

* Explicit type can be replaced with `<>`

* Collapse identical catch blocks

* Add SafeVarargs where applicable

* Anonymous type can be replaced with lambda

* Use List.sort directly

* Lambda can be a method reference

* Statement lambda can be an expression lambda

* Use string switches

* Instanceof pattern matching

* Text block can be used

* Migrate to enhanced switch

* Java style array declarations

* Unnecessary toString()

* More unnecessary String conversions

* Unnecessary modifiers

* Unnecessary semicolons

* Fix duplicate conditions

* Extract common code from if branches

* Replace switches with ifs for 1-2 cases

* Inner class may be static

* Minor performance issues

* Replace string appending in loops with string builders

* Fix IntelliJ using the wrong empty list method

* Use Long.compare

* Generic arguments: getSubItems

* Generic arguments: getSubBlocks

* Raw types warnings

* Fix remaining missing generics

* Too weak variable type leads to unnecessary cast

* Redundant type casts

* Redundant array length check

* Redundant vararg arrays

* Manual min/max implementations

* A couple missed inspections

* Goodbye explosion power ternary ladder

* Apply spotless

* Get rid of the other two big ternary ladders

* Binary search explosion power

* Don't overcomplicate things

1 files changed, 3 insertions, 6 deletions

diff --git a/src/main/java/gregtech/api/metatileentity/BaseTileEntity.java b/src/main/java/gregtech/api/metatileentity/BaseTileEntity.java
index 238dc6ba30..3ef732b1c8 100644
--- a/src/main/java/gregtech/api/metatileentity/BaseTileEntity.java
+++ b/src/main/java/gregtech/api/metatileentity/BaseTileEntity.java
@@ -861,8 +861,7 @@ public abstract class BaseTileEntity extends TileEntity implements IHasWorldObje
         final ItemStackHandler inventoryHandler = getInventoryHandler();
         if (inventoryHandler == null) return;
 
-        if (!(this instanceof IInventory)) return;
-        final IInventory inv = (IInventory) this;
+        if (!(this instanceof IInventory inv)) return;
 
         final IConfigurationCircuitSupport ccs = getConfigurationCircuitSupport();
         if (ccs == null) return;
@@ -937,8 +936,7 @@ public abstract class BaseTileEntity extends TileEntity implements IHasWorldObje
         final IConfigurationCircuitSupport ccs = getConfigurationCircuitSupport();
         if (ccs == null) return;
 
-        if (!(this instanceof IInventory)) return;
-        final IInventory inv = (IInventory) this;
+        if (!(this instanceof IInventory inv)) return;
 
         final List<ItemStack> circuits = ccs.getConfigurationCircuits();
         uiContext.openClientWindow(
@@ -965,8 +963,7 @@ public abstract class BaseTileEntity extends TileEntity implements IHasWorldObje
         final IConfigurationCircuitSupport ccs = getConfigurationCircuitSupport();
         if (ccs == null) return;
 
-        if (!(this instanceof IInventory)) return;
-        final IInventory inv = (IInventory) this;
+        if (!(this instanceof IInventory inv)) return;
 
         GT_Values.NW.sendToServer(new GT_Packet_SetConfigurationCircuit(this, selected));
         // we will not do any validation on client side