Jabel, Generic injection and mostly automatic code cleanup (#1829)

* Enable Jabel&Generic injection, fix type error caused by this

* add missing <>

* Infer generic types automatically

* Parametrize cast types

* Use enhanced for loops

* Unnecessary boxing

* Unnecessary unboxing

* Use Objects.equals

* Explicit type can be replaced with `<>`

* Collapse identical catch blocks

* Add SafeVarargs where applicable

* Anonymous type can be replaced with lambda

* Use List.sort directly

* Lambda can be a method reference

* Statement lambda can be an expression lambda

* Use string switches

* Instanceof pattern matching

* Text block can be used

* Migrate to enhanced switch

* Java style array declarations

* Unnecessary toString()

* More unnecessary String conversions

* Unnecessary modifiers

* Unnecessary semicolons

* Fix duplicate conditions

* Extract common code from if branches

* Replace switches with ifs for 1-2 cases

* Inner class may be static

* Minor performance issues

* Replace string appending in loops with string builders

* Fix IntelliJ using the wrong empty list method

* Use Long.compare

* Generic arguments: getSubItems

* Generic arguments: getSubBlocks

* Raw types warnings

* Fix remaining missing generics

* Too weak variable type leads to unnecessary cast

* Redundant type casts

* Redundant array length check

* Redundant vararg arrays

* Manual min/max implementations

* A couple missed inspections

* Goodbye explosion power ternary ladder

* Apply spotless

* Get rid of the other two big ternary ladders

* Binary search explosion power

* Don't overcomplicate things

2 files changed, 39 insertions, 72 deletions

diff --git a/src/main/java/gregtech/common/tileentities/storage/GT_MetaTileEntity_DigitalChestBase.java b/src/main/java/gregtech/common/tileentities/storage/GT_MetaTileEntity_DigitalChestBase.java
index cee78c3fa4..ce6a5509bb 100644
--- a/src/main/java/gregtech/common/tileentities/storage/GT_MetaTileEntity_DigitalChestBase.java
+++ b/src/main/java/gregtech/common/tileentities/storage/GT_MetaTileEntity_DigitalChestBase.java
@@ -59,30 +59,19 @@ public abstract class GT_MetaTileEntity_DigitalChestBase extends GT_MetaTileEnti
     }
 
     protected static int commonSizeCompute(int tier) {
-        switch (tier) {
-            case 1:
-                return 4000000;
-            case 2:
-                return 8000000;
-            case 3:
-                return 16000000;
-            case 4:
-                return 32000000;
-            case 5:
-                return 64000000;
-            case 6:
-                return 128000000;
-            case 7:
-                return 256000000;
-            case 8:
-                return 512000000;
-            case 9:
-                return 1024000000;
-            case 10:
-                return 2147483640;
-            default:
-                return 0;
-        }
+        return switch (tier) {
+            case 1 -> 4000000;
+            case 2 -> 8000000;
+            case 3 -> 16000000;
+            case 4 -> 32000000;
+            case 5 -> 64000000;
+            case 6 -> 128000000;
+            case 7 -> 256000000;
+            case 8 -> 512000000;
+            case 9 -> 1024000000;
+            case 10 -> 2147483640;
+            default -> 0;
+        };
     }
 
     public GT_MetaTileEntity_DigitalChestBase(String aName, int aTier, String aDescription, ITexture[][][] aTextures) {
diff --git a/src/main/java/gregtech/common/tileentities/storage/GT_MetaTileEntity_DigitalTankBase.java b/src/main/java/gregtech/common/tileentities/storage/GT_MetaTileEntity_DigitalTankBase.java
index e374658871..93ee2b0c10 100644
--- a/src/main/java/gregtech/common/tileentities/storage/GT_MetaTileEntity_DigitalTankBase.java
+++ b/src/main/java/gregtech/common/tileentities/storage/GT_MetaTileEntity_DigitalTankBase.java
@@ -64,57 +64,35 @@ public abstract class GT_MetaTileEntity_DigitalTankBase extends GT_MetaTileEntit
     }
 
     protected static int commonSizeCompute(int tier) {
-        switch (tier) {
-            case 1:
-                return 4000000;
-            case 2:
-                return 8000000;
-            case 3:
-                return 16000000;
-            case 4:
-                return 32000000;
-            case 5:
-                return 64000000;
-            case 6:
-                return 128000000;
-            case 7:
-                return 256000000;
-            case 8:
-                return 512000000;
-            case 9:
-                return 1024000000;
-            case 10:
-                return 2147483640;
-            default:
-                return 0;
-        }
+        return switch (tier) {
+            case 1 -> 4000000;
+            case 2 -> 8000000;
+            case 3 -> 16000000;
+            case 4 -> 32000000;
+            case 5 -> 64000000;
+            case 6 -> 128000000;
+            case 7 -> 256000000;
+            case 8 -> 512000000;
+            case 9 -> 1024000000;
+            case 10 -> 2147483640;
+            default -> 0;
+        };
     }
 
     private static int tierPump(int tier) {
-        switch (tier) {
-            case 1:
-                return 2;
-            case 2:
-                return 3;
-            case 3:
-                return 3;
-            case 4:
-                return 4;
-            case 5:
-                return 4;
-            case 6:
-                return 5;
-            case 7:
-                return 5;
-            case 8:
-                return 6;
-            case 9:
-                return 7;
-            case 10:
-                return 8;
-            default:
-                return 0;
-        }
+        return switch (tier) {
+            case 1 -> 2;
+            case 2 -> 3;
+            case 3 -> 3;
+            case 4 -> 4;
+            case 5 -> 4;
+            case 6 -> 5;
+            case 7 -> 5;
+            case 8 -> 6;
+            case 9 -> 7;
+            case 10 -> 8;
+            default -> 0;
+        };
     }
 
     public GT_MetaTileEntity_DigitalTankBase(String aName, int aTier, String aDescription, ITexture[][][] aTextures) {