Recipe Adder v2 (#1770)

* add everything

* fixes

* migrate plasma forge recipes

* syntax update

* make chances array length differ a fatal error

* time constants + long eut overload

* migrate extruder recipes

* migrate electromagnetic separator recipes

* migrate wiremill recipes

* migrate forming press recipes

* migrate bender recipes

* add doc to clarify the three itemInputs

* migrate alloy smelter recipes

* migrate arc furnace recipes

* added ModIDs enum

* sort ModIDs

* migrate autoclave recipes

* migrated some assembler recipes

* split a bit more assembler recipes

* migrate canner recipes

* migrate brewing recipes

* ic2 mod check in canner recipes

* use some loops to reduce the amount of recipes to migrate

* add requested helper methods

* migrate vacuum freezer recipes

* migrate thermal centrifuge recipes

* format smelter recipes only, doesn't go through normal GT recipe

* migrated slicer recipes

* migrated sifter recipes

* Use proper enum now

* remove more constants

* cleaning cutting recipes before migration

* remove tons of dead commented recipes

* migrate pyrolyse recipes

* use ModIDs enum more

* migrate printer recipes

* add a less confusing way to specify value of specialItem

* migrate pulverizer recipes

* less confusing special item specification

* even more ModIDs enum usage

* fix auto * import confusing Minecraft enum value with Minecraft client object

* migrated blast furnace recipes

* migrated Centrifuge recipes

* migrated assembler recipes

* migrated implosion compressor recipes

* migrated extractor recipes

* migrated mixer recipes

* remove useless code

* mgrate universal chemical recipes

* refactor chemical recipes

* migrate single block only chem reactor recipes

* migrate chem reactor recipes

* reworked circuit assembler recipes before migrating them

* migrated circuit assembler recipes

* fix merge conflict for assembler recipes

* remove leftover of the merge conflicts

* fix weird translation glitch

* example of assembly line recipe using RA2

* bugfixes for assline

* remove specialValue usage in blast furnace recipes

* fix more bugs

* add nooptimize to where it make sense

* add recipe descriptions

* Materials.Superconductor -> Materials.SuperconductorUHV

* remove useless Object creations

* remove explicit long casts

* migrate assemblyline recipes

* migrate chemical bath recipes

* migrate compressor recipes

* move smelting recipe where it belongs

* migrated cutting machine recipes

* migrated fermenter recipes (unhide alcohol)

* remove explicit long casts

* migrate fluid canner recipes

* migrate fluid heater recipes

* migrated fusion recipes

* migrated lathe recipes

* migrated laser engraver recipes

* migrated packager recipes

* migrated forge hammer recipes

* migrated TPM recipes

* exit early and reduced indents

* migrated fluid extractor recipes

* migrated fluid solidifier recipes

* migrated electrolyzer recipes

* migrated crop processing recipes

* migrated default polymerization recipes

* migrate distillery recipes

* migrate matter amplifier recipes

* add metadata identifier for fusion ignition threshold

* migrate fuel recipes

* update bs

(cherry picked from commit c2d931c9b6caa0376e9d50591894cd849021104d)

* spotless

(cherry picked from commit 1060f5357fb95e28bfae1f052025f55dabc21a0f)

* guard against null itemstacks

* wrong translation

* fix empty arrays being accessed

* add 0 duration and 0 EU/t for fuel recipes

* fix typo in matter amplifier recipes

* spotless apply

---------

Co-authored-by: boubou19 <miisterunknown@gmail.com>
Co-authored-by: Martin Robertz <dream-master@gmx.net>

2 files changed, 25 insertions, 24 deletions

diff --git a/src/main/java/gregtech/loaders/postload/chains/GT_NaniteChain.java b/src/main/java/gregtech/loaders/postload/chains/GT_NaniteChain.java
index f5dd2dcc05..be48d7b45b 100644
--- a/src/main/java/gregtech/loaders/postload/chains/GT_NaniteChain.java
+++ b/src/main/java/gregtech/loaders/postload/chains/GT_NaniteChain.java
@@ -1,7 +1,7 @@
 package gregtech.loaders.postload.chains;
 
-import static gregtech.api.enums.GT_Values.MOD_ID_DC;
-import static gregtech.api.enums.GT_Values.MOD_ID_GTPP;
+import static gregtech.api.enums.ModIDs.GTPlusPlus;
+import static gregtech.api.enums.ModIDs.NewHorizonsCoreMod;
 import static gregtech.api.util.GT_ModHandler.getModItem;
 
 import net.minecraft.item.ItemStack;
@@ -19,9 +19,9 @@ public class GT_NaniteChain {
 
     public static void run() {
 
-        ItemStack aUVTierLens = getModItem(MOD_ID_DC, "item.MysteriousCrystalLens", 0);
-        ItemStack aUHVTierLens = getModItem(MOD_ID_DC, "item.ChromaticLens", 0);
-        ItemStack aUEVTierLens = getModItem(MOD_ID_DC, "item.RadoxPolymerLens", 0);
+        ItemStack aUVTierLens = getModItem(NewHorizonsCoreMod.modID, "item.MysteriousCrystalLens", 0);
+        ItemStack aUHVTierLens = getModItem(NewHorizonsCoreMod.modID, "item.ChromaticLens", 0);
+        ItemStack aUEVTierLens = getModItem(NewHorizonsCoreMod.modID, "item.RadoxPolymerLens", 0);
         ItemStack aUIVTierLens = ItemList.EnergisedTesseract.get(0);
         ItemStack aUMVTierLens = GT_OreDictUnificator.get(OrePrefixes.lens, Materials.Dilithium, 0, false);
 
@@ -101,13 +101,13 @@ public class GT_NaniteChain {
 
         // Glowstone Nanites - Used in the optical circuit line
         GT_Values.RA.addNanoForgeRecipe(
-                new ItemStack[] { aUEVTierLens, getModItem(MOD_ID_GTPP, "blockCompressedObsidian", 8, 7), // Double
-                                                                                                          // compressed
-                                                                                                          // glowstone
-                                                                                                          // blocks
-                                                                                                          // (yes, it's
-                                                                                                          // not
-                                                                                                          // obsidian)
+                new ItemStack[] { aUEVTierLens, getModItem(GTPlusPlus.modID, "blockCompressedObsidian", 8, 7), // Double
+                        // compressed
+                        // glowstone
+                        // blocks
+                        // (yes, it's
+                        // not
+                        // obsidian)
                         ItemList.Circuit_Chip_SoC2.get(64) },
                 new FluidStack[] { Materials.UUMatter.getFluid(50000) },
                 new ItemStack[] { Materials.Glowstone.getNanite(64) },
@@ -145,9 +145,10 @@ public class GT_NaniteChain {
         GT_Values.RA.addNanoForgeRecipe(
                 new ItemStack[] { aUMVTierLens, getModItem("bartworks", "gt.bwMetaGeneratedlens", 0, 36), // Magneto
                                                                                                           // lens
-                        getModItem(MOD_ID_GTPP, "MU-metaitem.01", 0, 32105), // Quantum Anomaly, couldn't find any
-                                                                             // better naming
-                        Materials.WhiteDwarfMatter.getBlocks(8), getModItem(MOD_ID_DC, "item.PicoWafer", 32),
+                        getModItem(GTPlusPlus.modID, "MU-metaitem.01", 0, 32105), // Quantum Anomaly, couldn't find any
+                        // better naming
+                        Materials.WhiteDwarfMatter.getBlocks(8),
+                        getModItem(NewHorizonsCoreMod.modID, "item.PicoWafer", 32),
                         getModItem("GoodGenerator", "huiCircuit", 1, 4) // Paradox circuit
                 },
                 new FluidStack[] { Materials.UUMatter.getFluid(500_000), Materials.RawStarMatter.getFluid(50_000),
@@ -163,9 +164,10 @@ public class GT_NaniteChain {
         GT_Values.RA.addNanoForgeRecipe(
                 new ItemStack[] { aUMVTierLens, getModItem("bartworks", "gt.bwMetaGeneratedlens", 0, 36), // Magneto
                                                                                                           // lens
-                        getModItem(MOD_ID_GTPP, "MU-metaitem.01", 0, 32105), // Quantum Anomaly, couldn't find any
-                                                                             // better naming
-                        Materials.BlackDwarfMatter.getBlocks(8), getModItem(MOD_ID_DC, "item.PicoWafer", 32),
+                        getModItem(GTPlusPlus.modID, "MU-metaitem.01", 0, 32105), // Quantum Anomaly, couldn't find any
+                        // better naming
+                        Materials.BlackDwarfMatter.getBlocks(8),
+                        getModItem(NewHorizonsCoreMod.modID, "item.PicoWafer", 32),
                         getModItem("GoodGenerator", "huiCircuit", 1, 4) // Paradox circuit
                 },
                 new FluidStack[] { Materials.UUMatter.getFluid(500_000), Materials.RawStarMatter.getFluid(50_000),
@@ -181,7 +183,7 @@ public class GT_NaniteChain {
         GT_Values.RA.addNanoForgeRecipe(
                 new ItemStack[] { aUMVTierLens,
                         // Quantum Anomaly, couldn't find any better naming.
-                        getModItem(MOD_ID_GTPP, "MU-metaitem.01", 0, 32105), Materials.Universium.getBlocks(8),
+                        getModItem(GTPlusPlus.modID, "MU-metaitem.01", 0, 32105), Materials.Universium.getBlocks(8),
 
                         ItemList.Optically_Perfected_CPU.get(16), ItemList.Optically_Compatible_Memory.get(16),
                         getModItem("GoodGenerator", "huiCircuit", 1, 4) // Paradox circuit
diff --git a/src/main/java/gregtech/loaders/postload/chains/GT_PCBFactoryRecipes.java b/src/main/java/gregtech/loaders/postload/chains/GT_PCBFactoryRecipes.java
index 38406215ec..3cb705cc2a 100644
--- a/src/main/java/gregtech/loaders/postload/chains/GT_PCBFactoryRecipes.java
+++ b/src/main/java/gregtech/loaders/postload/chains/GT_PCBFactoryRecipes.java
@@ -1,6 +1,6 @@
 package gregtech.loaders.postload.chains;
 
-import static gregtech.api.enums.GT_Values.MOD_ID_GTPP;
+import static gregtech.api.enums.ModIDs.GTPlusPlus;
 
 import java.util.ArrayList;
 import java.util.List;
@@ -10,7 +10,6 @@ import net.minecraftforge.fluids.Fluid;
 import net.minecraftforge.fluids.FluidRegistry;
 import net.minecraftforge.fluids.FluidStack;
 
-import cpw.mods.fml.common.Loader;
 import gregtech.api.enums.GT_Values;
 import gregtech.api.enums.ItemList;
 import gregtech.api.enums.Materials;
@@ -59,14 +58,14 @@ public class GT_PCBFactoryRecipes {
                 30 * 20,
                 (int) GT_Values.VP[9]);
         GT_Values.RA.addAssemblerRecipe(
-                new ItemStack[] { GT_ModHandler.getModItem(MOD_ID_GTPP, "blockFrameGtCelestialTungsten", 1),
+                new ItemStack[] { GT_ModHandler.getModItem(GTPlusPlus.modID, "blockFrameGtCelestialTungsten", 1),
                         Materials.get("Quantum").getPlates(6) },
                 null,
                 ItemList.RadiationProofPhotolithographicFrameworkCasing.get(1),
                 30 * 20,
                 (int) GT_Values.VP[11]);
         GT_Values.RA.addAssemblerRecipe(
-                new ItemStack[] { GT_ModHandler.getModItem(MOD_ID_GTPP, "blockFrameGtHypogen", 1),
+                new ItemStack[] { GT_ModHandler.getModItem(GTPlusPlus.modID, "blockFrameGtHypogen", 1),
                         GT_OreDictUnificator.get(OrePrefixes.rotor, Materials.Infinity, 2),
                         Materials.Thulium.getPlates(6) },
                 Materials.SpaceTime.getMolten(144 * 8),
@@ -526,7 +525,7 @@ public class GT_PCBFactoryRecipes {
                     mTier3BitMap | mBioUpgradeBitMap);
         }
 
-        if (Loader.isModLoaded("miscutils")) {
+        if (GTPlusPlus.isModLoaded()) {
             // Optical Circuit Board
             for (int tier = 7; tier <= GT_PCBFactoryManager.mTiersOfPlastics; tier++) {
                 int amountOfBoards = (int) Math.ceil(8 * (Math.sqrt(Math.pow(2, tier - 7))));