Cleaning up (#767)

* Kill playerAPI

* Gut more events and compat that is now obsolete

* Remove commented out code

* Remove final modifier from methods

* Make more stuff final

* Remove slow building ring

* Protected -> private in final classes

* More cleaning

* More cleaning v2

* Purging

* Clean DevHelper

* Clean DevHelper 2

* delete DevHelper

* remove useless IFMLLoadingPlugin.MCVersion annotation from @Mod files

* check for obfuscation only once in the IFMLloadingPlugin.injectData

* don't instantiate the static class ASMConfig

* delete unused and empty implementation of IFMLCallHook

* delete empty class

* delete ClassesToTransform class that just holds the class names constants

* delete unused methods and unsless logging in dummymod container

* delete unused transformer ClassTransformer_TT_ThaumicRestorer

* spotless

* Clean

* Clean utils

* Build checkpoint

* Purge

* Stage 2

* Stage 3

* Stage 4

* Stage 5

* Stage 6

* Spotless

* Imports

* Stage idk

* Stage 1

* Fix issue

* Spotless

* Format numbers

---------

Co-authored-by: GTNH-Colen <54497873+GTNH-Colen@users.noreply.github.com>
Co-authored-by: Alexdoru <57050655+Alexdoru@users.noreply.github.com>
Co-authored-by: Connor Colenso <colen@CONNORSPC>

1 files changed, 17 insertions, 10 deletions

diff --git a/src/main/java/gtPlusPlus/xmod/gregtech/api/enums/GregtechOrePrefixes.java b/src/main/java/gtPlusPlus/xmod/gregtech/api/enums/GregtechOrePrefixes.java
index 61abc48a18..03ec5f3fc5 100644
--- a/src/main/java/gtPlusPlus/xmod/gregtech/api/enums/GregtechOrePrefixes.java
+++ b/src/main/java/gtPlusPlus/xmod/gregtech/api/enums/GregtechOrePrefixes.java
@@ -109,7 +109,7 @@ public enum GregtechOrePrefixes {
     chipset("Chipsets", "", "", true, true, false, false, false, false, false, false, false, false, 0, -1, 64, -1), // Introduced
     ;
 
-    public static volatile int VERSION = 508;
+    public static final int VERSION = 508;
 
     static {
         ingotHot.mHeatDamage = 3.0F;
@@ -132,11 +132,11 @@ public enum GregtechOrePrefixes {
             mGeneratedItems = new HashSet<>();
     private final ArrayList<Interface_OreRecipeRegistrator> mOreProcessing = new ArrayList<>();
     private final ArrayList<Interface_OreRecipeRegistrator> mOreProcessingFake = new ArrayList<>();
-    public ItemStack mContainerItem = null;
-    public ICondition<ISubTagContainer> mCondition = null;
+    public final ItemStack mContainerItem = null;
+    public final ICondition<ISubTagContainer> mCondition = null;
     public byte mDefaultStackSize = 64;
-    public GregtechMaterialStack mSecondaryMaterial = null;
-    public GregtechOrePrefixes mPrefixInto = this;
+    public final GregtechMaterialStack mSecondaryMaterial = null;
+    public final GregtechOrePrefixes mPrefixInto = this;
     public float mHeatDamage = 0.0F; // Negative for Frost Damage
     /**
      * Yes this Value can be changed to add Bits for the MetaGenerated-Item-Check.
@@ -657,15 +657,22 @@ public enum GregtechOrePrefixes {
                 mOreMultiplier = 1, mByProductMultiplier = 1, mSmeltingMultiplier = 1;
         public long mDensity = M;
         public Element mElement = null;
-        public GT_Materials mDirectSmelting = this, mOreReplacement = this, mMacerateInto = this, mSmeltInto = this,
-                mArcSmeltInto = this, mHandleMaterial = this;
+        public GT_Materials mDirectSmelting = this;
+        public GT_Materials mOreReplacement = this;
+        public GT_Materials mMacerateInto = this;
+        public GT_Materials mSmeltInto = this;
+        public GT_Materials mArcSmeltInto = this;
+        public final GT_Materials mHandleMaterial = this;
         public byte mToolQuality = 0;
-        public Fluid mSolid = null, mFluid = null, mGas = null, mPlasma = null;
+        public final Fluid mSolid = null;
+        public Fluid mFluid = null;
+        public Fluid mGas = null;
+        public Fluid mPlasma = null;
         /**
          * This Fluid is used as standard Unit for Molten Materials. 1296 is a Molten Block, what means 144 is one
          * Material Unit worth
          */
-        public Fluid mStandardMoltenFluid = null;
+        public final Fluid mStandardMoltenFluid = null;
 
         private GT_Materials(final int aMetaItemSubID, final TextureSet aIconSet, final float aToolSpeed,
                 final int aToolDurability, final int aToolQuality, final boolean aUnificatable) {
@@ -1283,6 +1290,6 @@ public enum GregtechOrePrefixes {
             return this.mRGBa;
         }
 
-        public static volatile int VERSION = 508;
+        public static final int VERSION = 508;
     }
 }