aboutsummaryrefslogtreecommitdiff
path: root/src/main/java/gtPlusPlus
diff options
context:
space:
mode:
authorAlexdoru <57050655+Alexdoru@users.noreply.github.com>2024-09-21 01:38:28 +0200
committerGitHub <noreply@github.com>2024-09-21 01:38:28 +0200
commitc10272e0e358a233ed0ce7d591e9e43ca7ffa26c (patch)
treea097f2307d43a5c3d77a698b3c01eae801d35c6c /src/main/java/gtPlusPlus
parente567c18792be9fe623ec777b40f3cbc36572b78e (diff)
downloadGT5-Unofficial-c10272e0e358a233ed0ce7d591e9e43ca7ffa26c.tar.gz
GT5-Unofficial-c10272e0e358a233ed0ce7d591e9e43ca7ffa26c.tar.bz2
GT5-Unofficial-c10272e0e358a233ed0ce7d591e9e43ca7ffa26c.zip
Delete more reflection (#3233)
Diffstat (limited to 'src/main/java/gtPlusPlus')
-rw-r--r--src/main/java/gtPlusPlus/GTplusplus.java28
-rw-r--r--src/main/java/gtPlusPlus/core/handler/events/EnderDragonDeathHandler.java33
-rw-r--r--src/main/java/gtPlusPlus/core/item/ModItems.java18
-rw-r--r--src/main/java/gtPlusPlus/core/item/bauble/FireProtectionBauble.java2
-rw-r--r--src/main/java/gtPlusPlus/core/item/wearable/armour/tinfoil/ItemArmourTinFoilHat.java69
-rw-r--r--src/main/java/gtPlusPlus/core/util/minecraft/ItemUtils.java12
-rw-r--r--src/main/java/gtPlusPlus/core/util/minecraft/PlayerUtils.java13
-rw-r--r--src/main/java/gtPlusPlus/core/util/reflect/ReflectionUtils.java156
-rw-r--r--src/main/java/gtPlusPlus/preloader/asm/transformers/ClassTransformer_LWJGL_Keyboard.java36
-rw-r--r--src/main/java/gtPlusPlus/xmod/gregtech/api/metatileentity/implementations/base/GTPPMultiBlockBase.java19
-rw-r--r--src/main/java/gtPlusPlus/xmod/gregtech/common/tileentities/machines/multi/production/MTEIndustrialFishingPond.java215
-rw-r--r--src/main/java/gtPlusPlus/xmod/gregtech/common/tileentities/machines/multi/production/algae/MTEAlgaePondBase.java4
-rw-r--r--src/main/java/gtPlusPlus/xmod/gregtech/loaders/RecipeGenRecycling.java39
-rw-r--r--src/main/java/gtPlusPlus/xmod/thermalfoundation/item/TFItems.java7
14 files changed, 164 insertions, 487 deletions
diff --git a/src/main/java/gtPlusPlus/GTplusplus.java b/src/main/java/gtPlusPlus/GTplusplus.java
index 16d0b013b4..893446ea72 100644
--- a/src/main/java/gtPlusPlus/GTplusplus.java
+++ b/src/main/java/gtPlusPlus/GTplusplus.java
@@ -146,7 +146,7 @@ public class GTplusplus implements ActionListener {
INIT_PHASE.SUPER.setPhaseActive(true);
}
- @Mod.EventHandler
+ @EventHandler
public void preInit(final FMLPreInitializationEvent event) {
INIT_PHASE.PRE_INIT.setPhaseActive(true);
// Load all class objects within the plugin package.
@@ -165,7 +165,7 @@ public class GTplusplus implements ActionListener {
CoreManager.preInit();
}
- @Mod.EventHandler
+ @EventHandler
public void init(final FMLInitializationEvent event) {
INIT_PHASE.INIT.setPhaseActive(true);
proxy.init(event);
@@ -178,7 +178,7 @@ public class GTplusplus implements ActionListener {
}
}
- @Mod.EventHandler
+ @EventHandler
public void postInit(final FMLPostInitializationEvent event) {
INIT_PHASE.POST_INIT.setPhaseActive(true);
proxy.postInit(event);
@@ -222,7 +222,7 @@ public class GTplusplus implements ActionListener {
INIT_PHASE.STARTED.setPhaseActive(true);
}
- @Mod.EventHandler
+ @EventHandler
public synchronized void serverStopping(final FMLServerStoppingEvent event) {
CoreManager.serverStop();
}
@@ -238,7 +238,7 @@ public class GTplusplus implements ActionListener {
* @param event - The {@link EventHandler} object passed through from FML to {@link #GTplusplus()}'s
* {@link #instance}.
*/
- @Mod.EventHandler
+ @EventHandler
public void onLoadComplete(FMLLoadCompleteEvent event) {
proxy.onLoadComplete(event);
generateGregtechRecipeMaps();
@@ -246,27 +246,25 @@ public class GTplusplus implements ActionListener {
protected void generateGregtechRecipeMaps() {
- int[] mInvalidCount = new int[] { 0, 0, 0, 0, 0, 0, 0 };
-
RecipeGenBlastSmelterGTNH.generateGTNHBlastSmelterRecipesFromEBFList();
FishPondFakeRecipe.generateFishPondRecipes();
SemiFluidFuelHandler.generateFuels();
- mInvalidCount[0] = RecipeGenMultisUsingFluidInsteadOfCells
+ RecipeGenMultisUsingFluidInsteadOfCells
.generateRecipesNotUsingCells(RecipeMaps.centrifugeRecipes, GTPPRecipeMaps.centrifugeNonCellRecipes);
- mInvalidCount[1] = RecipeGenMultisUsingFluidInsteadOfCells
+ RecipeGenMultisUsingFluidInsteadOfCells
.generateRecipesNotUsingCells(RecipeMaps.electrolyzerRecipes, GTPPRecipeMaps.electrolyzerNonCellRecipes);
- mInvalidCount[2] = RecipeGenMultisUsingFluidInsteadOfCells
+ RecipeGenMultisUsingFluidInsteadOfCells
.generateRecipesNotUsingCells(RecipeMaps.vacuumFreezerRecipes, GTPPRecipeMaps.advancedFreezerRecipes);
- mInvalidCount[3] = RecipeGenMultisUsingFluidInsteadOfCells
+ RecipeGenMultisUsingFluidInsteadOfCells
.generateRecipesNotUsingCells(RecipeMaps.mixerRecipes, GTPPRecipeMaps.mixerNonCellRecipes);
- mInvalidCount[4] = RecipeGenMultisUsingFluidInsteadOfCells.generateRecipesNotUsingCells(
+ RecipeGenMultisUsingFluidInsteadOfCells.generateRecipesNotUsingCells(
GTPPRecipeMaps.chemicalDehydratorRecipes,
GTPPRecipeMaps.chemicalDehydratorNonCellRecipes);
- mInvalidCount[5] = RecipeGenMultisUsingFluidInsteadOfCells.generateRecipesNotUsingCells(
+ RecipeGenMultisUsingFluidInsteadOfCells.generateRecipesNotUsingCells(
GTPPRecipeMaps.coldTrapRecipes,
GTPPRecipeMaps.nuclearSaltProcessingPlantRecipes);
- mInvalidCount[6] = RecipeGenMultisUsingFluidInsteadOfCells.generateRecipesNotUsingCells(
+ RecipeGenMultisUsingFluidInsteadOfCells.generateRecipesNotUsingCells(
GTPPRecipeMaps.reactorProcessingUnitRecipes,
GTPPRecipeMaps.nuclearSaltProcessingPlantRecipes);
}
@@ -352,7 +350,7 @@ public class GTplusplus implements ActionListener {
sMissingItemMappings.put("miscutils:oreFluorite", GameRegistry.findItem(GTPlusPlus.ID, "oreFluoriteF"));
}
- @Mod.EventHandler
+ @EventHandler
public void missingMapping(FMLMissingMappingsEvent event) {
processMissingMappings();
for (MissingMapping mapping : event.getAll()) {
diff --git a/src/main/java/gtPlusPlus/core/handler/events/EnderDragonDeathHandler.java b/src/main/java/gtPlusPlus/core/handler/events/EnderDragonDeathHandler.java
index 13dc18c4b1..51780fd030 100644
--- a/src/main/java/gtPlusPlus/core/handler/events/EnderDragonDeathHandler.java
+++ b/src/main/java/gtPlusPlus/core/handler/events/EnderDragonDeathHandler.java
@@ -13,36 +13,23 @@ import com.kuba6000.mobsinfo.api.MobRecipe;
import cpw.mods.fml.common.Optional;
import cpw.mods.fml.common.eventhandler.SubscribeEvent;
+import gregtech.api.util.ReflectionUtil;
import gtPlusPlus.core.material.MaterialsElements;
import gtPlusPlus.core.util.math.MathUtils;
import gtPlusPlus.core.util.minecraft.PlayerUtils;
-import gtPlusPlus.core.util.reflect.ReflectionUtils;
@Optional.Interface(iface = "com.kuba6000.mobsinfo.api.IMobExtraInfoProvider", modid = "mobsinfo")
public class EnderDragonDeathHandler implements IMobExtraInfoProvider {
- private static final String mDragonClassName = "chylex.hee.entity.boss.EntityBossDragon";
- private static final boolean mHEE;
- private static final Class mHardcoreDragonClass;
-
- private static final String mChaosDragonClassName = "com.brandon3055.draconicevolution.common.entity.EntityCustomDragon";
- private static final boolean mDE;
- private static final Class mChaoseDragonClass;
-
- static {
- mHEE = ReflectionUtils.doesClassExist(mDragonClassName);
- mHardcoreDragonClass = (mHEE ? ReflectionUtils.getClass(mDragonClassName) : null);
- mDE = ReflectionUtils.doesClassExist(mChaosDragonClassName);
- mChaoseDragonClass = (mDE ? ReflectionUtils.getClass(mChaosDragonClassName) : null);
- }
+ private static final Class<?> mHardcoreDragonClass = ReflectionUtil
+ .getClass("chylex.hee.entity.boss.EntityBossDragon");
+ private static final Class<?> mChaoseDragonClass = ReflectionUtil
+ .getClass("com.brandon3055.draconicevolution.common.entity.EntityCustomDragon");
@SubscribeEvent
public void onEntityDrop(LivingDropsEvent event) {
- //
-
int aCountTotal = 0;
-
- if (mHEE && mHardcoreDragonClass != null && mHardcoreDragonClass.isInstance(event.entityLiving)) {
+ if (mHardcoreDragonClass != null && mHardcoreDragonClass.isInstance(event.entityLiving)) {
for (int y = 0; y < MathUtils.randInt(100, 250); y++) {
int aAmount = MathUtils.randInt(5, 25);
event.entityLiving.entityDropItem(
@@ -50,7 +37,7 @@ public class EnderDragonDeathHandler implements IMobExtraInfoProvider {
MathUtils.randFloat(0, 1));
aCountTotal = +aAmount;
}
- } else if (mDE && mChaoseDragonClass != null && mChaoseDragonClass.isInstance(event.entityLiving)) {
+ } else if (mChaoseDragonClass != null && mChaoseDragonClass.isInstance(event.entityLiving)) {
for (int y = 0; y < MathUtils.randInt(100, 200); y++) {
int aAmount = MathUtils.randInt(1, 5);
event.entityLiving.entityDropItem(
@@ -69,7 +56,7 @@ public class EnderDragonDeathHandler implements IMobExtraInfoProvider {
}
if (aCountTotal > 0) {
PlayerUtils
- .messageAllPlayers(aCountTotal + " Shards of Dragons Blood have crystalized into a metallic form.");
+ .messageAllPlayers(aCountTotal + " Shards of Dragons Blood have crystallized into a metallic form.");
}
}
@@ -77,7 +64,7 @@ public class EnderDragonDeathHandler implements IMobExtraInfoProvider {
@Override
public void provideExtraDropsInformation(@NotNull String entityString, @NotNull ArrayList<MobDrop> drops,
@NotNull MobRecipe recipe) {
- if (mHEE && mHardcoreDragonClass != null && mHardcoreDragonClass.isInstance(recipe.entity)) {
+ if (mHardcoreDragonClass != null && mHardcoreDragonClass.isInstance(recipe.entity)) {
MobDrop drop = new MobDrop(
MaterialsElements.STANDALONE.DRAGON_METAL.getNugget(1),
MobDrop.DropType.Normal,
@@ -90,7 +77,7 @@ public class EnderDragonDeathHandler implements IMobExtraInfoProvider {
drop.clampChance();
drops.add(drop);
- } else if (mDE && mChaoseDragonClass != null && mChaoseDragonClass.isInstance(recipe.entity)) {
+ } else if (mChaoseDragonClass != null && mChaoseDragonClass.isInstance(recipe.entity)) {
MobDrop drop = new MobDrop(
MaterialsElements.STANDALONE.DRAGON_METAL.getIngot(1),
MobDrop.DropType.Normal,
diff --git a/src/main/java/gtPlusPlus/core/item/ModItems.java b/src/main/java/gtPlusPlus/core/item/ModItems.java
index 67ff8034dc..014b399044 100644
--- a/src/main/java/gtPlusPlus/core/item/ModItems.java
+++ b/src/main/java/gtPlusPlus/core/item/ModItems.java
@@ -1,5 +1,6 @@
package gtPlusPlus.core.item;
+import static gregtech.api.enums.Mods.Baubles;
import static gregtech.api.enums.Mods.Forestry;
import static gregtech.api.enums.Mods.GTPlusPlus;
import static gregtech.api.enums.Mods.GregTech;
@@ -80,7 +81,6 @@ import gtPlusPlus.core.util.data.StringUtils;
import gtPlusPlus.core.util.minecraft.FluidUtils;
import gtPlusPlus.core.util.minecraft.ItemUtils;
import gtPlusPlus.core.util.minecraft.MaterialUtils;
-import gtPlusPlus.core.util.reflect.ReflectionUtils;
import gtPlusPlus.everglades.GTPPEverglades;
import gtPlusPlus.xmod.gregtech.api.enums.GregtechItemList;
import gtPlusPlus.xmod.gregtech.common.helpers.VolumetricFlaskHelper;
@@ -784,19 +784,9 @@ public final class ModItems {
// Milled Ore Processing
new MilledOreProcessing();
- // IC2 Exp
- Logger.INFO("IndustrialCraft2 Found - Loading Resources.");
-
- // Baubles Mod Test
- try {
- final Class<?> baublesTest = ReflectionUtils.getClass("baubles.api.IBauble");
- if (baublesTest != null) {
- CompatBaubles.run();
- } else {
- Logger.INFO("Baubles Not Found - Skipping Resources.");
- }
- } catch (final Throwable T) {
- Logger.INFO("Baubles Not Found - Skipping Resources.");
+ // Baubles
+ if (Baubles.isModLoaded()) {
+ CompatBaubles.run();
}
// Buffer Cores!
diff --git a/src/main/java/gtPlusPlus/core/item/bauble/FireProtectionBauble.java b/src/main/java/gtPlusPlus/core/item/bauble/FireProtectionBauble.java
index 35adc35e96..89ddb241ed 100644
--- a/src/main/java/gtPlusPlus/core/item/bauble/FireProtectionBauble.java
+++ b/src/main/java/gtPlusPlus/core/item/bauble/FireProtectionBauble.java
@@ -22,7 +22,7 @@ import gtPlusPlus.preloader.PreloaderCore;
public class FireProtectionBauble extends BaseBauble {
- private static Field isImmuneToFire;
+ private static final Field isImmuneToFire;
static {
isImmuneToFire = ReflectionUtils
diff --git a/src/main/java/gtPlusPlus/core/item/wearable/armour/tinfoil/ItemArmourTinFoilHat.java b/src/main/java/gtPlusPlus/core/item/wearable/armour/tinfoil/ItemArmourTinFoilHat.java
index 7df52a176a..94b33a270e 100644
--- a/src/main/java/gtPlusPlus/core/item/wearable/armour/tinfoil/ItemArmourTinFoilHat.java
+++ b/src/main/java/gtPlusPlus/core/item/wearable/armour/tinfoil/ItemArmourTinFoilHat.java
@@ -28,7 +28,6 @@ import net.minecraft.world.World;
import cpw.mods.fml.relauncher.Side;
import cpw.mods.fml.relauncher.SideOnly;
-import gregtech.api.util.GTUtility;
import gtPlusPlus.core.item.wearable.armour.ArmourLoader;
import gtPlusPlus.core.item.wearable.armour.base.BaseArmourHelm;
@@ -120,55 +119,41 @@ public class ItemArmourTinFoilHat extends BaseArmourHelm {
public void onArmorTick(World world, EntityPlayer player, ItemStack itemStack) {
if (itemStack != null && player != null && world != null && !world.isRemote) {
if (player instanceof EntityPlayer) {
-
// Apply Slow
- if (!GTUtility.getPotion(player, Potion.moveSlowdown.id)) {
+ if (!player.isPotionActive(Potion.moveSlowdown.id)) {
player.addPotionEffect(new PotionEffect(Potion.moveSlowdown.id, 2, 1, true));
}
-
// Move Xp orbs away
- try {
- AxisAlignedBB box = player.boundingBox;
- box.maxX = player.posX + 5;
- box.maxY = player.posY + 5;
- box.maxZ = player.posZ + 5;
- box.minX = player.posX - 5;
- box.minY = player.posY - 5;
- box.minZ = player.posZ - 5;
- @SuppressWarnings("unchecked")
- List<Entity> g = world.getEntitiesWithinAABBExcludingEntity(player, box);
- if (g.size() > 0) {
- for (Entity e : g) {
- if (e != null) {
- if (!EntityXPOrb.class.isInstance(e) && !EntityBoat.class.isInstance(e)
- && !EntitySnowball.class.isInstance(e)
- && !EntityFireball.class.isInstance(e)
- && !EntityEgg.class.isInstance(e)
- && !EntityExpBottle.class.isInstance(e)
- && !EntityEnderEye.class.isInstance(e)
- && !EntityEnderPearl.class.isInstance(e)) {
- continue;
- } else {
- // Logger.INFO("Found "+e.getClass().getName());
- double distX = player.posX - e.posX;
- double distZ = player.posZ - e.posZ;
- double distY = e.posY + 1.5D - player.posY;
- double dir = Math.atan2(distZ, distX);
- double speed = 1F / e.getDistanceToEntity(player) * 0.5;
- speed = -speed;
- if (distY < 0) {
- e.motionY += speed;
- }
- e.motionX = Math.cos(dir) * speed;
- e.motionZ = Math.sin(dir) * speed;
- }
- }
+ final AxisAlignedBB box = player.getBoundingBox();
+ if (box != null) {
+ List<Entity> list = world.getEntitiesWithinAABBExcludingEntity(
+ player,
+ box.expand(5, 5, 5),
+ e -> e instanceof EntityXPOrb || e instanceof EntityBoat
+ || e instanceof EntitySnowball
+ || e instanceof EntityFireball
+ || e instanceof EntityEgg
+ || e instanceof EntityExpBottle
+ || e instanceof EntityEnderEye
+ || e instanceof EntityEnderPearl);
+ for (Entity e : list) {
+ final float dist = e.getDistanceToEntity(player);
+ if (dist == 0) continue;
+ double distX = player.posX - e.posX;
+ double distZ = player.posZ - e.posZ;
+ double distY = e.posY + 1.5D - player.posY;
+ double dir = Math.atan2(distZ, distX);
+ double speed = 1F / dist * 0.5;
+ speed = -speed;
+ if (distY < 0) {
+ e.motionY += speed;
}
+ e.motionX = Math.cos(dir) * speed;
+ e.motionZ = Math.sin(dir) * speed;
}
- } catch (Throwable t) {}
+ }
}
}
-
super.onArmorTick(world, player, itemStack);
}
diff --git a/src/main/java/gtPlusPlus/core/util/minecraft/ItemUtils.java b/src/main/java/gtPlusPlus/core/util/minecraft/ItemUtils.java
index 3565b1c14d..c64686a151 100644
--- a/src/main/java/gtPlusPlus/core/util/minecraft/ItemUtils.java
+++ b/src/main/java/gtPlusPlus/core/util/minecraft/ItemUtils.java
@@ -72,16 +72,16 @@ public class ItemUtils {
return simpleMetaStack(Item.getItemFromBlock(x), meta, i);
}
- public static ItemStack getSimpleStack(final Item x, final int i) {
- return new ItemStack(x, i);
+ public static ItemStack getSimpleStack(final Item item, final int stackSize) {
+ return new ItemStack(item, stackSize);
}
- public static ItemStack getSimpleStack(final ItemStack x, final int i) {
- if (x == null) {
+ public static ItemStack getSimpleStack(final ItemStack stack, final int stackSize) {
+ if (stack == null) {
return null;
}
- final ItemStack r = x.copy();
- r.stackSize = i;
+ final ItemStack r = stack.copy();
+ r.stackSize = stackSize;
return r;
}
diff --git a/src/main/java/gtPlusPlus/core/util/minecraft/PlayerUtils.java b/src/main/java/gtPlusPlus/core/util/minecraft/PlayerUtils.java
index 7ea6af4a23..6f50da5eb2 100644
--- a/src/main/java/gtPlusPlus/core/util/minecraft/PlayerUtils.java
+++ b/src/main/java/gtPlusPlus/core/util/minecraft/PlayerUtils.java
@@ -19,21 +19,14 @@ import net.minecraftforge.common.util.FakePlayer;
import cpw.mods.fml.relauncher.Side;
import cpw.mods.fml.relauncher.SideOnly;
import gregtech.api.util.GTUtility;
+import gregtech.api.util.ReflectionUtil;
import gtPlusPlus.core.util.Utils;
-import gtPlusPlus.core.util.reflect.ReflectionUtils;
public class PlayerUtils {
public static final Map<String, EntityPlayer> mCachedFakePlayers = new WeakHashMap<>();
- private static final Class mThaumcraftFakePlayer;
-
- static {
- if (ReflectionUtils.doesClassExist("thaumcraft.common.lib.FakeThaumcraftPlayer")) {
- mThaumcraftFakePlayer = ReflectionUtils.getClass("thaumcraft.common.lib.FakeThaumcraftPlayer");
- } else {
- mThaumcraftFakePlayer = null;
- }
- }
+ private static final Class<?> mThaumcraftFakePlayer = ReflectionUtil
+ .getClass("thaumcraft.common.lib.FakeThaumcraftPlayer");
public static List<EntityPlayerMP> getOnlinePlayers() {
final List<EntityPlayerMP> onlinePlayers = MinecraftServer.getServer()
diff --git a/src/main/java/gtPlusPlus/core/util/reflect/ReflectionUtils.java b/src/main/java/gtPlusPlus/core/util/reflect/ReflectionUtils.java
index 576c236de6..40b32fed86 100644
--- a/src/main/java/gtPlusPlus/core/util/reflect/ReflectionUtils.java
+++ b/src/main/java/gtPlusPlus/core/util/reflect/ReflectionUtils.java
@@ -20,7 +20,6 @@ import gtPlusPlus.core.util.data.StringUtils;
@SuppressWarnings({ "unchecked", "rawtypes" })
public class ReflectionUtils {
- public static Map<String, Class<?>> mCachedClasses = new LinkedHashMap<>();
public static Map<String, CachedMethod> mCachedMethods = new LinkedHashMap<>();
public static Map<String, CachedField> mCachedFields = new LinkedHashMap<>();
public static Map<String, CachedConstructor> mCachedConstructors = new LinkedHashMap<>();
@@ -74,18 +73,6 @@ public class ReflectionUtils {
.getUntypedField(Fields.LookupType.DECLARED_IN_HIERARCHY, field.getName()));
}
- private static boolean cacheClass(Class<?> aClass) {
- if (aClass == null) {
- return false;
- }
- Class<?> y = mCachedClasses.get(aClass.getCanonicalName());
- if (y == null) {
- mCachedClasses.put(aClass.getCanonicalName(), aClass);
- return true;
- }
- return false;
- }
-
private static boolean cacheMethod(Class<?> aClass, Method aMethod) {
if (aMethod == null) {
return false;
@@ -154,27 +141,6 @@ public class ReflectionUtils {
}
/**
- * Returns a cached {@link Class} object.
- *
- * @param aClassCanonicalName - The canonical name of the underlying class.
- * @return - Valid, {@link Class} object, or {@link null}.
- */
- public static Class<?> getClass(String aClassCanonicalName) {
- if (aClassCanonicalName == null || aClassCanonicalName.length() <= 0) {
- return null;
- }
- Class<?> y = mCachedClasses.get(aClassCanonicalName);
- if (y == null) {
- y = getClass_Internal(aClassCanonicalName);
- if (y != null) {
- Logger.REFLECTION("Caching Class: " + aClassCanonicalName);
- cacheClass(y);
- }
- }
- return y;
- }
-
- /**
* Returns a cached {@link Method} object. Wraps {@link #getMethod(Class, String, Class...)}.
*
* @param aObject - Object containing the Method.
@@ -263,10 +229,6 @@ public class ReflectionUtils {
* Utility Functions
*/
- public static boolean doesClassExist(final String classname) {
- return isClassPresent(classname);
- }
-
public static void makeFieldAccessible(final Field field) {
if (!Modifier.isPublic(field.getModifiers()) || !Modifier.isPublic(
field.getDeclaringClass()
@@ -445,20 +407,6 @@ public class ReflectionUtils {
}
}
- /**
- * if (isPresent("com.optionaldependency.DependencyClass")) || This block will never execute when the dependency is
- * not present. There is therefore no more risk of code throwing NoClassDefFoundException.
- */
- private static boolean isClassPresent(final String className) {
- try {
- Class.forName(className);
- return true;
- } catch (final Throwable ex) {
- // Class or one of its dependencies is not present...
- return false;
- }
- }
-
private static Method getMethod_Internal(Class<?> aClass, String aMethodName, Class<?>... aTypes) {
Method m = null;
try {
@@ -561,106 +509,6 @@ public class ReflectionUtils {
}
}
- private static Class<?> getNonPublicClass(final String className) {
- Class<?> c = null;
- try {
- c = Class.forName(className);
- } catch (final ClassNotFoundException e) {
- // TODO Auto-generated catch block
- e.printStackTrace();
- }
- // full package name --------^^^^^^^^^^
- // or simpler without Class.forName:
- // Class<package1.A> c = package1.A.class;
-
- if (null != c) {
- // In our case we need to use
- Constructor<?> constructor = null;
- try {
- constructor = c.getDeclaredConstructor();
- } catch (NoSuchMethodException | SecurityException e) {
- // TODO Auto-generated catch block
- e.printStackTrace();
- }
- // note: getConstructor() can return only public constructors
- // so we needed to search for any Declared constructor
-
- // now we need to make this constructor accessible
- if (null != constructor) {
- constructor.setAccessible(true); // ABRACADABRA!
-
- try {
- final Object o = constructor.newInstance();
- return (Class<?>) o;
- } catch (InstantiationException | IllegalAccessException | IllegalArgumentException
- | InvocationTargetException e) {
- // TODO Auto-generated catch block
- e.printStackTrace();
- }
- }
- }
- return null;
- }
-
- private static Class<?> getClass_Internal(String string) {
- Class<?> aClass = null;
- if (ReflectionUtils.doesClassExist(string)) {
- try {
- aClass = Class.forName(string);
- } catch (ClassNotFoundException e) {
- aClass = getNonPublicClass(string);
- }
- }
-
- if (aClass == null) {
- String aClassName = "";
- Logger.REFLECTION("Splitting " + string + " to try look for hidden classes.");
- String[] aData = string.split("\\.");
- Logger.REFLECTION("Obtained " + aData.length + " pieces.");
- for (int i = 0; i < (aData.length - 1); i++) {
- aClassName += (i > 0) ? "." + aData[i] : "" + aData[i];
- Logger.REFLECTION("Building: " + aClassName);
- }
- if (aClassName != null && aClassName.length() > 0) {
- Logger.REFLECTION("Trying to search '" + aClassName + "' for inner classes.");
- Class<?> clazz = ReflectionUtils.getClass(aClassName);
- if (clazz != null) {
- Class[] y = clazz.getDeclaredClasses();
- if (y == null || y.length <= 0) {
- Logger.REFLECTION("No hidden inner classes found.");
- return null;
- } else {
- boolean found = false;
- for (Class<?> h : y) {
- Logger.REFLECTION("Found hidden inner class: " + h.getCanonicalName());
- if (h.getSimpleName()
- .toLowerCase()
- .equals(aData[aData.length - 1].toLowerCase())) {
- Logger.REFLECTION(
- "Found correct class. [" + aData[aData.length - 1]
- + "] Caching at correct location: "
- + string);
- Logger.REFLECTION("Found at location: " + h.getCanonicalName());
- ReflectionUtils.mCachedClasses.put(string, h);
- aClass = h;
- found = true;
- break;
- }
- }
- if (!found) {
- return null;
- }
- }
- } else {
- return null;
- }
- } else {
- return null;
- }
- }
- return aClass;
- }
-
/**
*
* Set the value of a field reflectively.
@@ -693,9 +541,7 @@ public class ReflectionUtils {
T aInstance;
try {
aInstance = (T) aConstructor.newInstance(aArgs);
- if (aInstance != null) {
- return aInstance;
- }
+ return aInstance;
} catch (InstantiationException | IllegalAccessException | IllegalArgumentException
| InvocationTargetException e) {
e.printStackTrace();
diff --git a/src/main/java/gtPlusPlus/preloader/asm/transformers/ClassTransformer_LWJGL_Keyboard.java b/src/main/java/gtPlusPlus/preloader/asm/transformers/ClassTransformer_LWJGL_Keyboard.java
index 4d3c78e6bd..a10f842d95 100644
--- a/src/main/java/gtPlusPlus/preloader/asm/transformers/ClassTransformer_LWJGL_Keyboard.java
+++ b/src/main/java/gtPlusPlus/preloader/asm/transformers/ClassTransformer_LWJGL_Keyboard.java
@@ -23,7 +23,7 @@ import org.objectweb.asm.Label;
import org.objectweb.asm.MethodVisitor;
import cpw.mods.fml.relauncher.FMLRelaunchLog;
-import gtPlusPlus.core.util.Utils;
+import gregtech.api.util.ReflectionUtil;
import gtPlusPlus.core.util.reflect.ReflectionUtils;
public class ClassTransformer_LWJGL_Keyboard {
@@ -66,23 +66,21 @@ public class ClassTransformer_LWJGL_Keyboard {
}
public static void trySetClientKey(int aKey) {
- if (Utils.isClient() && ReflectionUtils.doesClassExist("net.minecraft.client.Minecraft")) {
- FMLRelaunchLog.log(
- "[GT++ ASM] LWJGL Keybinding index out of bounds fix",
- Level.INFO,
- "Trying to set key value to be empty.");
- GameSettings options = Minecraft.getMinecraft().gameSettings;
- KeyBinding[] akeybinding = Minecraft.getMinecraft().gameSettings.keyBindings;
- int i = akeybinding.length;
- for (KeyBinding keybinding : akeybinding) {
- if (keybinding != null && keybinding.getKeyCode() == aKey) {
- options.setOptionKeyBinding(keybinding, 0);
- FMLRelaunchLog.log(
- "[GT++ ASM] LWJGL Keybinding index out of bounds fix",
- Level.INFO,
- "Set keybind " + aKey + " to 0.");
- break;
- }
+ FMLRelaunchLog.log(
+ "[GT++ ASM] LWJGL Keybinding index out of bounds fix",
+ Level.INFO,
+ "Trying to set key value to be empty.");
+ GameSettings options = Minecraft.getMinecraft().gameSettings;
+ KeyBinding[] akeybinding = Minecraft.getMinecraft().gameSettings.keyBindings;
+ int i = akeybinding.length;
+ for (KeyBinding keybinding : akeybinding) {
+ if (keybinding != null && keybinding.getKeyCode() == aKey) {
+ options.setOptionKeyBinding(keybinding, 0);
+ FMLRelaunchLog.log(
+ "[GT++ ASM] LWJGL Keybinding index out of bounds fix",
+ Level.INFO,
+ "Set keybind " + aKey + " to 0.");
+ break;
}
}
}
@@ -97,7 +95,7 @@ public class ClassTransformer_LWJGL_Keyboard {
if (mKeyName != null) {
return true;
}
- Class aKeyboard = ReflectionUtils.getClass("org.lwjgl.input.Keyboard");
+ Class aKeyboard = ReflectionUtil.getClass("org.lwjgl.input.Keyboard");
if (aKeyboard != null) {
mKeyboard = aKeyboard;
Field aKeyName = ReflectionUtils.getField(mKeyboard, "keyName");
diff --git a/src/main/java/gtPlusPlus/xmod/gregtech/api/metatileentity/implementations/base/GTPPMultiBlockBase.java b/src/main/java/gtPlusPlus/xmod/gregtech/api/metatileentity/implementations/base/GTPPMultiBlockBase.java
index ef3cb3ba48..7db3262531 100644
--- a/src/main/java/gtPlusPlus/xmod/gregtech/api/metatileentity/implementations/base/GTPPMultiBlockBase.java
+++ b/src/main/java/gtPlusPlus/xmod/gregtech/api/metatileentity/implementations/base/GTPPMultiBlockBase.java
@@ -9,14 +9,12 @@ import java.util.Collection;
import java.util.Iterator;
import java.util.List;
import java.util.Map.Entry;
-import java.util.Objects;
import java.util.Set;
import java.util.concurrent.ConcurrentHashMap;
import java.util.concurrent.TimeUnit;
import java.util.function.BiConsumer;
import java.util.function.BiPredicate;
import java.util.function.Function;
-import java.util.stream.Collectors;
import javax.annotation.Nullable;
@@ -82,7 +80,6 @@ import gtPlusPlus.api.objects.minecraft.BlockPos;
import gtPlusPlus.core.config.ASMConfiguration;
import gtPlusPlus.core.util.minecraft.ItemUtils;
import gtPlusPlus.core.util.minecraft.PlayerUtils;
-import gtPlusPlus.core.util.reflect.ReflectionUtils;
import gtPlusPlus.preloader.PreloaderCore;
import gtPlusPlus.xmod.gregtech.api.metatileentity.implementations.METHatchAirIntake;
import gtPlusPlus.xmod.gregtech.api.metatileentity.implementations.MTEHatchInputBattery;
@@ -1591,12 +1588,7 @@ public abstract class GTPPMultiBlockBase<T extends MTEExtendedPowerMultiBlockBas
public long count(GTPPMultiBlockBase<?> t) {
return t.mTecTechEnergyHatches.size();
}
- },;
-
- @SuppressWarnings("unchecked")
- private static <T> Class<T> retype(Class<?> clazz) {
- return (Class<T>) clazz;
- }
+ };
private final List<? extends Class<? extends IMetaTileEntity>> mMteClasses;
private final IGTHatchAdder<? super GTPPMultiBlockBase<?>> mAdder;
@@ -1608,15 +1600,6 @@ public abstract class GTPPMultiBlockBase<T extends MTEExtendedPowerMultiBlockBas
this.mAdder = aAdder;
}
- GTPPHatchElement(IGTHatchAdder<? super GTPPMultiBlockBase<?>> aAdder, String... aClassNames) {
- this.mMteClasses = Arrays.stream(aClassNames)
- .map(ReflectionUtils::getClass)
- .filter(Objects::nonNull)
- .<Class<? extends IMetaTileEntity>>map(GTPPHatchElement::retype)
- .collect(Collectors.toList());
- this.mAdder = aAdder;
- }
-
@Override
public List<? extends Class<? extends IMetaTileEntity>> mteClasses() {
return mMteClasses;
diff --git a/src/main/java/gtPlusPlus/xmod/gregtech/common/tileentities/machines/multi/production/MTEIndustrialFishingPond.java b/src/main/java/gtPlusPlus/xmod/gregtech/common/tileentities/machines/multi/production/MTEIndustrialFishingPond.java
index 4b9b5c0ae4..7f048b6847 100644
--- a/src/main/java/gtPlusPlus/xmod/gregtech/common/tileentities/machines/multi/production/MTEIndustrialFishingPond.java
+++ b/src/main/java/gtPlusPlus/xmod/gregtech/common/tileentities/machines/multi/production/MTEIndustrialFishingPond.java
@@ -13,14 +13,11 @@ import static gregtech.api.util.GTStructureUtility.buildHatchAdder;
import static gtPlusPlus.core.util.data.ArrayUtils.removeNulls;
import java.util.ArrayList;
-import java.util.HashMap;
-import java.util.Map;
import net.minecraft.block.Block;
import net.minecraft.init.Blocks;
import net.minecraft.item.Item;
import net.minecraft.item.ItemStack;
-import net.minecraft.util.WeightedRandomFishable;
import net.minecraftforge.fluids.FluidStack;
import org.jetbrains.annotations.NotNull;
@@ -46,6 +43,7 @@ import gregtech.api.util.GTUtility;
import gregtech.api.util.MultiblockTooltipBuilder;
import gregtech.api.util.OverclockCalculator;
import gregtech.api.util.ParallelHelper;
+import gregtech.api.util.ReflectionUtil;
import gtPlusPlus.api.recipe.GTPPRecipeMaps;
import gtPlusPlus.core.block.ModBlocks;
import gtPlusPlus.core.config.Configuration;
@@ -53,7 +51,6 @@ import gtPlusPlus.core.lib.GTPPCore;
import gtPlusPlus.core.util.math.MathUtils;
import gtPlusPlus.core.util.minecraft.FluidUtils;
import gtPlusPlus.core.util.minecraft.ItemUtils;
-import gtPlusPlus.core.util.reflect.ReflectionUtils;
import gtPlusPlus.xmod.gregtech.api.metatileentity.implementations.base.GTPPMultiBlockBase;
import ic2.core.init.BlocksItems;
import ic2.core.init.InternalName;
@@ -61,15 +58,22 @@ import ic2.core.init.InternalName;
public class MTEIndustrialFishingPond extends GTPPMultiBlockBase<MTEIndustrialFishingPond>
implements ISurvivalConstructable {
- private boolean isUsingControllerCircuit = false;
- private static final Item circuit = GTUtility.getIntegratedCircuit(0)
+ public static final int FISH_MODE = 14;
+ public static final int JUNK_MODE = 15;
+ public static final int TREASURE_MODE = 16;
+ private static final Item CONTROL_CIRCUIT = GTUtility.getIntegratedCircuit(0)
.getItem();
+ private static IStructureDefinition<MTEIndustrialFishingPond> STRUCTURE_DEFINITION;
+
+ private boolean isUsingControllerCircuit = false;
private int mCasing;
- private static IStructureDefinition<MTEIndustrialFishingPond> STRUCTURE_DEFINITION = null;
+ private int mMode = FISH_MODE;
+ private int mMax = 8;
+
private static final Class<?> cofhWater;
static {
- cofhWater = ReflectionUtils.getClass("cofh.asmhooks.block.BlockWater");
+ cofhWater = ReflectionUtil.getClass("cofh.asmhooks.block.BlockWater");
}
public MTEIndustrialFishingPond(final int aID, final String aName, final String aNameRegional) {
@@ -97,9 +101,9 @@ public class MTEIndustrialFishingPond extends GTPPMultiBlockBase<MTEIndustrialFi
.addInfo("Controller Block for the Fishing Pond")
.addInfo("Can process (Tier + 1) * 2 recipes")
.addInfo("Put a numbered circuit into the input bus.")
- .addInfo("Circuit 14 for Fish")
- .addInfo("Circuit 15 for Junk")
- .addInfo("Circuit 16 for Treasure")
+ .addInfo("Circuit " + FISH_MODE + " for Fish")
+ .addInfo("Circuit " + JUNK_MODE + " for Junk")
+ .addInfo("Circuit " + TREASURE_MODE + " for Treasure")
.addInfo("Need to be filled with water.")
.addInfo("Will automatically fill water from input hatch.")
.addPollutionAmount(getPollutionPerSecond(null))
@@ -194,7 +198,7 @@ public class MTEIndustrialFishingPond extends GTPPMultiBlockBase<MTEIndustrialFi
public @NotNull CheckRecipeResult checkProcessing() {
ItemStack controllerStack = getControllerSlot();
if (controllerStack != null) {
- if (controllerStack.getItem() == circuit) {
+ if (controllerStack.getItem() == CONTROL_CIRCUIT) {
this.isUsingControllerCircuit = true;
this.mMode = controllerStack.getItemDamage();
} else {
@@ -203,9 +207,6 @@ public class MTEIndustrialFishingPond extends GTPPMultiBlockBase<MTEIndustrialFi
} else {
this.isUsingControllerCircuit = false;
}
- if (!hasGenerateRecipes) {
- generateRecipes();
- }
if (!checkForWater()) {
return SimpleCheckRecipeResult.ofFailure("no_water");
}
@@ -218,9 +219,9 @@ public class MTEIndustrialFishingPond extends GTPPMultiBlockBase<MTEIndustrialFi
long tEnergy = getMaxInputEnergy();
- getCircuit(tItemInputs);
+ setModeFromInputStacks(tItemInputs);
- ItemStack[] mFishOutput = generateLoot(this.mMode);
+ ItemStack[] mFishOutput = generateLoot();
mFishOutput = removeNulls(mFishOutput);
GTRecipe g = new GTRecipe(
true,
@@ -281,45 +282,28 @@ public class MTEIndustrialFishingPond extends GTPPMultiBlockBase<MTEIndustrialFi
return Configuration.pollution.pollutionPerSecondMultiIndustrialFishingPond;
}
- @Override
- public boolean explodesOnComponentBreak(final ItemStack aStack) {
- return false;
- }
-
- public Block getCasingBlock() {
+ private Block getCasingBlock() {
return ModBlocks.blockCasings3Misc;
}
- public byte getCasingMeta() {
+ private byte getCasingMeta() {
return 0;
}
- public int getCasingTextureIndex() {
+ private int getCasingTextureIndex() {
return TAE.GTPP_INDEX(32);
}
- public boolean checkForWater() {
+ private boolean checkForWater() {
// Get Facing direction
IGregTechTileEntity aBaseMetaTileEntity = this.getBaseMetaTileEntity();
- int mDirectionX = aBaseMetaTileEntity.getBackFacing().offsetX;
- int mCurrentDirectionX;
- int mCurrentDirectionZ;
- int mOffsetX_Lower = 0;
- int mOffsetX_Upper = 0;
- int mOffsetZ_Lower = 0;
- int mOffsetZ_Upper = 0;
-
- mCurrentDirectionX = 4;
- mCurrentDirectionZ = 4;
-
- mOffsetX_Lower = -4;
- mOffsetX_Upper = 4;
- mOffsetZ_Lower = -4;
- mOffsetZ_Upper = 4;
-
- // if (aBaseMetaTileEntity.fac)
-
+ final int mCurrentDirectionX = 4;
+ final int mCurrentDirectionZ = 4;
+ final int mOffsetX_Lower = -4;
+ final int mOffsetX_Upper = 4;
+ final int mOffsetZ_Lower = -4;
+ final int mOffsetZ_Upper = 4;
final int xDir = aBaseMetaTileEntity.getBackFacing().offsetX * mCurrentDirectionX;
final int zDir = aBaseMetaTileEntity.getBackFacing().offsetZ * mCurrentDirectionZ;
@@ -336,13 +320,12 @@ public class MTEIndustrialFishingPond extends GTPPMultiBlockBase<MTEIndustrialFi
if (stored.amount >= 1000) {
// Utils.LOG_WARNING("Going to try swap an air block for water from inut bus.");
stored.amount -= 1000;
- Block fluidUsed = Blocks.water;
aBaseMetaTileEntity.getWorld()
.setBlock(
aBaseMetaTileEntity.getXCoord() + xDir + i,
aBaseMetaTileEntity.getYCoord() + h,
aBaseMetaTileEntity.getZCoord() + zDir + j,
- fluidUsed);
+ Blocks.water);
}
}
}
@@ -365,119 +348,57 @@ public class MTEIndustrialFishingPond extends GTPPMultiBlockBase<MTEIndustrialFi
|| (cofhWater != null && cofhWater.isAssignableFrom(block.getClass()) && meta != 0);
}
- private static ArrayList<ArrayList<WeightedRandomFishable>> categories = new ArrayList<>();
- private static ArrayList<WeightedRandomFishable> categoryFish = new ArrayList<>();
- private static ArrayList<WeightedRandomFishable> categoryJunk = new ArrayList<>();
- private static ArrayList<WeightedRandomFishable> categoryLoot = new ArrayList<>();
- private static boolean hasGenerateRecipes = false;
- private int mMode = 14;
- private int mMax = 8;
-
- private void generateRecipes() {
- if (hasGenerateRecipes) return;
-
- categories.add(categoryFish);
- categories.add(categoryJunk);
- categories.add(categoryLoot);
- categoryFish.addAll(FishPondFakeRecipe.fish);
- categoryJunk.addAll(FishPondFakeRecipe.junk);
- categoryLoot.addAll(FishPondFakeRecipe.treasure);
- hasGenerateRecipes = true;
- }
-
- private int getCircuit(ItemStack[] t) {
- if (!this.isUsingControllerCircuit) {
- for (ItemStack j : t) {
- if (j.getItem() == GTUtility.getIntegratedCircuit(0)
- .getItem()) {
- // Fish
- if (j.getItemDamage() == 14) {
- mMax = 8 + (this.getMaxParallelRecipes() - 2);
- this.mMode = 14;
- break;
- }
- // Junk
- else if (j.getItemDamage() == 15) {
- this.mMode = 15;
- mMax = 4;
- break;
- }
- // Loot
- else if (j.getItemDamage() == 16) {
- this.mMode = 16;
- mMax = 4;
- break;
- } else {
- this.mMode = 0;
- mMax = 0;
- break;
- }
+ private void setModeFromInputStacks(ItemStack[] stacks) {
+ if (this.isUsingControllerCircuit) return;
+ for (ItemStack stack : stacks) {
+ if (stack.getItem() == CONTROL_CIRCUIT) {
+ if (stack.getItemDamage() == FISH_MODE) {
+ mMode = FISH_MODE;
+ mMax = 8 + (this.getMaxParallelRecipes() - 2);
+ return;
+ } else if (stack.getItemDamage() == JUNK_MODE) {
+ mMode = JUNK_MODE;
+ mMax = 4;
+ return;
+ } else if (stack.getItemDamage() == TREASURE_MODE) {
+ mMode = TREASURE_MODE;
+ mMax = 4;
+ return;
} else {
- this.mMode = 0;
+ mMode = 0;
mMax = 0;
- break;
+ return;
}
+ } else {
+ mMode = 0;
+ mMax = 0;
+ break;
}
}
- return this.mMode;
}
- // reflection map
- private static Map<WeightedRandomFishable, ItemStack> reflectiveFishMap = new HashMap<>();
-
- private ItemStack reflectiveFish(WeightedRandomFishable y) {
- if (reflectiveFishMap.containsKey(y)) {
- return reflectiveFishMap.get(y);
+ private ItemStack[] generateLoot() {
+ if (this.mMode == FISH_MODE) {
+ return getLootFromList(FishPondFakeRecipe.fish, (65 - getMaxParallelRecipes()));
+ } else if (this.mMode == JUNK_MODE) {
+ return getLootFromList(FishPondFakeRecipe.junk, 200);
+ } else if (this.mMode == TREASURE_MODE) {
+ return getLootFromList(FishPondFakeRecipe.treasure, 100);
+ } else {
+ return null;
}
- ItemStack t;
- try {
- t = (ItemStack) ReflectionUtils.getField(WeightedRandomFishable.class, "field_150711_b")
- .get(y);
- ItemStack k = ItemUtils.getSimpleStack(t, 1);
- reflectiveFishMap.put(y, k);
- return t;
- } catch (IllegalArgumentException | IllegalAccessException e) {}
- return null;
}
- private ItemStack[] generateLoot(int mode) {
- ItemStack[] mFishOutput = new ItemStack[this.mMax];
- if (this.mMode == 14) {
- for (int k = 0; k < this.mMax; k++) {
- if (mFishOutput[k] == null) for (WeightedRandomFishable g : categoryFish) {
- if (MathUtils.randInt(0, (65 - getMaxParallelRecipes())) <= 2) {
- ItemStack t = reflectiveFish(g);
- if (t != null) {
- mFishOutput[k] = ItemUtils.getSimpleStack(t, 1);
- }
- }
- }
- }
- } else if (this.mMode == 15) {
- for (int k = 0; k < this.mMax; k++) {
- if (mFishOutput[k] == null) for (WeightedRandomFishable g : categoryJunk) {
- if (MathUtils.randInt(0, 100) <= 1) {
- ItemStack t = reflectiveFish(g);
- if (t != null) {
- mFishOutput[k] = ItemUtils.getSimpleStack(t, 1);
- }
- }
- }
- }
- } else if (this.mMode == 16) {
- for (int k = 0; k < this.mMax; k++) {
- if (mFishOutput[k] == null) for (WeightedRandomFishable g : categoryLoot) {
- if (MathUtils.randInt(0, 1000) <= 2) {
- ItemStack t = reflectiveFish(g);
- if (t != null) {
- mFishOutput[k] = ItemUtils.getSimpleStack(t, 1);
- }
- }
+ private ItemStack[] getLootFromList(ArrayList<ItemStack> list, int max) {
+ ItemStack[] out = new ItemStack[this.mMax];
+ for (int i = 0; i < this.mMax; i++) {
+ for (ItemStack stack : list) {
+ if (MathUtils.randInt(0, max) <= 2) {
+ out[i] = ItemUtils.getSimpleStack(stack, 1);
+ break;
}
}
- } else {
- mFishOutput = null;
}
- return mFishOutput;
+ return out;
}
}
diff --git a/src/main/java/gtPlusPlus/xmod/gregtech/common/tileentities/machines/multi/production/algae/MTEAlgaePondBase.java b/src/main/java/gtPlusPlus/xmod/gregtech/common/tileentities/machines/multi/production/algae/MTEAlgaePondBase.java
index f2f0bcb104..c9af07ecf3 100644
--- a/src/main/java/gtPlusPlus/xmod/gregtech/common/tileentities/machines/multi/production/algae/MTEAlgaePondBase.java
+++ b/src/main/java/gtPlusPlus/xmod/gregtech/common/tileentities/machines/multi/production/algae/MTEAlgaePondBase.java
@@ -43,6 +43,7 @@ import gregtech.api.util.GTRecipe;
import gregtech.api.util.GTStreamUtil;
import gregtech.api.util.GTUtility;
import gregtech.api.util.MultiblockTooltipBuilder;
+import gregtech.api.util.ReflectionUtil;
import gtPlusPlus.api.objects.Logger;
import gtPlusPlus.core.block.ModBlocks;
import gtPlusPlus.core.config.Configuration;
@@ -50,7 +51,6 @@ import gtPlusPlus.core.item.chemistry.AgriculturalChem;
import gtPlusPlus.core.lib.GTPPCore;
import gtPlusPlus.core.util.minecraft.FluidUtils;
import gtPlusPlus.core.util.minecraft.ItemUtils;
-import gtPlusPlus.core.util.reflect.ReflectionUtils;
import gtPlusPlus.xmod.gregtech.api.metatileentity.implementations.base.GTPPMultiBlockBase;
import gtPlusPlus.xmod.gregtech.common.blocks.textures.TexturesGtBlock;
import gtPlusPlus.xmod.gregtech.loaders.recipe.RecipeLoaderAlgaeFarm;
@@ -67,7 +67,7 @@ public class MTEAlgaePondBase extends GTPPMultiBlockBase<MTEAlgaePondBase> imple
private static final Class<?> cofhWater;
static {
- cofhWater = ReflectionUtils.getClass("cofh.asmhooks.block.BlockWater");
+ cofhWater = ReflectionUtil.getClass("cofh.asmhooks.block.BlockWater");
}
public MTEAlgaePondBase(final int aID, final String aName, final String aNameRegional) {
diff --git a/src/main/java/gtPlusPlus/xmod/gregtech/loaders/RecipeGenRecycling.java b/src/main/java/gtPlusPlus/xmod/gregtech/loaders/RecipeGenRecycling.java
index 89fdf23ec6..5f5160b6a4 100644
--- a/src/main/java/gtPlusPlus/xmod/gregtech/loaders/RecipeGenRecycling.java
+++ b/src/main/java/gtPlusPlus/xmod/gregtech/loaders/RecipeGenRecycling.java
@@ -7,15 +7,12 @@ import static gregtech.api.recipe.RecipeMaps.maceratorRecipes;
import static gregtech.api.util.GTRecipeBuilder.SECONDS;
import java.util.ArrayList;
-import java.util.Map;
import net.minecraft.init.Items;
import net.minecraft.item.ItemStack;
import net.minecraftforge.fluids.FluidStack;
import net.minecraftforge.oredict.OreDictionary;
-import org.apache.commons.lang3.reflect.FieldUtils;
-
import gregtech.api.enums.GTValues;
import gregtech.api.enums.Materials;
import gregtech.api.enums.OrePrefixes;
@@ -33,7 +30,7 @@ public class RecipeGenRecycling implements Runnable {
public static ArrayList<Runnable> mQueuedRecyclingGenerators = new ArrayList<>();
public static void executeGenerators() {
- if (mQueuedRecyclingGenerators.size() > 0) {
+ if (!mQueuedRecyclingGenerators.isEmpty()) {
for (Runnable R : mQueuedRecyclingGenerators) {
R.run();
}
@@ -41,21 +38,15 @@ public class RecipeGenRecycling implements Runnable {
}
final Material toGenerate;
- public static Map<String, ItemStack> mNameMap;
public RecipeGenRecycling(final Material M) {
this.toGenerate = M;
- if (mNameMap == null) {
- mNameMap = this.getNameMap();
- }
mQueuedRecyclingGenerators.add(this);
}
@Override
public void run() {
- if (mNameMap != null) {
- generateRecipes(this.toGenerate);
- }
+ generateRecipes(this.toGenerate);
}
public static void generateRecipes(final Material material) {
@@ -253,12 +244,14 @@ public class RecipeGenRecycling implements Runnable {
Logger.modLogger.warn("Returning Null. Method: ", new Exception());
return null;
}
- if (!mNameMap.containsKey(aName.toString()) && aMentionPossibleTypos) {
+ if (!GTOreDictUnificator.getName2StackMap()
+ .containsKey(aName.toString()) && aMentionPossibleTypos) {
Logger.WARNING("Unknown Key for Unification, Typo? " + aName);
}
return GTUtility.copyAmount(
aAmount,
- new Object[] { mNameMap.get(aName.toString()), getFirstOre(aName, aAmount), aReplacement });
+ new Object[] { GTOreDictUnificator.getName2StackMap()
+ .get(aName.toString()), getFirstOre(aName, aAmount), aReplacement });
}
public static ItemStack getFirstOre(final Object aName, final long aAmount) {
@@ -266,7 +259,8 @@ public class RecipeGenRecycling implements Runnable {
Logger.modLogger.warn("Returning Null. Method: ", new Exception());
return null;
}
- final ItemStack tStack = mNameMap.get(aName.toString());
+ final ItemStack tStack = GTOreDictUnificator.getName2StackMap()
+ .get(aName.toString());
if (GTUtility.isStackValid(tStack)) {
Logger.WARNING("Found valid stack.");
return GTUtility.copyAmount(aAmount, new Object[] { tStack });
@@ -289,23 +283,6 @@ public class RecipeGenRecycling implements Runnable {
return rList;
}
- @SuppressWarnings("unchecked")
- public Map<String, ItemStack> getNameMap() {
- Map<String, ItemStack> tempMap;
- try {
- tempMap = (Map<String, ItemStack>) FieldUtils
- .readStaticField(GTOreDictUnificator.class, "sName2StackMap", true);
- if (tempMap != null) {
- Logger.WARNING("Found 'sName2StackMap' in GTOreDictUnificator.class.");
- return tempMap;
- }
- } catch (final IllegalAccessException e) {
- e.printStackTrace();
- }
- Logger.WARNING("Invalid map stored in GTOreDictUnificator.class, unable to find sName2StackMap field.");
- return null;
- }
-
public static ItemStack getItemStackOfAmountFromOreDictNoBroken(String oredictName, final int amount) {
try {
diff --git a/src/main/java/gtPlusPlus/xmod/thermalfoundation/item/TFItems.java b/src/main/java/gtPlusPlus/xmod/thermalfoundation/item/TFItems.java
index 556b11483f..9c8e7137c3 100644
--- a/src/main/java/gtPlusPlus/xmod/thermalfoundation/item/TFItems.java
+++ b/src/main/java/gtPlusPlus/xmod/thermalfoundation/item/TFItems.java
@@ -7,9 +7,9 @@ import cofh.core.item.ItemBase;
import cofh.core.item.ItemBucket;
import cofh.core.util.energy.FurnaceFuelHandler;
import cofh.core.util.fluid.BucketHandler;
+import gregtech.api.enums.Mods;
import gtPlusPlus.core.creative.AddToCreativeTab;
import gtPlusPlus.core.util.minecraft.ItemUtils;
-import gtPlusPlus.core.util.reflect.ReflectionUtils;
import gtPlusPlus.xmod.thermalfoundation.block.TFBlocks;
import gtPlusPlus.xmod.thermalfoundation.fluid.TFFluids;
@@ -45,9 +45,8 @@ public class TFItems {
dustPyrotheum = itemMaterial.addOreDictItem(3, "dustPyrotheum");
dustCryotheum = itemMaterial.addOreDictItem(4, "dustCryotheum");
- if (ReflectionUtils.doesClassExist("cofh.core.util.energy.FurnaceFuelHandler")) {
- FurnaceFuelHandler.registerFuel(dustPyrotheum, 2400); // cofh.core.util.energy.FurnaceFuelHandler.registerFuel(ItemStack,
- // int)
+ if (Mods.COFHCore.isModLoaded()) {
+ FurnaceFuelHandler.registerFuel(dustPyrotheum, 2400);
}
ItemUtils.addItemToOreDictionary(rodBlizz, "stickBlizz");