Output bus pipe fix take two (#85)

* Revert "Fix #81 (#83)"

This reverts commit bbaa3dd99996a9fa121dd06386051adb4d10b54a.

* Update drain/fill to take into account pipe connections

2 files changed, 32 insertions, 14 deletions

diff --git a/src/main/java/gregtech/api/metatileentity/BaseMetaPipeEntity.java b/src/main/java/gregtech/api/metatileentity/BaseMetaPipeEntity.java
index fd4426da62..78a462a7af 100644
--- a/src/main/java/gregtech/api/metatileentity/BaseMetaPipeEntity.java
+++ b/src/main/java/gregtech/api/metatileentity/BaseMetaPipeEntity.java
@@ -1168,45 +1168,63 @@ public class BaseMetaPipeEntity extends BaseTileEntity implements IGregTechTileE
         if (!canAccessData() || getCoverIDAtSide(aSide) != 0) return false;

         return mMetaTileEntity.injectRotationalEnergy(aSide, aSpeed, aEnergy);

     }

-

-    @Override

-    public int fill(ForgeDirection aSide, FluidStack aFluid, boolean doFill) {

-        if (mTickTimer > 5 && canAccessData() && (aSide == ForgeDirection.UNKNOWN || (mMetaTileEntity.isLiquidInput((byte) aSide.ordinal()) && getCoverBehaviorAtSide((byte) aSide.ordinal()).letsFluidIn((byte) aSide.ordinal(), getCoverIDAtSide((byte) aSide.ordinal()), getCoverDataAtSide((byte) aSide.ordinal()), aFluid == null ? null : aFluid.getFluid(), this))))

-            return mMetaTileEntity.fill(aSide, aFluid, doFill);

+    

+    private boolean canMoveFluidOnSide(ForgeDirection aSide, Fluid aFluid, boolean isFill) {

+        if (aSide == ForgeDirection.UNKNOWN 

+            || ( (isFill ? mMetaTileEntity.isLiquidInput((byte) aSide.ordinal()) : mMetaTileEntity.isLiquidOutput((byte) aSide.ordinal()))

+                    && getCoverBehaviorAtSide((byte) aSide.ordinal()).letsFluidOut((byte) aSide.ordinal(), getCoverIDAtSide((byte) aSide.ordinal()), getCoverDataAtSide((byte) aSide.ordinal()), mMetaTileEntity.getFluid() == null ? null : mMetaTileEntity.getFluid().getFluid(), this)

+                    && mMetaTileEntity.isConnectedAtSide((byte) aSide.ordinal())

+                    )

+                )

+        	return true;

+    	return false;

+    }

+

+    @Override

+    public int fill(ForgeDirection aSide, FluidStack aFluidStack, boolean doFill) {

+        if (mTickTimer > 5 && canAccessData() && canMoveFluidOnSide(aSide, aFluidStack == null ? null : aFluidStack.getFluid(), true))

+            return mMetaTileEntity.fill(aSide, aFluidStack, doFill);

         return 0;

     }

 

     @Override

     public FluidStack drain(ForgeDirection aSide, int maxDrain, boolean doDrain) {

-        if (mTickTimer > 5 && canAccessData() && (aSide == ForgeDirection.UNKNOWN || (mMetaTileEntity.isLiquidOutput((byte) aSide.ordinal()) && getCoverBehaviorAtSide((byte) aSide.ordinal()).letsFluidOut((byte) aSide.ordinal(), getCoverIDAtSide((byte) aSide.ordinal()), getCoverDataAtSide((byte) aSide.ordinal()), mMetaTileEntity.getFluid() == null ? null : mMetaTileEntity.getFluid().getFluid(), this))))

+        if (mTickTimer > 5 && canAccessData() && canMoveFluidOnSide(aSide, mMetaTileEntity.getFluid() == null ? null : mMetaTileEntity.getFluid().getFluid(), false))

             return mMetaTileEntity.drain(aSide, maxDrain, doDrain);

         return null;

     }

 

     @Override

-    public FluidStack drain(ForgeDirection aSide, FluidStack aFluid, boolean doDrain) {

-        if (mTickTimer > 5 && canAccessData() && (aSide == ForgeDirection.UNKNOWN || (mMetaTileEntity.isLiquidOutput((byte) aSide.ordinal()) && getCoverBehaviorAtSide((byte) aSide.ordinal()).letsFluidOut((byte) aSide.ordinal(), getCoverIDAtSide((byte) aSide.ordinal()), getCoverDataAtSide((byte) aSide.ordinal()), aFluid == null ? null : aFluid.getFluid(), this))))

-            return mMetaTileEntity.drain(aSide, aFluid, doDrain);

+    public FluidStack drain(ForgeDirection aSide, FluidStack aFluidStack, boolean doDrain) {

+        if (mTickTimer > 5 && canAccessData() && canMoveFluidOnSide(aSide, aFluidStack == null ? null : aFluidStack.getFluid(), false))

+            return mMetaTileEntity.drain(aSide, aFluidStack, doDrain);

         return null;

     }

 

     @Override

     public boolean canFill(ForgeDirection aSide, Fluid aFluid) {

-        if (mTickTimer > 5 && canAccessData() && (aSide == ForgeDirection.UNKNOWN || (mMetaTileEntity.isLiquidInput((byte) aSide.ordinal()) && getCoverBehaviorAtSide((byte) aSide.ordinal()).letsFluidIn((byte) aSide.ordinal(), getCoverIDAtSide((byte) aSide.ordinal()), getCoverDataAtSide((byte) aSide.ordinal()), aFluid, this))))

+        if (mTickTimer > 5 && canAccessData() && canMoveFluidOnSide(aSide, aFluid, true))

             return mMetaTileEntity.canFill(aSide, aFluid);

         return false;

     }

 

     @Override

     public boolean canDrain(ForgeDirection aSide, Fluid aFluid) {

-        if (mTickTimer > 5 && canAccessData() && (aSide == ForgeDirection.UNKNOWN || (mMetaTileEntity.isLiquidOutput((byte) aSide.ordinal()) && getCoverBehaviorAtSide((byte) aSide.ordinal()).letsFluidOut((byte) aSide.ordinal(), getCoverIDAtSide((byte) aSide.ordinal()), getCoverDataAtSide((byte) aSide.ordinal()), aFluid, this))))

+        if (mTickTimer > 5 && canAccessData() && canMoveFluidOnSide(aSide, aFluid, false)) 

             return mMetaTileEntity.canDrain(aSide, aFluid);

         return false;

     }

 

     @Override

     public FluidTankInfo[] getTankInfo(ForgeDirection aSide) {

-        if (canAccessData() && (aSide == ForgeDirection.UNKNOWN || (mMetaTileEntity.isLiquidInput((byte) aSide.ordinal()) && getCoverBehaviorAtSide((byte) aSide.ordinal()).letsFluidIn((byte) aSide.ordinal(), getCoverIDAtSide((byte) aSide.ordinal()), getCoverDataAtSide((byte) aSide.ordinal()), null, this)) || (mMetaTileEntity.isLiquidOutput((byte) aSide.ordinal()) && getCoverBehaviorAtSide((byte) aSide.ordinal()).letsFluidOut((byte) aSide.ordinal(), getCoverIDAtSide((byte) aSide.ordinal()), getCoverDataAtSide((byte) aSide.ordinal()), null, this))))

+        if (canAccessData() 

+            && (aSide == ForgeDirection.UNKNOWN 

+                || (mMetaTileEntity.isLiquidInput((byte) aSide.ordinal())

+                    && getCoverBehaviorAtSide((byte) aSide.ordinal()).letsFluidIn((byte) aSide.ordinal(), getCoverIDAtSide((byte) aSide.ordinal()), getCoverDataAtSide((byte) aSide.ordinal()), null, this)) 

+                || (mMetaTileEntity.isLiquidOutput((byte) aSide.ordinal()) && getCoverBehaviorAtSide((byte) aSide.ordinal()).letsFluidOut((byte) aSide.ordinal(), getCoverIDAtSide((byte) aSide.ordinal()), getCoverDataAtSide((byte) aSide.ordinal()), null, this))

+                    // Doesn't need to be connected to get Tank Info -- otherwise things can't connect

+               )

+            )

             return mMetaTileEntity.getTankInfo(aSide);

         return new FluidTankInfo[]{};

     }

diff --git a/src/main/java/gregtech/api/metatileentity/implementations/GT_MetaPipeEntity_Fluid.java b/src/main/java/gregtech/api/metatileentity/implementations/GT_MetaPipeEntity_Fluid.java
index d601ceb8b6..eb403aa5f0 100644
--- a/src/main/java/gregtech/api/metatileentity/implementations/GT_MetaPipeEntity_Fluid.java
+++ b/src/main/java/gregtech/api/metatileentity/implementations/GT_MetaPipeEntity_Fluid.java
@@ -594,12 +594,12 @@ public class GT_MetaPipeEntity_Fluid extends MetaPipeEntity {
 

     @Override

     public boolean isLiquidInput(byte aSide) {

-    	return isConnectedAtSide(aSide) && !isInputDisabledAtSide(aSide);

+    	return !isInputDisabledAtSide(aSide);

     }

 

     @Override

     public boolean isLiquidOutput(byte aSide) {

-    	return isConnectedAtSide(aSide);

+    	return true;

     }

 

     public boolean isInputDisabledAtSide(int aSide) {