Merge remote-tracking branch 'origin/master' into feature/glowshrooms

41 files changed, 1698 insertions, 1616 deletions

diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
index 4d6c2b23..639d3965 100644
--- a/.github/workflows/build.yml
+++ b/.github/workflows/build.yml
@@ -9,6 +9,7 @@ on:
       - "COPYING"
       - "COPYING.LESSER"
       - ".gitignore"
+      - "Update Notes"
   pull_request:
     branches:
       - "*"
@@ -17,6 +18,7 @@ on:
       - "COPYING"
       - "COPYING.LESSER"
       - ".gitignore"
+      - "Update Notes"
   workflow_dispatch:
 jobs:
   build:
diff --git a/src/main/java/io/github/moulberry/notenoughupdates/NEUManager.java b/src/main/java/io/github/moulberry/notenoughupdates/NEUManager.java
index 7a2389d4..598ecc2e 100644
--- a/src/main/java/io/github/moulberry/notenoughupdates/NEUManager.java
+++ b/src/main/java/io/github/moulberry/notenoughupdates/NEUManager.java
@@ -36,7 +36,7 @@ import io.github.moulberry.notenoughupdates.recipes.Ingredient;
 import io.github.moulberry.notenoughupdates.recipes.NeuRecipe;
 import io.github.moulberry.notenoughupdates.util.Constants;
 import io.github.moulberry.notenoughupdates.util.HotmInformation;
-import io.github.moulberry.notenoughupdates.util.HypixelApi;
+import io.github.moulberry.notenoughupdates.util.ApiUtil;
 import io.github.moulberry.notenoughupdates.util.ItemResolutionQuery;
 import io.github.moulberry.notenoughupdates.util.ItemUtils;
 import io.github.moulberry.notenoughupdates.util.SBInfo;
@@ -124,9 +124,7 @@ public class NEUManager {
 	public String viewItemAttemptID = null;
 	public long viewItemAttemptTime = 0;
 
-	private final String currentProfile = "";
-	private final String currentProfileBackup = "";
-	public final HypixelApi hypixelApi = new HypixelApi();
+	public final ApiUtil apiUtils = new ApiUtil();
 
 	private final Map<String, ItemStack> itemstackCache = new HashMap<>();
 
diff --git a/src/main/java/io/github/moulberry/notenoughupdates/NEUOverlay.java b/src/main/java/io/github/moulberry/notenoughupdates/NEUOverlay.java
index dbff2be2..14078069 100644
--- a/src/main/java/io/github/moulberry/notenoughupdates/NEUOverlay.java
+++ b/src/main/java/io/github/moulberry/notenoughupdates/NEUOverlay.java
@@ -1460,7 +1460,7 @@ public class NEUOverlay extends Gui {
 		if (index < getSlotsXSize() * getSlotsYSize()) {
 			int actualIndex = index + getSlotsXSize() * getSlotsYSize() * page;
 			List<JsonObject> searchedItems = getSearchedItems();
-			if (actualIndex < searchedItems.size()) {
+			if (0 <= actualIndex && actualIndex < searchedItems.size()) {
 				return searchedItems.get(actualIndex);
 			} else {
 				return null;
diff --git a/src/main/java/io/github/moulberry/notenoughupdates/NotEnoughUpdates.java b/src/main/java/io/github/moulberry/notenoughupdates/NotEnoughUpdates.java
index 9dc00f93..5ff9c088 100644
--- a/src/main/java/io/github/moulberry/notenoughupdates/NotEnoughUpdates.java
+++ b/src/main/java/io/github/moulberry/notenoughupdates/NotEnoughUpdates.java
@@ -35,8 +35,11 @@ import io.github.moulberry.notenoughupdates.listener.ItemTooltipRngListener;
 import io.github.moulberry.notenoughupdates.listener.NEUEventListener;
 import io.github.moulberry.notenoughupdates.listener.OldAnimationChecker;
 import io.github.moulberry.notenoughupdates.listener.RenderListener;
+import io.github.moulberry.notenoughupdates.miscfeatures.AbiphoneWarning;
+import io.github.moulberry.notenoughupdates.miscfeatures.AntiCoopAdd;
+import io.github.moulberry.notenoughupdates.miscfeatures.AuctionBINWarning;
 import io.github.moulberry.notenoughupdates.miscfeatures.AuctionProfit;
-import io.github.moulberry.notenoughupdates.miscfeatures.BazaarSacksProfit;
+import io.github.moulberry.notenoughupdates.miscfeatures.BetterContainers;
 import io.github.moulberry.notenoughupdates.miscfeatures.CrystalOverlay;
 import io.github.moulberry.notenoughupdates.miscfeatures.CrystalWishingCompassSolver;
 import io.github.moulberry.notenoughupdates.miscfeatures.CustomItemEffects;
@@ -115,7 +118,9 @@ import java.nio.charset.StandardCharsets;
 import java.util.HashMap;
 import java.util.Set;
 
-@Mod(modid = NotEnoughUpdates.MODID, version = NotEnoughUpdates.VERSION, clientSideOnly = true)
+@Mod(
+	modid = NotEnoughUpdates.MODID, version = NotEnoughUpdates.VERSION, clientSideOnly = true, useMetadata = true,
+	guiFactory = "io.github.moulberry.notenoughupdates.core.config.MoulConfigGuiForgeInterop")
 public class NotEnoughUpdates {
 	public static final String MODID = "notenoughupdates";
 	public static final String VERSION = "2.1.0-REL";
@@ -299,7 +304,10 @@ public class NotEnoughUpdates {
 		MinecraftForge.EVENT_BUS.register(new SignCalculator());
 		MinecraftForge.EVENT_BUS.register(TrophyRewardOverlay.getInstance());
 		MinecraftForge.EVENT_BUS.register(PowerStoneStatsDisplay.getInstance());
-		MinecraftForge.EVENT_BUS.register(BazaarSacksProfit.getInstance());
+		MinecraftForge.EVENT_BUS.register(new AntiCoopAdd());
+		MinecraftForge.EVENT_BUS.register(AbiphoneWarning.getInstance());
+		MinecraftForge.EVENT_BUS.register(new BetterContainers());
+		MinecraftForge.EVENT_BUS.register(AuctionBINWarning.getInstance());
 		MinecraftForge.EVENT_BUS.register(navigation);
 		MinecraftForge.EVENT_BUS.register(new GlowingMushroomHighlighter());
 
diff --git a/src/main/java/io/github/moulberry/notenoughupdates/auction/APIManager.java b/src/main/java/io/github/moulberry/notenoughupdates/auction/APIManager.java
index 2dc02b7e..1b6896db 100644
--- a/src/main/java/io/github/moulberry/notenoughupdates/auction/APIManager.java
+++ b/src/main/java/io/github/moulberry/notenoughupdates/auction/APIManager.java
@@ -287,23 +287,26 @@ public class APIManager {
 	}
 
 	public void updateLowestBin() {
-		manager.hypixelApi.getMyApiGZIPAsync("lowestbin.json.gz", (jsonObject) -> {
-			if (lowestBins == null) {
-				lowestBins = new JsonObject();
-			}
-			if (!jsonObject.entrySet().isEmpty()) {
-				lastLowestBinUpdate = System.currentTimeMillis();
-			}
-			for (Map.Entry<String, JsonElement> entry : jsonObject.entrySet()) {
-				lowestBins.add(entry.getKey(), entry.getValue());
-			}
-			if (!didFirstUpdate) {
-				ItemPriceInformation.updateAuctionableItemsList();
-				didFirstUpdate = true;
-			}
-			GuiPriceGraph.addToCache(lowestBins, false);
-		}, () -> {
-		});
+		manager.apiUtils
+			.newMoulberryRequest("lowestbin.json.gz")
+			.gunzip()
+			.requestJson()
+			.thenAccept(jsonObject -> {
+				if (lowestBins == null) {
+					lowestBins = new JsonObject();
+				}
+				if (!jsonObject.entrySet().isEmpty()) {
+					lastLowestBinUpdate = System.currentTimeMillis();
+				}
+				for (Map.Entry<String, JsonElement> entry : jsonObject.entrySet()) {
+					lowestBins.add(entry.getKey(), entry.getValue());
+				}
+				if (!didFirstUpdate) {
+					ItemPriceInformation.updateAuctionableItemsList();
+					didFirstUpdate = true;
+				}
+				GuiPriceGraph.addToCache(lowestBins, false);
+			});
 	}
 
 	private void ahNotification() {
@@ -460,20 +463,23 @@ public class APIManager {
 			}
 		};
 
-		manager.hypixelApi.getMyApiGZIPAsync("auctionLast.json.gz", process, () ->
-			System.out.println("Error downloading auction from Moulberry's jank API. :("));
+		manager.apiUtils.newMoulberryRequest("auctionLast.json.gz")
+										.gunzip().requestJson().thenAccept(process);
 
-		manager.hypixelApi.getMyApiGZIPAsync("auction.json.gz", jsonObject -> {
-			if (jsonObject.get("success").getAsBoolean()) {
-				long apiUpdate = (long) jsonObject.get("time").getAsFloat();
-				if (lastApiUpdate == apiUpdate) {
-					lastAuctionUpdate -= 30 * 1000;
-				}
-				lastApiUpdate = apiUpdate;
+		manager.apiUtils
+			.newMoulberryRequest("auction.json.gz")
+			.gunzip().requestJson()
+			.thenAccept(jsonObject -> {
+				if (jsonObject.get("success").getAsBoolean()) {
+					long apiUpdate = (long) jsonObject.get("time").getAsFloat();
+					if (lastApiUpdate == apiUpdate) {
+						lastAuctionUpdate -= 30 * 1000;
+					}
+					lastApiUpdate = apiUpdate;
 
-				process.accept(jsonObject);
-			}
-		}, () -> System.out.println("Error downloading auction from Moulberry's jank API. :("));
+					process.accept(jsonObject);
+				}
+			});
 
 	}
 
@@ -673,8 +679,10 @@ public class APIManager {
 		//System.out.println("Trying to update page: " + page);
 		HashMap<String, String> args = new HashMap<>();
 		args.put("page", "" + page);
-		manager.hypixelApi.getHypixelApiAsync(null, "skyblock/auctions",
-			args, jsonObject -> {
+		manager.apiUtils
+			.newAnonymousHypixelApiRequest("skyblock/auctions")
+			.requestJson()
+			.thenAccept(jsonObject -> {
 				if (jsonObject == null) return;
 
 				if (jsonObject.get("success").getAsBoolean()) {
@@ -701,8 +709,13 @@ public class APIManager {
 				} else {
 					pagesToDownload.addLast(page);
 				}
-			}, () -> pagesToDownload.addLast(page)
-		);
+			})
+			.handle((ignored, ex) -> {
+				if (ex != null) {
+					pagesToDownload.addLast(page);
+				}
+				return null;
+			});
 	}
 
 	private static final Pattern BAZAAR_ENCHANTMENT_PATTERN = Pattern.compile("ENCHANTMENT_(\\D*)_(\\d+)");
@@ -716,11 +729,10 @@ public class APIManager {
 	}
 
 	public void updateBazaar() {
-		manager.hypixelApi.getHypixelApiAsync(
-			NotEnoughUpdates.INSTANCE.config.apiData.apiKey,
-			"skyblock/bazaar",
-			new HashMap<>(),
-			(jsonObject) -> {
+		manager.apiUtils
+			.newHypixelApiRequest("skyblock/bazaar")
+			.requestJson()
+			.thenAccept(jsonObject -> {
 				if (!jsonObject.get("success").getAsBoolean()) return;
 
 				craftCost.clear();
@@ -755,20 +767,23 @@ public class APIManager {
 					}
 				}
 				GuiPriceGraph.addToCache(bazaarJson, true);
-			}
-		);
+			});
 	}
 
 	public void updateAvgPrices() {
-		manager.hypixelApi.getMyApiGZIPAsync("auction_averages/3day.json.gz", (jsonObject) -> {
-			craftCost.clear();
-			auctionPricesJson = jsonObject;
-			lastAuctionAvgUpdate = System.currentTimeMillis();
-		}, () -> {
-		});
-		manager.hypixelApi.getMyApiGZIPAsync("auction_averages_lbin/1day.json.gz", (jsonObject) ->
-			auctionPricesAvgLowestBinJson = jsonObject, () -> {
-		});
+		manager.apiUtils
+			.newMoulberryRequest("auction_averages/3day.json.gz")
+			.gunzip().requestJson().thenAccept((jsonObject) -> {
+						 craftCost.clear();
+						 auctionPricesJson = jsonObject;
+						 lastAuctionAvgUpdate = System.currentTimeMillis();
+					 });
+		manager.apiUtils
+			.newMoulberryRequest("auction_averages_lbin/1day.json.gz")
+			.gunzip().requestJson()
+			.thenAccept((jsonObject) -> {
+				auctionPricesAvgLowestBinJson = jsonObject;
+			});
 	}
 
 	public Set<String> getItemAuctionInfoKeySet() {
diff --git a/src/main/java/io/github/moulberry/notenoughupdates/commands/misc/PronounsCommand.java b/src/main/java/io/github/moulberry/notenoughupdates/commands/misc/PronounsCommand.java
index 6d0ee88d..5a4f1400 100644
--- a/src/main/java/io/github/moulberry/notenoughupdates/commands/misc/PronounsCommand.java
+++ b/src/main/java/io/github/moulberry/notenoughupdates/commands/misc/PronounsCommand.java
@@ -25,7 +25,6 @@ import io.github.moulberry.notenoughupdates.util.MinecraftExecutor;
 import io.github.moulberry.notenoughupdates.util.PronounDB;
 import io.github.moulberry.notenoughupdates.util.Utils;
 import net.minecraft.client.Minecraft;
-import net.minecraft.client.entity.EntityPlayerSP;
 import net.minecraft.client.gui.GuiNewChat;
 import net.minecraft.command.CommandException;
 import net.minecraft.command.ICommandSender;
@@ -75,9 +74,9 @@ public class PronounsCommand extends ClientCommandBase {
 					c.complete(Utils.parseDashlessUUID(uuidString));
 				}
 			});
-			pronouns = c.thenApplyAsync(PronounDB::getPronounsFor);
+			pronouns = c.thenCompose(PronounDB::getPronounsFor);
 		} else {
-			pronouns = CompletableFuture.supplyAsync(() -> PronounDB.getPronounsFor(platform, user));
+			pronouns = PronounDB.getPronounsFor(platform, user);
 		}
 		pronouns.handleAsync((pronounChoice, throwable) -> {
 			if (throwable != null || !pronounChoice.isPresent()) {
@@ -85,7 +84,8 @@ public class PronounsCommand extends ClientCommandBase {
 				return null;
 			}
 			PronounDB.PronounChoice betterPronounChoice = pronounChoice.get();
-			nc.printChatMessageWithOptionalDeletion(new ChatComponentText("§e[NEU] Pronouns for §b" + user + " §eon §b" + platform + "§e:"), id);
+			nc.printChatMessageWithOptionalDeletion(new ChatComponentText(
+				"§e[NEU] Pronouns for §b" + user + " §eon §b" + platform + "§e:"), id);
 			betterPronounChoice.render().forEach(it -> nc.printChatMessage(new ChatComponentText("§e[NEU] §a" + it)));
 			return null;
 		}, MinecraftExecutor.INSTANCE);
diff --git a/src/main/java/io/github/moulberry/notenoughupdates/core/config/MoulConfigGuiForgeInterop.java b/src/main/java/io/github/moulberry/notenoughupdates/core/config/MoulConfigGuiForgeInterop.java
new file mode 100644
index 00000000..40887e54
--- /dev/null
+++ b/src/main/java/io/github/moulberry/notenoughupdates/core/config/MoulConfigGuiForgeInterop.java
@@ -0,0 +1,69 @@
+/*
+ * Copyright (C) 2022 NotEnoughUpdates contributors
+ *
+ * This file is part of NotEnoughUpdates.
+ *
+ * NotEnoughUpdates is free software: you can redistribute it
+ * and/or modify it under the terms of the GNU Lesser General Public
+ * License as published by the Free Software Foundation, either
+ * version 3 of the License, or (at your option) any later version.
+ *
+ * NotEnoughUpdates is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
+ * Lesser General Public License for more details.
+ *
+ * You should have received a copy of the GNU Lesser General Public License
+ * along with NotEnoughUpdates. If not, see <https://www.gnu.org/licenses/>.
+ */
+
+package io.github.moulberry.notenoughupdates.core.config;
+
+import io.github.moulberry.notenoughupdates.core.GuiScreenElementWrapper;
+import io.github.moulberry.notenoughupdates.options.NEUConfigEditor;
+import net.minecraft.client.Minecraft;
+import net.minecraft.client.gui.GuiScreen;
+import net.minecraftforge.fml.client.IModGuiFactory;
+import org.lwjgl.input.Keyboard;
+
+import java.io.IOException;
+import java.util.Set;
+
+public class MoulConfigGuiForgeInterop implements IModGuiFactory {
+	@Override
+	public void initialize(Minecraft minecraft) {}
+
+	@Override
+	public Class<? extends GuiScreen> mainConfigGuiClass() {
+		return WrappedMoulConfig.class;
+	}
+
+	@Override
+	public Set<RuntimeOptionCategoryElement> runtimeGuiCategories() {
+		return null;
+	}
+
+	@Override
+	public RuntimeOptionGuiHandler getHandlerFor(RuntimeOptionCategoryElement runtimeOptionCategoryElement) {
+		return null;
+	}
+
+	public static class WrappedMoulConfig extends GuiScreenElementWrapper {
+
+		private final GuiScreen parent;
+
+		public WrappedMoulConfig(GuiScreen parent) {
+			super(NEUConfigEditor.editor);
+			this.parent = parent;
+		}
+
+		@Override
+		public void handleKeyboardInput() throws IOException {
+			if (Keyboard.getEventKeyState() && Keyboard.getEventKey() == Keyboard.KEY_ESCAPE) {
+				Minecraft.getMinecraft().displayGuiScreen(parent);
+				return;
+			}
+			super.handleKeyboardInput();
+		}
+	}
+}
diff --git a/src/main/java/io/github/moulberry/notenoughupdates/cosmetics/CapeManager.java b/src/main/java/io/github/moulberry/notenoughupdates/cosmetics/CapeManager.java
index 293535e7..7a609a2a 100644
--- a/src/main/java/io/github/moulberry/notenoughupdates/cosmetics/CapeManager.java
+++ b/src/main/java/io/github/moulberry/notenoughupdates/cosmetics/CapeManager.java
@@ -145,46 +145,53 @@ public class CapeManager {
 	}
 
 	private void updateCapes() {
-		NotEnoughUpdates.INSTANCE.manager.hypixelApi.getMyApiAsync("activecapes.json", (jsonObject) -> {
-			if (jsonObject.get("success").getAsBoolean()) {
-				lastJsonSync = jsonObject;
-
-				lastCapeSynced = System.currentTimeMillis();
-				capeMap.clear();
-				for (JsonElement active : jsonObject.get("active").getAsJsonArray()) {
-					if (active.isJsonObject()) {
-						JsonObject activeObj = (JsonObject) active;
-						setCape(activeObj.get("_id").getAsString(), activeObj.get("capeType").getAsString(), false);
+		NotEnoughUpdates.INSTANCE.manager.apiUtils
+			.newMoulberryRequest("activecapes.json")
+			.requestJson()
+			.thenAccept(jsonObject -> {
+				if (jsonObject.get("success").getAsBoolean()) {
+					lastJsonSync = jsonObject;
+
+					lastCapeSynced = System.currentTimeMillis();
+					capeMap.clear();
+					for (JsonElement active : jsonObject.get("active").getAsJsonArray()) {
+						if (active.isJsonObject()) {
+							JsonObject activeObj = (JsonObject) active;
+							setCape(activeObj.get("_id").getAsString(), activeObj.get("capeType").getAsString(), false);
+						}
 					}
 				}
-			}
-		}, () -> System.out.println("[MBAPI] Update capes errored"));
+			});
 
 		if (Minecraft.getMinecraft().thePlayer != null && permSyncTries > 0) {
 			String uuid = Minecraft.getMinecraft().thePlayer.getUniqueID().toString().replace("-", "");
 			permSyncTries--;
-			NotEnoughUpdates.INSTANCE.manager.hypixelApi.getMyApiAsync("permscapes.json", (jsonObject) -> {
-				if (!jsonObject.get("success").getAsBoolean()) return;
-
-				permSyncTries = 0;
-				availableCapes.clear();
-				for (JsonElement permPlayer : jsonObject.get("perms").getAsJsonArray()) {
-					if (!permPlayer.isJsonObject()) continue;
-					String playerUuid = permPlayer.getAsJsonObject().get("_id").getAsString();
-					if (!(playerUuid != null && playerUuid.equals(uuid))) continue;
-					for (JsonElement perm : permPlayer.getAsJsonObject().get("perms").getAsJsonArray()) {
-						if (!perm.isJsonPrimitive()) continue;
-						String cape = perm.getAsString();
-						if (cape.equals("*")) {
-							allAvailable = true;
-						} else {
-							availableCapes.add(cape);
-						}
+			NotEnoughUpdates.INSTANCE.manager.apiUtils
+				.newMoulberryRequest("permscapes.json")
+				.requestJson()
+				.thenAccept(jsonObject -> {
+					if (!jsonObject.get("success").getAsBoolean()) return;
+
+					permSyncTries = 0;
+					availableCapes.clear();
+					for (JsonElement permPlayer : jsonObject.get("perms").getAsJsonArray()) {
+						if (!permPlayer.isJsonObject()) continue;
+						String playerUuid = permPlayer.getAsJsonObject().get("_id").getAsString();
+						if (!(playerUuid != null && playerUuid.equals(uuid))) continue;
+						for (JsonElement perm : permPlayer.getAsJsonObject().get("perms").getAsJsonArray()) {
+							if (!perm.isJsonPrimitive()) continue;
+							String cape = perm.getAsString();
+							if (cape.equals("*")) {
+								allAvailable = true;
+							} else {
+								availableCapes.add(cape);
+							}
 
+						}
+						return;
 					}
-					return;
-				}
-			}, () -> System.out.println("[MBAPI] Update capes errored - perms"));
+
+				});
 		}
 	}
 
diff --git a/src/main/java/io/github/moulberry/notenoughupdates/cosmetics/GuiCosmetics.java b/src/main/java/io/github/moulberry/notenoughupdates/cosmetics/GuiCosmetics.java
index 0e37bed3..12d8c92d 100644
--- a/src/main/java/io/github/moulberry/notenoughupdates/cosmetics/GuiCosmetics.java
+++ b/src/main/java/io/github/moulberry/notenoughupdates/cosmetics/GuiCosmetics.java
@@ -404,21 +404,14 @@ public class GuiCosmetics extends GuiScreen {
 								.getSession()
 								.getProfile(), accessToken, serverId);
 
-							if (wantToEquipCape == null) {
-								NotEnoughUpdates.INSTANCE.manager.hypixelApi.getMyApiAsync(
-									"cgi-bin/changecape.py?capeType=null&serverId=" +
-										serverId + "&username=" + userName,
-									System.out::println,
-									() -> System.out.println("Change cape error")
-								);
-							} else {
-								NotEnoughUpdates.INSTANCE.manager.hypixelApi.getMyApiAsync(
-									"cgi-bin/changecape.py?capeType=" + wantToEquipCape + "&serverId=" +
-										serverId + "&username=" + userName,
-									System.out::println,
-									() -> System.out.println("Change cape error")
-								);
-							}
+							String toEquipName = wantToEquipCape == null ? "null" : wantToEquipCape;
+							NotEnoughUpdates.INSTANCE.manager.apiUtils
+								.newMoulberryRequest("cgi-bin/cha