diff options
| author | Sefa Eyeoglu <contact@scrumplex.net> | 2023-02-15 21:34:12 +0100 |
|---|---|---|
| committer | Sefa Eyeoglu <contact@scrumplex.net> | 2023-02-16 16:41:40 +0100 |
| commit | 33bf85a387e535a27ad23e42b72c5fe7cce7f64c (patch) | |
| tree | 412e516f739d2e8b84aa93e06b33f417e33b33a3 | |
| parent | 89c945ecc8de579e8f93ae302a7dabf4629e188f (diff) | |
| download | PrismLauncher-33bf85a387e535a27ad23e42b72c5fe7cce7f64c.tar.gz PrismLauncher-33bf85a387e535a27ad23e42b72c5fe7cce7f64c.tar.bz2 PrismLauncher-33bf85a387e535a27ad23e42b72c5fe7cce7f64c.zip | |
fix(actions): don't fail if code signing certificate is missing
Signed-off-by: Sefa Eyeoglu <contact@scrumplex.net>
| -rw-r--r-- | .github/workflows/build.yml | 16 |
1 files changed, 12 insertions, 4 deletions
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index c3b9f206..c844f356 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -393,9 +393,13 @@ jobs: - name: Sign executable (Windows) if: runner.os == 'Windows' run: | - cd ${{ env.INSTALL_DIR }} - # We ship the exact same executable for portable and non-portable editions, so signing just once is fine - SignTool sign /fd sha256 /td sha256 /f ../codesign.pfx /p '${{ secrets.WINDOWS_CODESIGN_PASSWORD }}' /tr http://timestamp.digicert.com prismlauncher.exe + if (Get-Content ./codesign.pfx){ + cd ${{ env.INSTALL_DIR }} + # We ship the exact same executable for portable and non-portable editions, so signing just once is fine + SignTool sign /fd sha256 /td sha256 /f ../codesign.pfx /p '${{ secrets.WINDOWS_CODESIGN_PASSWORD }}' /tr http://timestamp.digicert.com prismlauncher.exe + } else { + ":warning: Skipped code signing for Windows, as certificate was not present." >> $env:GITHUB_STEP_SUMMARY + } - name: Package (Windows MinGW-w64, portable) if: runner.os == 'Windows' && matrix.msystem != '' @@ -419,7 +423,11 @@ jobs: - name: Sign installer (Windows) if: runner.os == 'Windows' run: | - SignTool sign /fd sha256 /td sha256 /f codesign.pfx /p '${{ secrets.WINDOWS_CODESIGN_PASSWORD }}' /tr http://timestamp.digicert.com PrismLauncher-Setup.exe + if (Get-Content ./codesign.pfx){ + SignTool sign /fd sha256 /td sha256 /f codesign.pfx /p '${{ secrets.WINDOWS_CODESIGN_PASSWORD }}' /tr http://timestamp.digicert.com PrismLauncher-Setup.exe + } else { + ":warning: Skipped code signing for Windows, as certificate was not present." >> $env:GITHUB_STEP_SUMMARY + } - name: Package (Linux) if: runner.os == 'Linux' |