diff options
| author | txtsd <thexerothermicsclerodermoid@gmail.com> | 2022-02-27 08:35:47 -0800 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2022-02-27 08:35:47 -0800 |
| commit | 5d1ca33b84afee9f09093c27f2eff525325d08cb (patch) | |
| tree | e19e1f8e6216ff3d0fc3b5c82266a49eb083c371 | |
| parent | ca8b62291fe47554effaf625b5c52807802a58a9 (diff) | |
| download | PrismLauncher-5d1ca33b84afee9f09093c27f2eff525325d08cb.tar.gz PrismLauncher-5d1ca33b84afee9f09093c27f2eff525325d08cb.tar.bz2 PrismLauncher-5d1ca33b84afee9f09093c27f2eff525325d08cb.zip | |
Apply suggestions from code review
Co-authored-by: LennyMcLennington <lenny@sneed.church>
| -rw-r--r-- | CMakeLists.txt | 4 | ||||
| -rw-r--r-- | launcher/Application.cpp | 2 |
2 files changed, 3 insertions, 3 deletions
diff --git a/CMakeLists.txt b/CMakeLists.txt index 02900f83..c370b6ea 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -189,7 +189,7 @@ elseif(UNIX) set(JARS_DEST_DIR "bin/jars") # launcher/Application.cpp will use this value - set(Launcher_APP_BINARY_DEFS "-DLauncher_PORTABLE=1") + set(Launcher_APP_BINARY_DEFS "-DLAUNCHER_PORTABLE") # Install basic runner script configure_file(launcher/Launcher.in "${CMAKE_CURRENT_BINARY_DIR}/LauncherScript" @ONLY) @@ -201,7 +201,7 @@ elseif(UNIX) set(LAUNCHER_METAINFO_DEST_DIR "share/metainfo" CACHE STRING "Path to the metainfo directory") set(LAUNCHER_ICON_DEST_DIR "share/icons/hicolor/scalable/apps" CACHE STRING "Path to the scalable icon directory") - set(Launcher_APP_BINARY_DEFS "-DMULTIMC_JARS_LOCATION=${CMAKE_INSTALL_PREFIX}/${JARS_DEST_DIR}" "-DLauncher_PORTABLE=0") + set(Launcher_APP_BINARY_DEFS "-DMULTIMC_JARS_LOCATION=${CMAKE_INSTALL_PREFIX}/${JARS_DEST_DIR}") install(FILES ${CMAKE_CURRENT_BINARY_DIR}/${Launcher_Desktop} DESTINATION ${LAUNCHER_DESKTOP_DEST_DIR}) install(FILES ${CMAKE_CURRENT_BINARY_DIR}/${Launcher_MetaInfo} DESTINATION ${LAUNCHER_METAINFO_DEST_DIR}) diff --git a/launcher/Application.cpp b/launcher/Application.cpp index bf644ea6..0ce80d4b 100644 --- a/launcher/Application.cpp +++ b/launcher/Application.cpp @@ -294,7 +294,7 @@ Application::Application(int &argc, char **argv) : QApplication(argc, argv) } else { -#if !Launcher_PORTABLE || defined(Q_OS_MAC) +#if !defined(LAUNCHER_PORTABLE) || defined(Q_OS_MAC) QDir foo(FS::PathCombine(QStandardPaths::writableLocation(QStandardPaths::AppDataLocation), "..")); dataPath = foo.absolutePath(); adjustedBy += dataPath; |