aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorseth <getchoo@tuta.io>2022-12-15 18:33:03 -0500
committerseth <getchoo@tuta.io>2022-12-15 18:50:35 -0500
commit7b805a38b9d87c5c5a765b692beca25f6944e897 (patch)
tree3a4f16170b400396cf9fa677e9a4cb14c96033aa
parentfdac978c842ed3a2ddec61603011abb881305a3a (diff)
downloadPrismLauncher-7b805a38b9d87c5c5a765b692beca25f6944e897.tar.gz
PrismLauncher-7b805a38b9d87c5c5a765b692beca25f6944e897.tar.bz2
PrismLauncher-7b805a38b9d87c5c5a765b692beca25f6944e897.zip
feat: improve msvc build flags
- adds /GL, /Gy, and /LTCG for better optimizations - adds /Gw for a smaller binary size - adds /guard:cf for added security at runtime - removes unneeded /GS flag as that's already enabled by default Signed-off-by: seth <getchoo@tuta.io>
-rw-r--r--CMakeLists.txt12
1 files changed, 8 insertions, 4 deletions
diff --git a/CMakeLists.txt b/CMakeLists.txt
index 75360f86..db731c07 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -28,19 +28,23 @@ set(CMAKE_CXX_STANDARD 17)
set(CMAKE_C_STANDARD 11)
include(GenerateExportHeader)
if(MSVC)
- # Use /W4 as /Wall includes unnesserey warnings such as added padding to structs
+ # /GL enables whole program optimizations
+ # /Gw helps reduce binary size
+ # /Gy allows the compiler to package individual functions
+ # /guard:cf enables control flow guard
# /permissive- specify standards-conforming compiler behavior, also enabled by Qt6, default on with std:c++20
- # /GS Adds buffer security checks, default on but incuded anyway to mirror gcc's fstack-protector flag
- set(CMAKE_CXX_FLAGS "/W4 /permissive- /GS ${CMAKE_CXX_FLAGS}")
+ # Use /W4 as /Wall includes unnesserey warnings such as added padding to structs
+ set(CMAKE_CXX_FLAGS "/GL /Gw /Gy /guard:cf /permissive- /W4 ${CMAKE_CXX_FLAGS}")
# LINK accepts /SUBSYSTEM whics sets if we are a WINDOWS (gui) or a CONSOLE programs
# This implicitly selects an entrypoint specific to the subsystem selected
# qtmain/QtEntryPointLib provides the correct entrypoint (wWinMain) for gui programs
# Additinaly LINK autodetects we use a GUI so we can omit /SUBSYSTEM
# This allows tests to still use have console without using seperate linker flags
+ # /LTCG allows for linking wholy optimizated programs
# /MANIFEST:NO disables generating a manifest file, we instead provide our own
# /STACK sets the stack reserve size, ATL's pack list needs 3-4 MiB as of November 2022, provide 8 MiB
- set(CMAKE_EXE_LINKER_FLAGS "/MANIFEST:NO /STACK:8388608 ${CMAKE_EXE_LINKER_FLAGS}")
+ set(CMAKE_EXE_LINKER_FLAGS "/LTCG /MANIFEST:NO /STACK:8388608 ${CMAKE_EXE_LINKER_FLAGS}")
# See https://github.com/ccache/ccache/issues/1040
# Note, CMake 3.25 replaces this with CMAKE_MSVC_DEBUG_INFORMATION_FORMAT